Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of tschumann@chromium.org base_unittests failing on multiple builders Builders failed on: - linux-chromeos-rel: https://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-rel - Linux Tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests Suspecting this CL: https://chromium-review.googlesource.com/c/chromium/src/+/881017
Revert on the way: https://chromium-review.googlesource.com/c/chromium/src/+/922068
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a5d5d9d63a1540226bfb22a4db878efee822a6d commit 5a5d5d9d63a1540226bfb22a4db878efee822a6d Author: Tim Schumann <tschumann@chromium.org> Date: Thu Feb 15 16:29:12 2018 Revert "remove ThreadLocalStorage::StaticSlot" This reverts commit 88a96c6e1b592b920cd00655b88225334c0c4541. Reason for revert: breaks base_unittests failing on multiple builders (ThreadHeapUsageShimTest.HooksIntoMallocWhenShimAvailable) BUG= 812650 Original change's description: > remove ThreadLocalStorage::StaticSlot > > in favor of the pattern with > NoDestructor<ThreadLocalStorage::Slot> as discussed on PS1 @ > https://chromium-review.googlesource.com/c/chromium/src/+/881017/1 > > StaticSlot has been subject to a possible initialization race: > CHECK_NE(slot_, kInvalidSlotValue) in StaticSlot::Initialize > could fail if another thread initialized it to kInvalidSlotValue > > Change-Id: Iefaa1dde6f85842d20561851a9a26ad5f3a20973 > Reviewed-on: https://chromium-review.googlesource.com/881017 > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Miriam Gershenson <mgersh@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537009} TBR=pkasting@chromium.org,danakj@chromium.org,gab@chromium.org,mgersh@chromium.org,erikchen@chromium.org,rsesek@chromium.org,akhaustov@yandex-team.ru Change-Id: If5a61c5448c361ba2df22909930f6b1e8879e454 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/922068 Reviewed-by: Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#537040} [modify] https://crrev.com/5a5d5d9d63a1540226bfb22a4db878efee822a6d/base/debug/thread_heap_usage_tracker.cc [modify] https://crrev.com/5a5d5d9d63a1540226bfb22a4db878efee822a6d/base/debug/thread_heap_usage_tracker.h [modify] https://crrev.com/5a5d5d9d63a1540226bfb22a4db878efee822a6d/base/debug/thread_heap_usage_tracker_unittest.cc [modify] https://crrev.com/5a5d5d9d63a1540226bfb22a4db878efee822a6d/base/no_destructor.h [modify] https://crrev.com/5a5d5d9d63a1540226bfb22a4db878efee822a6d/base/threading/thread_local_storage.cc [modify] https://crrev.com/5a5d5d9d63a1540226bfb22a4db878efee822a6d/base/threading/thread_local_storage.h [modify] https://crrev.com/5a5d5d9d63a1540226bfb22a4db878efee822a6d/base/threading/thread_local_storage_unittest.cc [modify] https://crrev.com/5a5d5d9d63a1540226bfb22a4db878efee822a6d/base/trace_event/heap_profiler_allocation_context_tracker.cc [modify] https://crrev.com/5a5d5d9d63a1540226bfb22a4db878efee822a6d/chrome/common/profiling/memlog_allocator_shim.cc [modify] https://crrev.com/5a5d5d9d63a1540226bfb22a4db878efee822a6d/components/url_formatter/idn_spoof_checker.cc [modify] https://crrev.com/5a5d5d9d63a1540226bfb22a4db878efee822a6d/net/dns/dns_reloader.cc [modify] https://crrev.com/5a5d5d9d63a1540226bfb22a4db878efee822a6d/third_party/crashpad/README.chromium [modify] https://crrev.com/5a5d5d9d63a1540226bfb22a4db878efee822a6d/third_party/crashpad/crashpad/util/thread/thread_log_messages.cc
Issue 812649 has been merged into this issue.
Comment 1 by tschumann@chromium.org
, Feb 15 2018Owner: erikc...@chromium.org
Status: Assigned (was: Available)