New issue
Advanced search Search tips

Issue 812647 link

Starred by 1 user
Status: Verified
Owner:
aleventhal@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Location bar's hint to "press tab to search XXX" should be accessible with a screen reader

Project Member Reported by aleventhal@chromium.org, Feb 15 2018 
The keyword hint view shows up when a user types something in a location bar that can become a keyword search if the tab key is pressed. For example, go to the location bar, and type "aol.c". On the right side of the location bar, some subtle light hint text is shown to press the tab key.

Some accessibility improvements are needed.
- The keyword hint view should not be considered focusable.
- The keyword hint view needs an accessible name.
- When it appears, an alert event should be fired so that screen readers can speak it
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37a0c6bb51204c4310c6897e00db0872a161ea1c

commit 37a0c6bb51204c4310c6897e00db0872a161ea1c
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Fri Feb 16 02:39:14 2018

Keyword hint view screen reader accessibility

The keyword hint, which is shown when a tab key will begin a keyword
search, tells users about the feature and should be spoken via screen
readers.

- The alert ends up being fired only when the keyword changes.
- It is fired the first time the hint is shown and not again
until a different hint his shown, even if the hint disappears and
reappears during that time (e.g backspace + retyping a character).
this is less noisy overall for the screen reader user.
- The alert event exists on all platforms we support.

Bug:  812647 
Change-Id: Ibcfa0da3e40aeb54cc8da43e77b869a3eb20836f
Reviewed-on: https://chromium-review.googlesource.com/922021
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537126}
[modify] https://crrev.com/37a0c6bb51204c4310c6897e00db0872a161ea1c/chrome/app/generated_resources.grd
[modify] https://crrev.com/37a0c6bb51204c4310c6897e00db0872a161ea1c/chrome/browser/ui/views/location_bar/keyword_hint_view.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93e1eb3e0f2627e7c17d0327498a361ae5f30f7f

commit 93e1eb3e0f2627e7c17d0327498a361ae5f30f7f
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Mon Feb 26 22:20:37 2018

Use alert role so that keyword hint view alert event is spoken by screen readers

The correct accessibility alert event was fired but screen readers ignored it
since it was not on an object with the alert role.

Bug:  812647 
Change-Id: Id0cc1fbcbaeaeb20e2ef546b463304a3aaaa1af3
Reviewed-on: https://chromium-review.googlesource.com/924884
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539285}
[modify] https://crrev.com/93e1eb3e0f2627e7c17d0327498a361ae5f30f7f/chrome/browser/ui/views/location_bar/keyword_hint_view.cc
[modify] https://crrev.com/93e1eb3e0f2627e7c17d0327498a361ae5f30f7f/ui/views/accessibility/native_view_accessibility_base.cc
[modify] https://crrev.com/93e1eb3e0f2627e7c17d0327498a361ae5f30f7f/ui/views/accessibility/native_view_accessibility_win_unittest.cc
[modify] https://crrev.com/93e1eb3e0f2627e7c17d0327498a361ae5f30f7f/ui/views/accessibility/view_accessibility.cc
[modify] https://crrev.com/93e1eb3e0f2627e7c17d0327498a361ae5f30f7f/ui/views/accessibility/view_accessibility.h

Comment 3 by aleventhal@chromium.org, Feb 26 2018

Labels: a11y-testers
Status: Fixed (was: Assigned)
Please verify.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4a5110d3491d5a16e6bfed6f7f0f74a1e692e65

commit e4a5110d3491d5a16e6bfed6f7f0f74a1e692e65
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue Feb 27 17:40:23 2018

Make ViewAccessibility::OverrideIsLeaf work on Chrome OS too.

Bug:  812647 
Test: manually tested  bug 812647  with ChromeVox
Change-Id: I9110c0d9e301dad9315cfbcdb9572a1c91c90a16
Reviewed-on: https://chromium-review.googlesource.com/938753
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539489}
[modify] https://crrev.com/e4a5110d3491d5a16e6bfed6f7f0f74a1e692e65/ui/views/accessibility/ax_view_obj_wrapper.cc

Comment 5 by dsexton@chromium.org, Mar 12 2018

Status: Verified (was: Fixed)

Comment 6 by dsexton@chromium.org, Mar 12 2018

Labels: -a11y-testers
►

Sign in to add a comment