New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812638 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty Leak

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Feb 15 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of gab@chromium.org

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty Leak

Builders failed on: 
- WebKit Linux Trusty Leak: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak

Latest Error:
  Traceback (most recent call last):
    _RunStoryAndProcessErrorIfNeeded at /b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:147
      test.DidRunStory(state.platform, results)
    DidRunStory at /b/s/w/ir/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_measurement.py:290
      trace_result, _ = platform.tracing_controller.StopTracing()
    StopTracing at /b/s/w/ir/third_party/catapult/telemetry/telemetry/core/tracing_controller.py:53
      return self._tracing_controller_backend.StopTracing()
    StopTracing at /b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py:130
      self._IssueClockSyncMarker()
    _IssueClockSyncMarker at /b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py:234
      self._RecordIssuerClockSyncMarker)
    RecordClockSyncMarker at /b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py:178
      raise ChromeClockSyncError('Cannot issue clock sync. No devtools clients')
  ChromeClockSyncError: Cannot issue clock sync. No devtools clients

@https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.11_Tests%2F23413%2F%2B%2Frecipes%2Fsteps%2Ftelemetry_perf_unittests_on_Mac-10.11%2F0%2Fstdout


 

Comment 1 by gab@chromium.org, Feb 15 2018

Cc: mstensho@chromium.org tschumann@chromium.org aboxhall@chromium.org
Range is 3 CLs, all touching layout.

https://chromium.googlesource.com/chromium/src/+log/8f4afda5d2320b1868666d8d6e49936732317ea5..9d12e87aae0af652e39687d856c7979a1ad4a36b?pretty=fuller&n=10000

Comment 2 by gab@chromium.org, Feb 15 2018

Owner: gab@chromium.org
Status: Started (was: Available)
Reverting high-confidence suspect @ https://chromium-review.googlesource.com/c/chromium/src/+/921841
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfd1908c46aafc813a9e27fad7687d7d364c59c0

commit cfd1908c46aafc813a9e27fad7687d7d364c59c0
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Feb 15 15:06:55 2018

Revert "Trying to re-land: Use a PromiseResolver to store reference to Element in getComputedAccessibleNode() implementation."

This reverts commit c0070250a866f55741cc45736d88acc1a4efcdca.

Reason for revert: breaks webkit_layout_tests,  crbug.com/812638 

Original change's description:
> Trying to re-land: Use a PromiseResolver to store reference to Element in getComputedAccessibleNode() implementation.
> 
> Bug: 792783
> Change-Id: I92a316781e546a346c166fd33c3983417184db22
> Reviewed-on: https://chromium-review.googlesource.com/912054
> Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537001}

TBR=aboxhall@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org

Change-Id: If2cc49e9b72799bf2afb781aeb066f41855019e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 792783,  812638 
Reviewed-on: https://chromium-review.googlesource.com/921841
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537017}
[modify] https://crrev.com/cfd1908c46aafc813a9e27fad7687d7d364c59c0/third_party/WebKit/LayoutTests/accessibility/aom-computed-accessible-node.html
[modify] https://crrev.com/cfd1908c46aafc813a9e27fad7687d7d364c59c0/third_party/WebKit/LayoutTests/accessibility/aom-computed-int-properties.html
[modify] https://crrev.com/cfd1908c46aafc813a9e27fad7687d7d364c59c0/third_party/WebKit/LayoutTests/accessibility/aom-computed-relation-accessors.html
[modify] https://crrev.com/cfd1908c46aafc813a9e27fad7687d7d364c59c0/third_party/WebKit/LayoutTests/accessibility/aom-computed-string-properties.html
[modify] https://crrev.com/cfd1908c46aafc813a9e27fad7687d7d364c59c0/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html
[delete] https://crrev.com/e00795dc91f3ab7835f0e34b418cd7729a53a068/third_party/WebKit/LayoutTests/accessibility/idle-promise-helpers.js
[modify] https://crrev.com/cfd1908c46aafc813a9e27fad7687d7d364c59c0/third_party/WebKit/Source/core/dom/ComputedAccessibleNode.cpp
[modify] https://crrev.com/cfd1908c46aafc813a9e27fad7687d7d364c59c0/third_party/WebKit/Source/core/dom/ComputedAccessibleNode.h
[modify] https://crrev.com/cfd1908c46aafc813a9e27fad7687d7d364c59c0/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/cfd1908c46aafc813a9e27fad7687d7d364c59c0/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/cfd1908c46aafc813a9e27fad7687d7d364c59c0/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/cfd1908c46aafc813a9e27fad7687d7d364c59c0/third_party/WebKit/Source/core/dom/ElementRareData.cpp
[modify] https://crrev.com/cfd1908c46aafc813a9e27fad7687d7d364c59c0/third_party/WebKit/Source/core/dom/ElementRareData.h
[modify] https://crrev.com/cfd1908c46aafc813a9e27fad7687d7d364c59c0/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Comment 4 by gab@chromium.org, Feb 15 2018

Status: Fixed (was: Started)

Sign in to add a comment