Sending feedback reports always sends sync logs for "Default" profile |
|||||
Issue description
What steps will reproduce the problem?
(1) Open Chrome, delete "Default" profile, close chrome
(you can use something like "chrome --user-data-dir=/tmp/chrome" to get a fresh directory)
(2) Check that the profile directory has no "Default" folder but there is a "Profile 1" folder.
(3) Open Chrome
(4) Click Help > Report an Issue
(5) Notice that the Default folder is created again and profile manager shows a new profile
What is the expected result?
Sending feedback reports shouldn't create profiles.
What happens instead?
Chrome is trying to load the default profile. It doesn't exist, so it is created. The profile directory has a "Default" folder and the profile manager is showing a "Profile 2".
The issue is that ChromeInternalLogSource::PopulateSyncLogs calls ProfileManager::GetPrimaryUserProfile which always returns the Default profile.
,
Feb 15 2018
+rkc@, who created ChromeInternalLogSource and moved it from chromeos/ to chrome/
,
Nov 9
ChromeInternalLogSource::PopulateSyncLogs has a comment saying "We are only interested in sync logs for the primary user profile." Is this correct? As explained above, the "PrimaryProfile" might not exist on Linux, Windows or Mac. https://cs.chromium.org/chromium/src/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc?l=269&rcl=5c30a7925aa902990811797ff7dcd2cf89994947
,
Nov 12
,
Nov 19
The concept of a "primary user profile" doesn't even really make sense outside of ChromeOS. Also, from the comment on GetPrimaryUserProfile(): // This function is temporary and will soon be moved to ash. As such avoid // using it at all cost. ...added in January 2014. Mhm. I think the problem happens here [1] - GetInitialProfileDir() doesn't really make sense. Maybe this should just use ProfileManager::GetLastUsedProfile()? [1] https://cs.chromium.org/chromium/src/chrome/browser/profiles/profile_manager.cc?rcl=189c388247f195c2bf632a458ec0b1a0d3404275&l=1430
,
Jan 15
Triage ping, in case anyone is interested in picking this up.
,
Jan 21
(2 days ago)
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dullweber@chromium.org
, Feb 15 2018