New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812598 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Menu is truncated in site info page

Project Member Reported by pnangunoori@chromium.org, Feb 15 2018

Issue description

Chrome Version: 66.0.3348.0
OS: Windows 10

What steps will reproduce the problem?
(1) Navigate to the URL: http://testsafebrowsing.appspot.com/
(2) Click on link: [A/W/M/L/C] Should show a phishing warning: 
(3) Proceed anyway to the site.
(4) Click on "Site Info".
(5) Continue clicking and changing option of Ad's form Block to Allow

What is the expected result?
Sites setting option is truncated.

What happens instead?
Sites setting option should not get truncated.

Bisect Information:

Good Build: 66.0.3346.0 (536238)
Bad Build: 66.0.3347.0 (536620)

Unable to provide the per-revision bisect because of:
1. Script provided all bad builds - All the builds gave "Aw Snap" error in the observed range.
2. Even increasing the range by 200 revisions didn't help.
3. hasbisect (old script) didn't give any builds.

Hence, providing the manual bisect and possible CL's could be the suspect:

https://chromium.googlesource.com/chromium/src/+/0ac6a49efec7bee42c990f703488c678209e2766

https://chromium.googlesource.com/chromium/src/+/924ee4d1ad21955a2d75a975118e3559b8598b3f

jialiul@ and pbos@ -- Request you to look into this issue. Ignore and kindly reassign to the respective owner if there is nothing to do with your change for this issue.

Thanks!
 
TextTruncatedInSiteInfo.webm
2.7 MB View Download

Comment 1 by pbos@chromium.org, Feb 16 2018

Cc: patricia...@chromium.org bsep@chromium.org
The label gets resized, which resizes the dialog, then the label gets resized again to be taller but the dialog height doesn't seem to resize appropriately.

patricialor@ is this part of your ownership and you have spare cycles? If not we might be suited to take a look.

bsep@ this seems brittle and I wouldn't be surprised if some of this ties into the resizing (expanding) dialog. I don't know if this dialog sizing has been touched w/r/t Harmony, but I've seen this dialog expand unexpectedly.
Cc: -patricia...@chromium.org
Owner: patricia...@chromium.org
Status: Assigned (was: Untriaged)
Agree with pbos@, assign to patricialor@. 
Labels: Needs-Feedback
I think this is a views::StyledLabel issue - probably its CalculatePreferredSize() is returning an incorrect height when the "Learn more" link gets wrapped around to the next line. This is just a guess though, I can't say for sure :(

RE #c1, I do own this but Page Info is on the backburner for me and this will be lower priority.

pnangunoori@ - I wasn't able to reproduce this bug, did you have any specific settings turned on? I tried turning on "Automatically send some system information and page content to Google to help detect dangerous apps and sites" but that didn't seem to help. Thank you for finding this!
Labels: OS-Windows
patricialor@ -- Thanks for looking into the issue. No, I didn't turn on any settings. I worked on a newly installed Chrome.

Ok, thanks for your reply! jialiul@ - do you know how to get the interstitial and "Dangerous" page info text to show up?
Labels: TE-Goodbug

Comment 7 by pbos@chromium.org, Feb 22 2018

Re #5: The video in #1 shows the repro flow (and fwiw they're generally very useful) that takes you to:

http://testsafebrowsing.appspot.com/s/phishing.html

This shows the red interstitial for me in Canary. Continue through, click Dangerous and switch from "Block (default)" to "Allow". This makes the dropdown menu smaller (possibly the whole dialog thinner) and cause different wrapping behavior in the above text. The dialog height does not update.

If the interstitial doesn't trigger, I'd try an internal build but I would expect this to work in Chromium too.

Sign in to add a comment