New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812597 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

webkit_tests failing on chromium.webkit/WebKit Android (Nexus4)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Feb 15 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of tschumann@chromium.org

webkit_tests failing on chromium.webkit/WebKit Android (Nexus4)

Builders failed on: 
- WebKit Android (Nexus4): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29

from the webkit_tests log:

04:26:36.309 29010 You are missing NotoSansCJKkr-Regular.otf under ['third_party/content_shell_fonts/content_shell_test_fonts'].
You are missing NotoSansCJKkr-Regular.otf under ['third_party/content_shell_fonts/content_shell_test_fonts'].
step returned non-zero exit code: 252

Seems to be related to https://chromium-review.googlesource.com/c/chromium/src/+/910122

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d12e87aae0af652e39687d856c7979a1ad4a36b

commit 9d12e87aae0af652e39687d856c7979a1ad4a36b
Author: Tim Schumann <tschumann@chromium.org>
Date: Thu Feb 15 13:27:12 2018

Revert "Add NotoSansCJK font to content_shell_fonts collection."

This reverts commit 81325ee9e2a61676bc3b020e1170a6f7b93f2556.

Reason for revert: Seems to have broken the Webkit Android build.

Example from: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Android__Nexus4_%2F74342%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout

BUG= 812597 

Original change's description:
> Add NotoSansCJK font to content_shell_fonts collection.
> 
> Currently the set of fonts used for layout tests on Android and Fuchsia
> doesn't include any Chinese, Japanese or Korean fonts, so they render tofu
> on the pixel tests that contain text in these languages. Adding NotoSansCJK
> so these tests can render properly.
> 
> Bug: 778467,  787020 
> Change-Id: Id29b65525d5af0be96984db69e62d9d198b87fd4
> Reviewed-on: https://chromium-review.googlesource.com/910122
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536920}

TBR=sky@chromium.org,dpranke@chromium.org,sergeyu@chromium.org,drott@chromium.org

Change-Id: I3894b1c956837796b1b0bb5fa4fc3e9e2e6eba8f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 778467,  787020 
Reviewed-on: https://chromium-review.googlesource.com/921501
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537002}
[modify] https://crrev.com/9d12e87aae0af652e39687d856c7979a1ad4a36b/content/shell/test_runner/resources/fonts/android_fallback_fonts.xml
[modify] https://crrev.com/9d12e87aae0af652e39687d856c7979a1ad4a36b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/9d12e87aae0af652e39687d856c7979a1ad4a36b/third_party/content_shell_fonts/BUILD.gn
[modify] https://crrev.com/9d12e87aae0af652e39687d856c7979a1ad4a36b/third_party/content_shell_fonts/README.chromium
[modify] https://crrev.com/9d12e87aae0af652e39687d856c7979a1ad4a36b/third_party/content_shell_fonts/content_shell_test_fonts.tar.gz.sha1
[modify] https://crrev.com/9d12e87aae0af652e39687d856c7979a1ad4a36b/ui/gfx/test/fontconfig_util_linux.cc

Comment 2 by gab@chromium.org, Feb 15 2018

Cc: gab@chromium.org sergeyu@chromium.org dpa...@chromium.org yosin@chromium.org
 Issue 812578  has been merged into this issue.
Labels: -Sheriff-Chromium
Revert fixed the build. Removing Sheriff label.

Comment 4 by gab@chromium.org, Feb 15 2018

Status: Fixed (was: Available)
Let's just close it, another bug can be opened to track fixing CL if not using the main bug of that feature already.

Sign in to add a comment