New issue
Advanced search Search tips

Issue 812591 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Underline on 'Learn More' link is not seen in chrome://kill page.

Reported by db...@etouch.net, Feb 15 2018

Issue description

Chrome Version: 66.0.3346.8 Revision c7acb5325614d652d9dd02cca2bfb0c481ac6dfd-refs/branch-heads/3346@{#13}(32/64 bit)
OS: Windows(7,8,8.1,10), Linux(14.01 LTS)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://kill page.
(2) Observe underline on 'Learn More' link.

Actual: Underline under 'Learn More' link is not seen in chrome://kill page.

Expected: Underline under 'Learn More' link should seen in chrome://kill page.

This is a regression issue, broken in 'M64' and providing the bisect using per-revision bisect,

Good Build:64.0.3256.0(Revision: 513349)
Bad Build: 64.0.3257.0(Revision: 513642)

You are probably looking for a change made after 513360 (known good), but no later than 513361 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/a28eb737c4c9424d7656ada19b688af854777968..1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc

Suspect: https://chromium.googlesource.com/chromium/src/+/1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc

@Trent Apted: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.


Note: 1.This issue is also seen on M64 Stable (build #64.0.3282.168),M65 Beta(build #65.0.3325.73)and M66 Canary(build #66.0.3348.0).
      2. Above issue is not seen on Mac(10.12.6,10.13.1,10.13.2) OS.

 
Actual_Underline.mp4
156 KB View Download
Expected_Underline.mp4
118 KB View Download

Comment 1 by db...@etouch.net, Feb 15 2018

Labels: RegressedIn-64 FoundIn-65 FoundIn-64 FoundIn-66 Target-66 Target-65 Target-64

Comment 2 by tapted@chromium.org, Feb 15 2018

Cc: bsep@chromium.org tapted@chromium.org
Labels: Proj-HarmonyDialogs
Owner: bettes@chromium.org
+bettes for UX input. I believe this is working as intended -- under MD we render an underline on links only to indicate focus. I don't know if we want to make an exception for the sad tab (I'm hoping not, since then we'd need to maintain a separate codepath for indicating key focus)
Status: WontFix (was: Assigned)
Working as intended per #2

Sign in to add a comment