New issue
Advanced search Search tips

Issue 812584 link

Starred by 1 user
Status: Duplicate
Merged: issue 848193
Owner:
paulir...@chromium.org
Closed: Sep 4
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Default focus is not seen on ‘perform an audit..’ button in audit section.

Reported by pranjali...@etouch.net, Feb 15 2018 
Chrome Version: 66.0.3346.8 (Official Build) c7acb5325614d652d9dd02cca2bfb0c481ac6dfd-refs/branch-heads/3346@{#13} (64 bit)

OS: Windows(7,8,8.1,10) and Linux(14.04 LTS) , Mac(10.12.6 , 10.13.1 , 10.13.4) OS

Steps to reproduce: 
1. Launch chrome and Open DevTools window on NTP.
2. Go to ‘Performance’ section and record some activities.
3. Now go to ‘Audit’ section and observe default focus.
 
Actual Result: Default focus is not seen on ‘perform an audit..’ button in audit section.
Expected Result: Default focus should be seen on ‘perform an audit..’ button in audit section.

This is a non-regression issue, seen from M-60 build #60.0.3072.0. 

NOTE: Issue is also seen on M-64 Stable(build #64.0.3282.167 ) , Beta (build # 65.0.3325.73) , Dev  M-66 (build #66.0.3343.3) and Canary M-66 (build #66.0.3348.0).
Actual_result.mov
2.9 MB View Download

Comment 1 by rbasuvula@chromium.org, Feb 15 2018

Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!

Comment 2 by paulir...@chromium.org, Feb 21 2018

Owner: paulir...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4daa74328a267cbe6b64ee846647dce1a901430

commit e4daa74328a267cbe6b64ee846647dce1a901430
Author: Paul Irish <paulirish@chromium.org>
Date: Thu Feb 22 01:27:59 2018

DevTools: [Audits] Autofocus the primary buttons

Bug:  812584 ,  723966 
Change-Id: Id293f15f5fb556878b2ca5c7bf7d2ee82caf742a
Reviewed-on: https://chromium-review.googlesource.com/929587
Reviewed-by: Patrick Hulce <phulce@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538300}
[modify] https://crrev.com/e4daa74328a267cbe6b64ee846647dce1a901430/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Dialog.js

Comment 4 by viswa.karala@chromium.org, Feb 22 2018

Labels: Needs-Feedback
Able to reproduce the issue on chrome version 64.0.3282.167(as per comment#0) using Linux 14.04 with steps mentioned below:
1) Launched chrome version, opened NTP and Devtools
2) Navigated to performance tab, recorded some activity and navigated to Audit sections nad observed the default focus
3) Default focus is not seen on "perform an audit"
Observations:
Tested the issue on latest chrome build 66.0.3352.0, seen the same behaviour i.e., focus is not seen on "perform an audit"

@paulirish:
Please find the attached screen cast for your reference and please help in confirming the fix.

Thanks!
812584.ogv
1.3 MB View Download

Comment 5 by paulir...@chromium.org, Mar 1 2018 

Thanks for taking a second look. 

Turns out this goes deep and is not a straightforward fix.

We'll get to it in a later milestone.

Comment 6 by paulir...@chromium.org, Sep 4

Mergedinto: 848193
Status: Duplicate (was: Assigned)
►

Sign in to add a comment