New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812576 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

No change for system notification from "Download paused" to "Download pending"

Project Member Reported by mar...@mwiacek.com, Feb 15 2018

Issue description

Device name:s7

From "Settings > About Chrome"
Application version:66.0.3347.3
Operating system:7

Steps to reproduce:
(1)go offline
(2)open any url
(3)download when online
(4)go into downloads
(5)pause download
(6)resume download

Expected result:
Android notification is changing from "Download paused" to "Download pending"

Actual result:
Android notification shows "Download paused"
 
Cc: jming@chromium.org
Owner: dim...@chromium.org
+dimich@ for offline pages.

Comment 2 by jming@chromium.org, Feb 15 2018

Cc: cmsy@google.com
Labels: Needs-triage-Mobile
Labels: Needs-Feedback Triaged-Mobile
Tested the issue in Android and couldn't reproduce the issue. Observed the "Download pending" message

Steps Followed:
(1) Go offline
(2)open any url
(3)download when online
(4)go into downloads
(5)pause download
(6)resume download

Chrome versions tested:
66.0.3348.3

OS:
Android 7.0.0, 6.0.1

Android Devices
Samsung S7 and J7

@alexus: Could you please check in latest Canary and update?
Thanks!!

Comment 5 Deleted

Project Member

Comment 6 by sheriffbot@chromium.org, Feb 16 2018

Cc: sandeepkumars@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "sandeepkumars@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-Feedback
Re-adding Needs-Feedback as #5 was deleted.

marcin@ could you check in the latest canary?  What version are you using?  It looks like our testers couldn't reproduce.  This was Android N?

Comment 8 by mar...@mwiacek.com, Feb 22 2018

Right now I have just checked this issue on 66.0.3350.12 on Pixel / Android 8.1 and I see it. I also confirm, that bug was initially seen on N (I’ve added “7” in the #0)
Project Member

Comment 9 by sheriffbot@chromium.org, Feb 22 2018

Cc: dtrainor@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: petewil@chromium.org
Components: UI>Browser>Offline
Owner: chili@chromium.org
Could either be in the notification layer or the offline backend.
Status: Assigned (was: Unconfirmed)

Comment 12 by chili@chromium.org, Mar 19 2018

Mergedinto: 817702
Status: Duplicate (was: Assigned)

Comment 13 by chili@chromium.org, Mar 19 2018

Owner: cmsy@google.com
Status: Assigned (was: Duplicate)
Oops. This might be a separate issue. Assigning to candice to take a look
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f99ee9c26a53a1705159b70744667239610b28d

commit 0f99ee9c26a53a1705159b70744667239610b28d
Author: Candice Sy <cmsy@google.com>
Date: Tue Mar 20 19:28:26 2018

Check if download is pending before attempting to pause

Reorders checks in DownloadNotificationService.notifyDownloadPaused().
Check if the download needs to be updated to pending before
attempting to pause the download. This ensures notifyDownloadPending()
will be called if necessary.

Bug: 812576
Change-Id: I3d34f8ffd18e73053abc1c1c3e00fe46242840fd
Reviewed-on: https://chromium-review.googlesource.com/969925
Reviewed-by: Joy Ming <jming@chromium.org>
Commit-Queue: Candice Sy <cmsy@google.com>
Cr-Commit-Position: refs/heads/master@{#544483}
[modify] https://crrev.com/0f99ee9c26a53a1705159b70744667239610b28d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/0f99ee9c26a53a1705159b70744667239610b28d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService2.java

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/837dc664cbbf86a9248212a02f45f25b26d080e2

commit 837dc664cbbf86a9248212a02f45f25b26d080e2
Author: Candice Sy <cmsy@google.com>
Date: Fri Mar 23 22:28:52 2018

Undo check of download pending before attempting to pause

Undoing the reordering from
https://chromium-review.googlesource.com/969925 because this change
created bugs related to starting/stopping the foreground service.

Correct usage of notifyDownloadPaused() with isAutoResumable true
and of notifyDownloadInterrupted() is to mark downloads as pending if
they are not already paused.

Bug: 812576,825113,825163
Change-Id: I6c33e035ec501c418c93acff916b7852f2b66cbd
Reviewed-on: https://chromium-review.googlesource.com/978612
Reviewed-by: Joy Ming <jming@chromium.org>
Commit-Queue: Candice Sy <cmsy@google.com>
Cr-Commit-Position: refs/heads/master@{#545595}
[modify] https://crrev.com/837dc664cbbf86a9248212a02f45f25b26d080e2/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/837dc664cbbf86a9248212a02f45f25b26d080e2/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService2.java

Comment 16 by cmsy@google.com, Apr 9 2018

Owner: chili@chromium.org

Comment 17 by chili@chromium.org, Apr 11 2018

Mergedinto: -817702 831083
Status: Duplicate (was: Assigned)

Comment 18 by jming@chromium.org, Apr 12 2018

Owner: jming@chromium.org
Status: Assigned (was: Duplicate)

Sign in to add a comment