Issue metadata
Sign in to add a comment
|
No change for system notification from "Download paused" to "Download pending" |
||||||||||||||||||||
Issue descriptionDevice name:s7 From "Settings > About Chrome" Application version:66.0.3347.3 Operating system:7 Steps to reproduce: (1)go offline (2)open any url (3)download when online (4)go into downloads (5)pause download (6)resume download Expected result: Android notification is changing from "Download paused" to "Download pending" Actual result: Android notification shows "Download paused"
,
Feb 15 2018
,
Feb 16 2018
,
Feb 16 2018
Tested the issue in Android and couldn't reproduce the issue. Observed the "Download pending" message Steps Followed: (1) Go offline (2)open any url (3)download when online (4)go into downloads (5)pause download (6)resume download Chrome versions tested: 66.0.3348.3 OS: Android 7.0.0, 6.0.1 Android Devices Samsung S7 and J7 @alexus: Could you please check in latest Canary and update? Thanks!!
,
Feb 16 2018
Thank you for providing more feedback. Adding requester "sandeepkumars@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 22 2018
Re-adding Needs-Feedback as #5 was deleted. marcin@ could you check in the latest canary? What version are you using? It looks like our testers couldn't reproduce. This was Android N?
,
Feb 22 2018
Right now I have just checked this issue on 66.0.3350.12 on Pixel / Android 8.1 and I see it. I also confirm, that bug was initially seen on N (I’ve added “7” in the #0)
,
Feb 22 2018
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 15 2018
Could either be in the notification layer or the offline backend.
,
Mar 15 2018
,
Mar 19 2018
,
Mar 19 2018
Oops. This might be a separate issue. Assigning to candice to take a look
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f99ee9c26a53a1705159b70744667239610b28d commit 0f99ee9c26a53a1705159b70744667239610b28d Author: Candice Sy <cmsy@google.com> Date: Tue Mar 20 19:28:26 2018 Check if download is pending before attempting to pause Reorders checks in DownloadNotificationService.notifyDownloadPaused(). Check if the download needs to be updated to pending before attempting to pause the download. This ensures notifyDownloadPending() will be called if necessary. Bug: 812576 Change-Id: I3d34f8ffd18e73053abc1c1c3e00fe46242840fd Reviewed-on: https://chromium-review.googlesource.com/969925 Reviewed-by: Joy Ming <jming@chromium.org> Commit-Queue: Candice Sy <cmsy@google.com> Cr-Commit-Position: refs/heads/master@{#544483} [modify] https://crrev.com/0f99ee9c26a53a1705159b70744667239610b28d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/0f99ee9c26a53a1705159b70744667239610b28d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService2.java
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/837dc664cbbf86a9248212a02f45f25b26d080e2 commit 837dc664cbbf86a9248212a02f45f25b26d080e2 Author: Candice Sy <cmsy@google.com> Date: Fri Mar 23 22:28:52 2018 Undo check of download pending before attempting to pause Undoing the reordering from https://chromium-review.googlesource.com/969925 because this change created bugs related to starting/stopping the foreground service. Correct usage of notifyDownloadPaused() with isAutoResumable true and of notifyDownloadInterrupted() is to mark downloads as pending if they are not already paused. Bug: 812576,825113,825163 Change-Id: I6c33e035ec501c418c93acff916b7852f2b66cbd Reviewed-on: https://chromium-review.googlesource.com/978612 Reviewed-by: Joy Ming <jming@chromium.org> Commit-Queue: Candice Sy <cmsy@google.com> Cr-Commit-Position: refs/heads/master@{#545595} [modify] https://crrev.com/837dc664cbbf86a9248212a02f45f25b26d080e2/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/837dc664cbbf86a9248212a02f45f25b26d080e2/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService2.java
,
Apr 9 2018
,
Apr 12 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by dtrainor@chromium.org
, Feb 15 2018Owner: dim...@chromium.org