New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812568 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 792441



Sign in to add a comment

Add mojo interface for audio logging

Project Member Reported by guidou@chromium.org, Feb 15 2018

Issue description

Classes from the audio service use audio logging.
Actual audio logging is implemented by the browser, so it cannot be moved to the audio service.
A mojo interface for audio logging is required so that the audio service can continue writing audio logs to the browser.
 

Comment 1 by guidou@chromium.org, Feb 15 2018

Summary: Add mojo interface for audio logging (was: Use mojo for audio logging)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35a86980b095581e025dde6fedfc4a1dc6b527f6

commit 35a86980b095581e025dde6fedfc4a1dc6b527f6
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue Feb 20 13:34:38 2018

Port audio logging to Mojo

This CL introduces a mojo interface for audio logging and makes the
following classes from the audio service use it:
- AudioInputDelegateImpl
- AudioOutputDelegateImpl
- AudioOutputDispatcherImpl

Due to layering restrictions, AudioOutputDispatcherImpl cannot access
mojo interfaces directly. To work around this limitation, this CL also
introduces the MojoAudioLogAdapter class, which wraps mojo audio logs
in the existing media::AudioLog interface.

Bug:  812568 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I13a90ed12ddcd33944dffa8dda83df276905af68
Reviewed-on: https://chromium-review.googlesource.com/921282
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537767}
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/BUILD.gn
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/media/media_internals.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/media/media_internals.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/media/media_internals_unittest.cc
[add] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/media/mojo_audio_logging_adapter.cc
[add] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/media/mojo_audio_logging_adapter.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/audio_input_delegate_impl.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/audio_input_delegate_impl.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/audio_input_delegate_impl_unittest.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/audio_input_renderer_host.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/audio_input_renderer_host.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/audio_output_delegate_impl.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/audio_output_delegate_impl.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/audio_renderer_host.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/audio_renderer_host.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/render_frame_audio_input_stream_factory.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/render_frame_audio_input_stream_factory.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/render_frame_audio_input_stream_factory_unittest.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/speech/speech_recognizer_impl.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/content/browser/speech/speech_recognizer_impl.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/media/audio/audio_logging.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/media/audio/audio_manager.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/media/audio/audio_manager_base.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/media/audio/audio_manager_base.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/media/audio/audio_output_dispatcher_impl.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/media/audio/audio_output_dispatcher_impl.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/media/audio/fake_audio_log_factory.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/media/audio/fake_audio_log_factory.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/media/audio/mock_audio_manager.cc
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/media/audio/mock_audio_manager.h
[modify] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/media/mojo/interfaces/BUILD.gn
[add] https://crrev.com/35a86980b095581e025dde6fedfc4a1dc6b527f6/media/mojo/interfaces/audio_logging.mojom

Comment 3 by guidou@chromium.org, Feb 20 2018

Status: Fixed (was: Started)

Comment 4 by olka@chromium.org, Feb 20 2018

\o/

Sign in to add a comment