New issue
Advanced search Search tips

Issue 812558 link

Starred by 1 user
Status: Fixed
Owner:
hta@chromium.org
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WebRTC RTCDTMFSender should be exposed in IDL

Project Member Reported by hta@chromium.org, Feb 15 2018 
The RTCDTMFSender object is not marked as [ NoInterfaceObject ] in the
specification.

https://w3c.github.io/webrtc-pc/#dom-rtcdtmfsender

This makes Web Platform Test not get to the interesting tests:

https://github.com/w3c/web-platform-tests/blob/master/webrtc/RTCDTMFSender-insertDTMF.https.html and friends.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7e3a7693e9f76ecedf3c78e9484463259d7f4b8

commit b7e3a7693e9f76ecedf3c78e9484463259d7f4b8
Author: Harald Alvestrand <hta@chromium.org>
Date: Thu Feb 15 15:30:27 2018

Expose IDL object RTCDTMFSender

This had been marked as [ NoInterfaceObject ] in IDL, but is
not so marked in the spec. This made some WPT tests fail.

Bug:  812558 
Change-Id: Ibf2aaf8d5df5b82f61934fd1dd7a051ea773e933
Reviewed-on: https://chromium-review.googlesource.com/921223
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537020}
[modify] https://crrev.com/b7e3a7693e9f76ecedf3c78e9484463259d7f4b8/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/b7e3a7693e9f76ecedf3c78e9484463259d7f4b8/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDTMFSender-insertDTMF.https-expected.txt
[modify] https://crrev.com/b7e3a7693e9f76ecedf3c78e9484463259d7f4b8/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDTMFSender-ontonechange-long.https-expected.txt
[modify] https://crrev.com/b7e3a7693e9f76ecedf3c78e9484463259d7f4b8/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDTMFSender-ontonechange.https-expected.txt
[modify] https://crrev.com/b7e3a7693e9f76ecedf3c78e9484463259d7f4b8/third_party/WebKit/LayoutTests/external/wpt/webrtc/interfaces.https-expected.txt
[modify] https://crrev.com/b7e3a7693e9f76ecedf3c78e9484463259d7f4b8/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/b7e3a7693e9f76ecedf3c78e9484463259d7f4b8/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/b7e3a7693e9f76ecedf3c78e9484463259d7f4b8/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.idl

Comment 2 by hta@chromium.org, Feb 19 2018

Status: Fixed (was: Started)
►

Sign in to add a comment