Apparently Article Sync (i.e. the syncer::ARTICLES data type) was never launched. If there aren't any concrete plans to launch it, then there's a bunch of code in components/dom_distiller/ and in components/sync/ that should be deleted.
I enjoy deleting code. Taking this one :)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4767e8db1f58028c41d9bf8b548fa9fddcd4a657 commit 4767e8db1f58028c41d9bf8b548fa9fddcd4a657 Author: Tanja Gornak <melandory@chromium.org> Date: Mon Jul 23 10:48:04 2018 Clean up never-launched Article Sync code. Bug: 812553 NOPRESUBMIT=true Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8522ebbc147afd0d39b85cda1545ef526d037e44 Reviewed-on: https://chromium-review.googlesource.com/1128890 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577140} [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/chrome/browser/dom_distiller/lazy_dom_distiller_service.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/chrome/browser/dom_distiller/lazy_dom_distiller_service.h [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/chrome/browser/sync/chrome_sync_client.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/browser_sync/profile_sync_components_factory_impl.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/dom_distiller/core/dom_distiller_features.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/dom_distiller/core/dom_distiller_service.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/dom_distiller/core/dom_distiller_service.h [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/dom_distiller/core/dom_distiller_store.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/dom_distiller/core/dom_distiller_store.h [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/dom_distiller/core/dom_distiller_store_unittest.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/dom_distiller/core/dom_distiller_switches.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/dom_distiller/core/dom_distiller_switches.h [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/dom_distiller/core/viewer_unittest.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/sync/base/data_type_histogram.h [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/sync/base/model_type.h [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/sync/base/sync_prefs.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/sync/driver/model_association_manager.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/sync/engine_impl/directory_commit_contribution_unittest.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/sync/engine_impl/directory_update_handler_unittest.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/sync/engine_impl/sync_manager_impl_unittest.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/sync/syncable/model_type.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/components/sync/syncable/nigori_util.cc [modify] https://crrev.com/4767e8db1f58028c41d9bf8b548fa9fddcd4a657/ios/chrome/browser/sync/ios_chrome_sync_client.mm
Comment 1 by mastiz@chromium.org
, Jul 3Labels: -Pri-3 sync-fixit-2018q3 Pri-2