New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812536 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Chopped ubertray is seen while flipping the device between tablet mode and normal mode

Project Member Reported by rkalavakuntla@chromium.org, Feb 15 2018

Issue description

Chrome Version:66.0.3344.0/10405.0.0 dev channel Minnie
OS:chrome OS

What steps will reproduce the problem?
(1)Sign into user >> Flip the device to tablet mode >>Open Ubertray
(2)Now flip the device to normal mode and observe the ubertray(Kindly refer video)

Actual: Chopped ubertray is seen while flipping the device from tablet mode to normal mode
Expected: No such chopped ubertray should be seen

This is a Regression issue as same is working fine in 63.0.3239.140/10032.86.0 stable channel Minnie

Note: Issue is not seen in Linux,Windows OS  

@tbuckley : Please confirm the issue.
 
Actual.jpg
2.6 MB View Download
Expected.jpg
2.8 MB View Download
Actual.mp4
8.6 MB View Download
Expected.mp4
7.6 MB View Download
Cc: tbuck...@chromium.org
Owner: zork@chromium.org
Looks like this is caused by maintaining the menu position relative to the status area button despite removing the overview mode button.

Comment 2 by zork@chromium.org, Apr 27 2018

Owner: minch@chromium.org
Min, could you take a look at this?

Comment 3 by minch@chromium.org, May 1 2018

Cc: kochi@chromium.org
I tried to bisect this issue and it was introduced at M65.
Even though I am not sure whether it is related, but the culprit cl through bisecting is https://chromium-review.googlesource.com/c/chromium/src/+/799611

added the owner kochi@, do you have any idea why this happened? thanks.


Comment 4 by minch@chromium.org, May 3 2018

Cc: tetsui@chromium.org
Status: Started (was: Assigned)

Comment 5 by minch@chromium.org, May 3 2018

Owner: tetsui@chromium.org
Status: Assigned (was: Started)
found this is introduced by https://chromium-review.googlesource.com/c/chromium/src/+/844053

assigned to the owner.
tetsui@, can you help take a look? thanks.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 23 2018

Owner: sammiequon@chromium.org
Status: Fixed (was: Assigned)
This is fixed in the new tray. I will mark as fixed, but please reopen if we want this fixed on the old tray as well.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad7e5862b1d5407553fae466de086f3d4b62241e

commit ad7e5862b1d5407553fae466de086f3d4b62241e
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Thu Sep 27 08:16:42 2018

Unified: Anchor system tray bubble to the shelf rect.

The design spec states tray bubble should be anchored to:
- right-bottom (when the shelf is positioned to the bottom or right)
- or left-bottom (when the shelf is positioned to the left)
corner of the workspace.

The bubble went to wrong positions when changing the device mode
between tablet and laptop, or rotating the screen, while the system
tray bubble is opened. This change is a fix for it.


Bug:  864939 ,  812536 
Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a
Reviewed-on: https://chromium-review.googlesource.com/1246082
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594630}
[modify] https://crrev.com/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/shelf/shelf.cc
[modify] https://crrev.com/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/shelf/shelf.h
[modify] https://crrev.com/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/system/tray/tray_bubble_view.cc
[modify] https://crrev.com/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/system/tray/tray_bubble_view.h
[modify] https://crrev.com/ad7e5862b1d5407553fae466de086f3d4b62241e/ash/system/unified/unified_system_tray_bubble.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 1

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e75c935f5b8442eebc9e1d0755907f2927b693d3

commit e75c935f5b8442eebc9e1d0755907f2927b693d3
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Mon Oct 01 06:29:51 2018

Unified: Anchor system tray bubble to the shelf rect.

The design spec states tray bubble should be anchored to:
- right-bottom (when the shelf is positioned to the bottom or right)
- or left-bottom (when the shelf is positioned to the left)
corner of the workspace.

The bubble went to wrong positions when changing the device mode
between tablet and laptop, or rotating the screen, while the system
tray bubble is opened. This change is a fix for it.

This patch was manually edited from the original.
- target tray_bubble_view.{cc,h} had been moved across directories
- set_arrow() had been renamed to SetArrow()

(cherry picked from commit ad7e5862b1d5407553fae466de086f3d4b62241e)

Bug:  864939 ,  812536 
Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a
Reviewed-on: https://chromium-review.googlesource.com/1246082
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#594630}
Reviewed-on: https://chromium-review.googlesource.com/1250307
Cr-Commit-Position: refs/branch-heads/3538@{#764}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/e75c935f5b8442eebc9e1d0755907f2927b693d3/ash/shelf/shelf.cc
[modify] https://crrev.com/e75c935f5b8442eebc9e1d0755907f2927b693d3/ash/shelf/shelf.h
[modify] https://crrev.com/e75c935f5b8442eebc9e1d0755907f2927b693d3/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/e75c935f5b8442eebc9e1d0755907f2927b693d3/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/e75c935f5b8442eebc9e1d0755907f2927b693d3/ash/system/unified/unified_system_tray_bubble.cc
[modify] https://crrev.com/e75c935f5b8442eebc9e1d0755907f2927b693d3/ui/views/bubble/tray_bubble_view.cc
[modify] https://crrev.com/e75c935f5b8442eebc9e1d0755907f2927b693d3/ui/views/bubble/tray_bubble_view.h

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2c2ba253f97ae465d6047e70f2c00ab3811755a

commit e2c2ba253f97ae465d6047e70f2c00ab3811755a
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Tue Oct 09 03:02:47 2018

Revert "Unified: Anchor system tray bubble to the shelf rect."

This reverts commit e75c935f5b8442eebc9e1d0755907f2927b693d3.

Reason for revert:  P0 regression https://crbug.com/892248

Original change's description:
> Unified: Anchor system tray bubble to the shelf rect.
> 
> The design spec states tray bubble should be anchored to:
> - right-bottom (when the shelf is positioned to the bottom or right)
> - or left-bottom (when the shelf is positioned to the left)
> corner of the workspace.
> 
> The bubble went to wrong positions when changing the device mode
> between tablet and laptop, or rotating the screen, while the system
> tray bubble is opened. This change is a fix for it.
> 
> This patch was manually edited from the original.
> - target tray_bubble_view.{cc,h} had been moved across directories
> - set_arrow() had been renamed to SetArrow()
> 
> (cherry picked from commit ad7e5862b1d5407553fae466de086f3d4b62241e)
> 
> Bug:  864939 ,  812536 
> Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a
> Reviewed-on: https://chromium-review.googlesource.com/1246082
> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#594630}
> Reviewed-on: https://chromium-review.googlesource.com/1250307
> Cr-Commit-Position: refs/branch-heads/3538@{#764}
> Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}

TBR=yoshiki@chromium.org,yamaguchi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  864939 ,  812536 , 892248
Change-Id: I73c6216c26b14eb6cd7c47fcbe08dc0190c92164
Reviewed-on: https://chromium-review.googlesource.com/c/1270205
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#913}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/e2c2ba253f97ae465d6047e70f2c00ab3811755a/ash/shelf/shelf.cc
[modify] https://crrev.com/e2c2ba253f97ae465d6047e70f2c00ab3811755a/ash/shelf/shelf.h
[modify] https://crrev.com/e2c2ba253f97ae465d6047e70f2c00ab3811755a/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/e2c2ba253f97ae465d6047e70f2c00ab3811755a/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/e2c2ba253f97ae465d6047e70f2c00ab3811755a/ash/system/unified/unified_system_tray_bubble.cc
[modify] https://crrev.com/e2c2ba253f97ae465d6047e70f2c00ab3811755a/ui/views/bubble/tray_bubble_view.cc
[modify] https://crrev.com/e2c2ba253f97ae465d6047e70f2c00ab3811755a/ui/views/bubble/tray_bubble_view.h

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d08b807021b513d9a9e762bea5d3e5c6394450aa

commit d08b807021b513d9a9e762bea5d3e5c6394450aa
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Tue Oct 09 03:34:01 2018

Revert "Unified: Anchor system tray bubble to the shelf rect."

This reverts commit ad7e5862b1d5407553fae466de086f3d4b62241e.

Reason for revert: P0 regression https://crbug.com/892248

Original change's description:
> Unified: Anchor system tray bubble to the shelf rect.
> 
> The design spec states tray bubble should be anchored to:
> - right-bottom (when the shelf is positioned to the bottom or right)
> - or left-bottom (when the shelf is positioned to the left)
> corner of the workspace.
> 
> The bubble went to wrong positions when changing the device mode
> between tablet and laptop, or rotating the screen, while the system
> tray bubble is opened. This change is a fix for it.
> 
> 
> Bug:  864939 ,  812536 
> Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a
> Reviewed-on: https://chromium-review.googlesource.com/1246082
> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594630}

TBR=xiyuan@chromium.org,yoshiki@chromium.org,yamaguchi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  864939 ,  812536 , 892248
Change-Id: Ia6b034a6bb8f2d583924e217ee7215f32800d1ba
Reviewed-on: https://chromium-review.googlesource.com/c/1270397
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597790}
[modify] https://crrev.com/d08b807021b513d9a9e762bea5d3e5c6394450aa/ash/shelf/shelf.cc
[modify] https://crrev.com/d08b807021b513d9a9e762bea5d3e5c6394450aa/ash/shelf/shelf.h
[modify] https://crrev.com/d08b807021b513d9a9e762bea5d3e5c6394450aa/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/d08b807021b513d9a9e762bea5d3e5c6394450aa/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/d08b807021b513d9a9e762bea5d3e5c6394450aa/ash/system/tray/tray_bubble_view.cc
[modify] https://crrev.com/d08b807021b513d9a9e762bea5d3e5c6394450aa/ash/system/tray/tray_bubble_view.h
[modify] https://crrev.com/d08b807021b513d9a9e762bea5d3e5c6394450aa/ash/system/unified/unified_system_tray_bubble.cc

Status: Started (was: Fixed)
Summary: Regression: Chopped ubertray is seen while flipping the device between tablet mode and normal mode (was: Regression: Chopped ubertray is seen while flipping the device from tablet mode to normal mode)
Modifying Issue description to cover the inverse transition, as those are essentially the same problem and tested altogether.
Cc: kejiashao@chromium.org yamaguchi@chromium.org
 Issue 891439  has been merged into this issue.
Cc: -yamaguchi@chromium.org sammiequon@chromium.org
Owner: yamaguchi@chromium.org
Cc: abod...@chromium.org dhadd...@chromium.org sdantul...@chromium.org yamaguchi@chromium.org
 Issue 892746  has been merged into this issue.
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66c51516344cbeb9b21e1648c76783b73b517b1d

commit 66c51516344cbeb9b21e1648c76783b73b517b1d
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Thu Oct 25 01:50:17 2018

Unified: Anchor system tray bubble to user workspace rect.

The design spec states tray bubble should be anchored to:
- right-bottom (when the shelf is positioned to the bottom or right)
- or left-bottom (when the shelf is positioned to the left)
  corner of the workspace.
The bubble went to wrong positions when changing the device mode
between tablet and laptop, or rotating the screen, while the system
tray bubble is opened. This change is a fix for it.


This is mostly a reland of ad7e5862b1d5407553fae466de086f3d4b62241e
"Unified: Anchor system tray bubble to the shelf rect."
with some fixes.

Original change's description:
> Unified: Anchor system tray bubble to the shelf rect.
>
> The design spec states tray bubble should be anchored to:
> - right-bottom (when the shelf is positioned to the bottom or right)
> - or left-bottom (when the shelf is positioned to the left)
> corner of the workspace.
>
> The bubble went to wrong positions when changing the device mode
> between tablet and laptop, or rotating the screen, while the system
> tray bubble is opened. This change is a fix for it.
>
>
> Bug:  864939 ,  812536 
> Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a
> Reviewed-on: https://chromium-review.googlesource.com/1246082
> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594630}

Bug:  864939 ,  812536 , 887965
Change-Id: I86ee51f3c610064acd040cde3095f1921a941d9c
Reviewed-on: https://chromium-review.googlesource.com/c/1282522
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602571}
[modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/shelf/shelf.cc
[modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/shelf/shelf.h
[modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/system/message_center/notification_tray.cc
[modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/system/tray/system_tray.cc
[modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/system/tray/tray_bubble_view.cc
[modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/system/tray/tray_bubble_view.h
[modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/system/unified/unified_slider_bubble_controller.cc
[modify] https://crrev.com/66c51516344cbeb9b21e1648c76783b73b517b1d/ash/system/unified/unified_system_tray_bubble.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Oct 31

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd

commit 3bfa9f8a83f849400494ad47d6e99808cf5c7fcd
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Wed Oct 31 01:17:02 2018

Unified: Anchor system tray bubble to user workspace rect.

The design spec states tray bubble should be anchored to:
- right-bottom (when the shelf is positioned to the bottom or right)
- or left-bottom (when the shelf is positioned to the left)
  corner of the workspace.
The bubble went to wrong positions when changing the device mode
between tablet and laptop, or rotating the screen, while the system
tray bubble is opened. This change is a fix for it.


This is mostly a reland of ad7e5862b1d5407553fae466de086f3d4b62241e
"Unified: Anchor system tray bubble to the shelf rect."
with some fixes.

Original change's description:
> Unified: Anchor system tray bubble to the shelf rect.
>
> The design spec states tray bubble should be anchored to:
> - right-bottom (when the shelf is positioned to the bottom or right)
> - or left-bottom (when the shelf is positioned to the left)
> corner of the workspace.
>
> The bubble went to wrong positions when changing the device mode
> between tablet and laptop, or rotating the screen, while the system
> tray bubble is opened. This change is a fix for it.
>
>
> Bug:  864939 ,  812536 
> Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a
> Reviewed-on: https://chromium-review.googlesource.com/1246082
> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594630}

Bug:  864939 ,  812536 , 887965
Change-Id: I86ee51f3c610064acd040cde3095f1921a941d9c
Reviewed-on: https://chromium-review.googlesource.com/c/1282522
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602571}(cherry picked from commit 66c51516344cbeb9b21e1648c76783b73b517b1d)
Reviewed-on: https://chromium-review.googlesource.com/c/1308236
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#429}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/shelf/shelf.cc
[modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/shelf/shelf.h
[modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/system/message_center/notification_tray.cc
[modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/system/tray/system_tray.cc
[modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/system/tray/tray_bubble_view.cc
[modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/system/tray/tray_bubble_view.h
[modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/system/unified/unified_slider_bubble_controller.cc
[modify] https://crrev.com/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd/ash/system/unified/unified_system_tray_bubble.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/3bfa9f8a83f849400494ad47d6e99808cf5c7fcd

Commit: 3bfa9f8a83f849400494ad47d6e99808cf5c7fcd
Author: yamaguchi@chromium.org
Commiter: yamaguchi@chromium.org
Date: 2018-10-31 01:17:02 +0000 UTC

Unified: Anchor system tray bubble to user workspace rect.

The design spec states tray bubble should be anchored to:
- right-bottom (when the shelf is positioned to the bottom or right)
- or left-bottom (when the shelf is positioned to the left)
  corner of the workspace.
The bubble went to wrong positions when changing the device mode
between tablet and laptop, or rotating the screen, while the system
tray bubble is opened. This change is a fix for it.


This is mostly a reland of ad7e5862b1d5407553fae466de086f3d4b62241e
"Unified: Anchor system tray bubble to the shelf rect."
with some fixes.

Original change's description:
> Unified: Anchor system tray bubble to the shelf rect.
>
> The design spec states tray bubble should be anchored to:
> - right-bottom (when the shelf is positioned to the bottom or right)
> - or left-bottom (when the shelf is positioned to the left)
> corner of the workspace.
>
> The bubble went to wrong positions when changing the device mode
> between tablet and laptop, or rotating the screen, while the system
> tray bubble is opened. This change is a fix for it.
>
>
> Bug:  864939 ,  812536 
> Change-Id: I1392a2d96c72e06c4e8e159f22901720da72747a
> Reviewed-on: https://chromium-review.googlesource.com/1246082
> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594630}

Bug:  864939 ,  812536 , 887965
Change-Id: I86ee51f3c610064acd040cde3095f1921a941d9c
Reviewed-on: https://chromium-review.googlesource.com/c/1282522
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602571}(cherry picked from commit 66c51516344cbeb9b21e1648c76783b73b517b1d)
Reviewed-on: https://chromium-review.googlesource.com/c/1308236
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#429}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Fixed (was: Started)
The fix I1392a2d96 has been merged to M71 and is available from 71.0.3578.33.

Sign in to add a comment