Setup Blink bot for enable_blink_heap_incremental_marking |
||||||||||
Issue descriptionI am working on Oilpan incremental marking. And we would like to have a blink dbg bot for the build flag "enable_blink_heap_incremental_marking". (similar to how we used to have the Oilpan bot) Our team plans to just use it for development of the feature so it probably only needs to be an fyi bot. Will the infra team set it up for me? I think I just need linux_trusty_blink_dbg with enable_blink_heap_incremental_marking enabled.
,
Feb 15 2018
+machenbach: AFAIK, we used to host the wrapper tracing bot for blink. This one should probably be hosted on the blink side though.
,
Feb 15 2018
It's not clear from the description whether you're asking for a trybot, a CI bot, or both ("fyi bot" implies CI, mirroring linux_trusty_blink_dbg implies try).
Mind clarifying?
,
Feb 15 2018
We had a bot setting wrapper-tracing on chromium.fyi - and later migrated it to client.v8.chromium before retiring it. So it was hosted on the chromium side (in the sense that the waterfalls pull and blame chromium revisions). But V8 owned it.
,
Feb 16 2018
I think we need the fyi bot, but would also like to have a try bot if possible.
,
Feb 19 2018
,
Feb 20 2018
,
Feb 23 2018
,
Feb 23 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/bec96fea99a1f383c52145cc634d7a81b0bbd0c7 commit bec96fea99a1f383c52145cc634d7a81b0bbd0c7 Author: John Budorick <jbudorick@google.com> Date: Fri Feb 23 19:19:26 2018
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8152f78e8125f2cd848955668d190203cfb96ca7 commit 8152f78e8125f2cd848955668d190203cfb96ca7 Author: John Budorick <jbudorick@chromium.org> Date: Fri Feb 23 19:39:24 2018 Add buildbucket entry for new Blink Heap Incremental Marking bot. Bug: 812533 Change-Id: I2043857e005e3587b573c4969e6099108c30fbec Reviewed-on: https://chromium-review.googlesource.com/934316 Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/8152f78e8125f2cd848955668d190203cfb96ca7/cr-buildbucket.cfg
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebe81fb2176162e2dedb40b35c8436bdd374a2aa commit ebe81fb2176162e2dedb40b35c8436bdd374a2aa Author: John Budorick <jbudorick@chromium.org> Date: Fri Feb 23 21:41:01 2018 Add build and test configuration for new Blink Heap Incremental Marking bot. Bug: 812533 Change-Id: I117efbfa67d65995b21530a0aa5532fa60b42cf5 Reviewed-on: https://chromium-review.googlesource.com/934622 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#538907} [modify] https://crrev.com/ebe81fb2176162e2dedb40b35c8436bdd374a2aa/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/ebe81fb2176162e2dedb40b35c8436bdd374a2aa/testing/buildbot/waterfalls.pyl [modify] https://crrev.com/ebe81fb2176162e2dedb40b35c8436bdd374a2aa/tools/mb/mb_config.pyl
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/487eb1001d105d9d150344fbf3640b4326309cc0 commit 487eb1001d105d9d150344fbf3640b4326309cc0 Author: John Budorick <jbudorick@chromium.org> Date: Fri Feb 23 23:11:44 2018 Rename blink heap incremental markup bot. following bit.ly/chromium-build-naming TBR=martiniss@chromium.org Bug: 812533 Change-Id: Iefe9a2d53db0a2a096f01aed19a14e628c0be2c0 Reviewed-on: https://chromium-review.googlesource.com/935451 Reviewed-by: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/487eb1001d105d9d150344fbf3640b4326309cc0/cr-buildbucket.cfg
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33d4284a282431851bf6942040097ec607337971 commit 33d4284a282431851bf6942040097ec607337971 Author: John Budorick <jbudorick@chromium.org> Date: Fri Feb 23 23:21:07 2018 Add luci-scheduler entry for new Blink Heap Incremental Marking bot. Bug: 812533 Change-Id: I2d89e4c797ae96615e990572ccb2ccb8d8b931a1 Reviewed-on: https://chromium-review.googlesource.com/934318 Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/33d4284a282431851bf6942040097ec607337971/luci-scheduler.cfg
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b7bdc86601453cc5a4738a424c222719b18fee5 commit 0b7bdc86601453cc5a4738a424c222719b18fee5 Author: John Budorick <jbudorick@chromium.org> Date: Fri Feb 23 23:46:20 2018 Add milo entry for new Blink Heap Incremental Marking bot. Bug: 812533 Change-Id: I21a383eaf51fba7994bde0c3eba90d32e6ae60c4 Reviewed-on: https://chromium-review.googlesource.com/934320 Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/0b7bdc86601453cc5a4738a424c222719b18fee5/luci-milo-dev.cfg [modify] https://crrev.com/0b7bdc86601453cc5a4738a424c222719b18fee5/luci-milo.cfg
,
Feb 24 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/48c5a547c4b3c05645e3dadb27237c948c60128b commit 48c5a547c4b3c05645e3dadb27237c948c60128b Author: John Budorick <jbudorick@google.com> Date: Sat Feb 24 00:11:56 2018
,
Feb 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83e23cdb6a149ec2bbb5f5fb2039c80a419e7672 commit 83e23cdb6a149ec2bbb5f5fb2039c80a419e7672 Author: John Budorick <jbudorick@chromium.org> Date: Sat Feb 24 03:16:48 2018 Fix new linux-blink-heap-incremental-marking bot name. Now following bit.ly/chromium-build-naming TBR=martiniss@chromium.org Bug: 812533 Change-Id: I923f3cefe256bbfb427e76ef0552e44e468167dd Reviewed-on: https://chromium-review.googlesource.com/935661 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#538975} [modify] https://crrev.com/83e23cdb6a149ec2bbb5f5fb2039c80a419e7672/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/83e23cdb6a149ec2bbb5f5fb2039c80a419e7672/testing/buildbot/waterfalls.pyl [modify] https://crrev.com/83e23cdb6a149ec2bbb5f5fb2039c80a419e7672/tools/mb/mb_config.pyl
,
Feb 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/d57d8cf41440ab81c366e5398e6cbe378d234e8a commit d57d8cf41440ab81c366e5398e6cbe378d234e8a Author: John Budorick <jbudorick@chromium.org> Date: Mon Feb 26 18:53:19 2018 Recipe configuration for new blink heap incremental marking bot. TBR=martiniss@chromium.org Bug: 812533 Change-Id: I3e321e4c86140833eee46a60597f669955835d03 Reviewed-on: https://chromium-review.googlesource.com/935197 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/d57d8cf41440ab81c366e5398e6cbe378d234e8a/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/987b66487b16b7bd0b88d86c288ed19cdc41dbcd commit 987b66487b16b7bd0b88d86c288ed19cdc41dbcd Author: John Budorick <jbudorick@chromium.org> Date: Tue Feb 27 15:51:36 2018 Trigger new linux-blink-incremental-heap-marking bot on changes to master. TBR=martiniss@chromium.org Bug: 812533 Change-Id: I575e5215b9fdeed07ff90949e7c637fed5de08b9 Reviewed-on: https://chromium-review.googlesource.com/937981 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#539435} [modify] https://crrev.com/987b66487b16b7bd0b88d86c288ed19cdc41dbcd/infra/config/global/luci-scheduler.cfg
,
Feb 27 2018
,
Mar 1 2018
,
Mar 1 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/e8ace196d2383ebb942a558ae142c8f8af8ddaaf commit e8ace196d2383ebb942a558ae142c8f8af8ddaaf Author: John Budorick <jbudorick@google.com> Date: Thu Mar 01 13:54:58 2018
,
Mar 1 2018
Bot is set up at https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-blink-heap-incremental-marking Currently failing the layout tests because it thinks it should use a release build. https://chromium-review.googlesource.com/c/chromium/src/+/943597 on review for that.
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a14c2c3923552cfeadfcfcf9f11b3ed25c802ece commit a14c2c3923552cfeadfcfcf9f11b3ed25c802ece Author: John Budorick <jbudorick@chromium.org> Date: Fri Mar 02 19:00:44 2018 Run layout tests w/ --debug on linux-blink-heap-incremental-marking. Bug: 812533 Change-Id: I4a4d804bdeee453096b191716273e0aaf0ff5de8 Reviewed-on: https://chromium-review.googlesource.com/943597 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#540574} [modify] https://crrev.com/a14c2c3923552cfeadfcfcf9f11b3ed25c802ece/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/a14c2c3923552cfeadfcfcf9f11b3ed25c802ece/testing/buildbot/test_suite_exceptions.pyl
,
Mar 5 2018
Just realized that #0 was not complete wrt. to what needs to be switched on to actually test the proper configuration.. 1. Buildtime flag (done; seems to work great!) 2. Runtime flag HeapIncrementalMarking [1]. Sorry for missing out on that. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/runtime_enabled_features.json5?q=runtime_enabled_features.json5&dr&l=500
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a73769afa70618d87c1e621278f5c315a37e341a commit a73769afa70618d87c1e621278f5c315a37e341a Author: John Budorick <jbudorick@chromium.org> Date: Thu Mar 08 16:35:21 2018 Enable HeapIncrementalMarking flag on linux-blink-heap-incremental-marking. Change-Id: Ic8f7025c8800c7eed57b8df568f33d2ab8f79f2d Bug: 812533 Reviewed-on: https://chromium-review.googlesource.com/949866 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#541812} [modify] https://crrev.com/a73769afa70618d87c1e621278f5c315a37e341a/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/a73769afa70618d87c1e621278f5c315a37e341a/testing/buildbot/test_suite_exceptions.pyl
,
Apr 6 2018
Thanks so far! Is a trybot possible too? Also, in issue 817779 we added `chromium_gtests` to the bot. Would that be possible too?
,
Apr 20 2018
Ping. This is dragging on for 2 months now.
,
Apr 20 2018
sorry, forgot that y'all wanted the trybot & missed #26 in email.
,
Apr 20 2018
,
Apr 20 2018
as for adding tests: I can add it, but I'm also happy to review CLs affecting //testing/buildbot.
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/044db144b8728b309b637f95af85e61b42989af0 commit 044db144b8728b309b637f95af85e61b42989af0 Author: John Budorick <jbudorick@chromium.org> Date: Fri Apr 20 20:02:59 2018 Add recipe configs for linux-blink-heap-incremental-marking trybot. Bug: 812533 Change-Id: I01b79b7a46ad325773e6237549c34468dd2a42a6 Reviewed-on: https://chromium-review.googlesource.com/1022092 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> [modify] https://crrev.com/044db144b8728b309b637f95af85e61b42989af0/scripts/slave/README.recipes.md [modify] https://crrev.com/044db144b8728b309b637f95af85e61b42989af0/tests/masters_recipes_test.py [modify] https://crrev.com/044db144b8728b309b637f95af85e61b42989af0/scripts/slave/recipe_modules/chromium_tests/trybots.py
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77e48459282ce36539ea654e410d8c649a7b39d8 commit 77e48459282ce36539ea654e410d8c649a7b39d8 Author: John Budorick <jbudorick@chromium.org> Date: Fri Apr 20 20:46:12 2018 Add src-side configs for linux-blink-heap-incremental-marking trybot. Bug: 812533 Change-Id: Iabe6db303173d461c34c8bbb308986cb7c420325 Reviewed-on: https://chromium-review.googlesource.com/1022091 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#552463} [modify] https://crrev.com/77e48459282ce36539ea654e410d8c649a7b39d8/infra/config/global/cr-buildbucket.cfg [modify] https://crrev.com/77e48459282ce36539ea654e410d8c649a7b39d8/infra/config/global/luci-milo.cfg [modify] https://crrev.com/77e48459282ce36539ea654e410d8c649a7b39d8/tools/mb/mb_config.pyl
,
Apr 20 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/d55b05a4bbf192ed647d718ba6f4c9075fc4a1fc commit d55b05a4bbf192ed647d718ba6f4c9075fc4a1fc Author: John Budorick <jbudorick@google.com> Date: Fri Apr 20 21:29:32 2018
,
Apr 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cc4f5279aeec3eb4aef1e51548be69260acc64e commit 1cc4f5279aeec3eb4aef1e51548be69260acc64e Author: John Budorick <jbudorick@chromium.org> Date: Sat Apr 21 03:19:59 2018 Add chromium_gtests to linux-blink-heap-incremental-marking. TBR=mlippautz@chromium.org Bug: 812533 Change-Id: I5901bc1977cb2a83ce87616da5c1ede71484ab8e Reviewed-on: https://chromium-review.googlesource.com/1023271 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#552569} [modify] https://crrev.com/1cc4f5279aeec3eb4aef1e51548be69260acc64e/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/1cc4f5279aeec3eb4aef1e51548be69260acc64e/testing/buildbot/waterfalls.pyl
,
Apr 22 2018
,
Jul 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d4d0331a15e11f7d6ca819ca28521f24ca4647f commit 0d4d0331a15e11f7d6ca819ca28521f24ca4647f Author: Nico Weber <thakis@chromium.org> Date: Mon Jul 16 17:51:50 2018 Move unit_tests from chromium_gtests to chromium_gtests_for_devices_with_graphical_output. chromium_gtests_for_devices_with_graphical_output means "not cast". The cast build doesn't include anything at the //chrome level, and unit_tests lives at the //chrome level. Currently we have unit_tests in chromium_gtests which runs on all bots, and then an exception to remove it again on the cast bots. Instead, put it in chromium_gtests_for_devices_with_graphical_output so that it only runs on non-cast bots in the first place. (It also ends up removing unit_tests from linux-blink-heap-incremental-marking and linux-blink-heap-verification on the fyi waterfall, since these bots run chromium_gtests instead of chromium_linux_gtests -- that looks like a bot config bug, but it's only FYI bots anyways.) This removes the last "unclear why" comment from test_suite*.pyl! Bug: 843511, 817779 , 812533 Change-Id: I76e0a2b30e0ca87c02c73cb46d8135d9ab7030d8 Reviewed-on: https://chromium-review.googlesource.com/1138333 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#575339} [modify] https://crrev.com/0d4d0331a15e11f7d6ca819ca28521f24ca4647f/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/0d4d0331a15e11f7d6ca819ca28521f24ca4647f/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/0d4d0331a15e11f7d6ca819ca28521f24ca4647f/testing/buildbot/test_suites.pyl |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by keishi@chromium.org
, Feb 15 2018