New issue
Advanced search Search tips

Issue 812523 link

Starred by 3 users
Status: Available
Owner: ----
Cc:
maxmorin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Task



Sign in to add a comment

Deprecate and Remove base::Passed

Project Member Reported by maxmorin@chromium.org, Feb 15 2018 
Now that we have base::OnceCallback, we no longer need base::Passed(), since std::move does the same thing.

Easy work: remove current usage of Passed() with BindOnce().

Maybe not so easy work: Refactor old code using Passed() with BindRepeating() to use BindOnce() instead.

Comment 1 by claudiom...@gmail.com, Feb 15 2018 

Any other recommendations besides those ones?

Comment 2 by claudiom...@gmail.com, Feb 15 2018 

I'm about to submit a patch for this... I'm doing only the cases that are straight forward at first.

Comment 3 by claudiom...@gmail.com, Feb 16 2018 

I've submitted the first CL:

https://chromium-review.googlesource.com/c/chromium/src/+/923262

I'll carry on across the code base, depending on how this CL goes.

Comment 4 by maxmorin@chromium.org, Feb 16 2018 

I'm not planning any work here beyond landing https://chromium-review.googlesource.com/c/chromium/src/+/919066.

Comment 5 by claudiom...@gmail.com, Feb 16 2018 

I had chosen to do the refactoring in the other areas of the system. Do you think I should go ahead trying to refactor other parts of the system?
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b51cf51f611daa118e7fd2ba2a538bc8adf49e2c

commit b51cf51f611daa118e7fd2ba2a538bc8adf49e2c
Author: Max Morin <maxmorin@chromium.org>
Date: Mon Feb 19 12:49:49 2018

Discourage use of base::Passed().

See discussion thread: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/8PJU6CEyGwg

No-Try: true
Bug: 812523
Change-Id: Ie021ad6803dbbaf02a4caba37c6b8a50a006b251
Reviewed-on: https://chromium-review.googlesource.com/919066
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537637}
[modify] https://crrev.com/b51cf51f611daa118e7fd2ba2a538bc8adf49e2c/base/bind.h
[modify] https://crrev.com/b51cf51f611daa118e7fd2ba2a538bc8adf49e2c/docs/callback.md
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d2135b081286959d9ea3963eafe58fa92094581

commit 6d2135b081286959d9ea3963eafe58fa92094581
Author: tzik <tzik@chromium.org>
Date: Wed Feb 21 11:34:21 2018

Add a rewriter to remove unneeded base::Passed on base::OnceCallback

This CL adds a clang based rewriter as a sub-rewriter of base_bind_rewriter
that removes unneeded base::Passed usage on base::BindOnce parameter.
Example:
  // Before:
  base::BindOnce(&Foo, base::Passed(&ptr));
  base::BindOnce(&Foo, base::Passed(std::move(ptr)));
  base::BindOnce(&Foo, base::Passed(std::make_unique<int>()));

  // After:
  base::BindOnce(&Foo, std::move(ptr));
  base::BindOnce(&Foo, std::move(ptr));
  base::BindOnce(&Foo, std::make_unique<int>());

Bug: 812523
Change-Id: I81c391531f02d608cffbbbe2f12a1cff6a1201de
Reviewed-on: https://chromium-review.googlesource.com/923620
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538064}
[modify] https://crrev.com/6d2135b081286959d9ea3963eafe58fa92094581/tools/clang/base_bind_rewriters/BaseBindRewriters.cpp
[modify] https://crrev.com/6d2135b081286959d9ea3963eafe58fa92094581/tools/clang/base_bind_rewriters/tests/callback.h
[add] https://crrev.com/6d2135b081286959d9ea3963eafe58fa92094581/tools/clang/base_bind_rewriters/tests/passed-to-move-rewriter-expected.cc
[add] https://crrev.com/6d2135b081286959d9ea3963eafe58fa92094581/tools/clang/base_bind_rewriters/tests/passed-to-move-rewriter-original.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/591a997f9b42806d3af3dec8b5fd742dfd1d1386

commit 591a997f9b42806d3af3dec8b5fd742dfd1d1386
Author: Claudio DeSouza <claudiomdsjr@gmail.com>
Date: Wed Feb 21 17:27:16 2018

Remove some use of base::Passed

As proposed on chromium-dev recently, there seem to be no reason to keep
base::Passed around. In most cases where base::Passed is used, OnceCallback
should be preferred, specially because base::Passed is going to transfer
ownership of whatever was passed on its following run, and mostly behaving as
the intended purpose for OnceCallback.

This CL provides a good number of changes for the most straight forward cases
that do not involve changing any public interface. The code changed is mainly
from //base, //component, //crypto, and //device.

Original forum discussion can be found here: https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/abdff810-4359-41a5-8aa9-cd596c784bf5%40chromium.org?utm_medium=email&utm_source=footer

Bug: 812523
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7b8c95cee091475602dca240fca9fa843218c563
Reviewed-on: https://chromium-review.googlesource.com/923262
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538143}
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/debug/activity_tracker.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/files/file_proxy.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/message_loop/message_loop.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/process/kill_win.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/profiler/stack_sampling_profiler.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/sequenced_task_runner_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/task/cancelable_task_tracker.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/task_scheduler/delayed_task_manager.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/test/launcher/test_launcher.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/threading/sequenced_task_runner_handle_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/threading/thread_task_runner_handle.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/threading/thread_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/base/trace_event/trace_log.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/chrome/browser/chromeos/login/users/chrome_user_manager_impl.h
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/chrome/browser/chromeos/login/users/fake_chrome_user_manager.h
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/chrome/browser/chromeos/login/users/mock_user_manager.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/chrome/browser/chromeos/login/users/mock_user_manager.h
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/arc/crash_collector/arc_crash_collector_bridge.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/arc/midis/arc_midis_bridge.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/arc/test/fake_file_system_instance.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/arc/test/fake_intent_helper_instance.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/arc/video_accelerator/gpu_arc_video_encode_accelerator.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/bookmarks/browser/bookmark_storage.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/browser_watcher/window_hang_monitor_win_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/cdm/browser/media_drm_storage_impl_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/component_updater/component_installer.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/crash/content/browser/crash_handler_host_linux.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/cronet/android/cronet_bidirectional_stream_adapter.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/cronet/android/cronet_url_request_context_adapter.h
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/cronet/cronet_url_request.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/cronet/cronet_url_request_context.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/discardable_memory/client/client_discardable_shared_memory_manager.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/discardable_memory/common/discardable_shared_memory_heap_perftest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/dom_distiller/core/distilled_content_store.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/dom_distiller/core/distiller_page.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/dom_distiller/core/fake_distiller.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/domain_reliability/service.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/download/internal/background_service/blob_task_proxy.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/drive/chromeos/change_list_loader.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/drive/chromeos/directory_loader.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/drive/chromeos/file_system.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/drive/chromeos/file_system/copy_operation.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/drive/chromeos/file_system/download_operation.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/drive/chromeos/file_system/get_file_for_saving_operation.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/drive/chromeos/search_metadata.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/drive/chromeos/sync/entry_revert_performer.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/drive/drive_uploader.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/drive/drive_uploader_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/drive/service/fake_drive_service.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/feature_engagement/internal/in_memory_event_store.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/feedback/feedback_data.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/gcm_driver/gcm_driver_desktop.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/grpc_support/bidirectional_stream.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/history/core/browser/history_model_worker.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/history/core/browser/history_model_worker_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/history/core/browser/history_service.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/invalidation/impl/non_blocking_invalidator.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/leveldb_proto/proto_database_impl.h
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/leveldb_proto/testing/fake_db.h
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/metrics/child_call_stack_profile_collector.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/nacl/loader/nacl_ipc_adapter.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/nacl/loader/nacl_trusted_listener.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/nacl/renderer/ppb_nacl_private_impl.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/net_log/net_export_file_writer.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/ntp_snippets/remote/remote_suggestions_database.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/offline_pages/core/background/request_queue_in_memory_store.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/offline_pages/core/background/request_queue_store_sql.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/offline_pages/core/offline_page_test_store.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/offline_pages/core/prefetch/prefetch_dispatcher_impl.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/password_manager/core/browser/android_affiliation/affiliated_match_helper.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/password_manager/core/browser/export/password_manager_exporter.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/password_manager/core/browser/http_data_cleaner.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/password_manager/core/browser/password_store.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/password_manager/core/browser/site_affiliation/asset_link_retriever.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/policy/core/common/async_policy_provider.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/policy/core/common/cloud/cloud_policy_validator.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/policy/core/common/cloud/component_cloud_policy_service.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/policy/core/common/cloud/external_policy_data_fetcher.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/policy/core/common/remote_commands/remote_commands_service_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/policy/core/common/remote_commands/test_remote_command_job.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/previews/content/previews_io_data.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/previews/content/previews_io_data_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/previews/core/previews_black_list_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/previews/core/previews_opt_out_store_sql.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/reading_list/core/reading_list_store_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/safe_browsing/android/safe_browsing_api_handler_bridge.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/safe_browsing/browser/threat_details.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/safe_browsing/db/v4_database.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/safe_browsing/db/v4_local_database_manager.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/safe_browsing/db/v4_local_database_manager_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/safe_browsing/db/v4_store.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/search_provider_logos/logo_tracker.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/sessions/core/base_session_service.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/subresource_filter/content/browser/async_document_subresource_filter.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/subresource_filter/content/browser/content_ruleset_service.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/subresource_filter/content/browser/verified_ruleset_dealer.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/sync/device_info/device_info_sync_bridge_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/sync/driver/async_directory_type_controller_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/sync/driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/sync/driver/model_type_controller.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/sync/engine/model_safe_worker.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/sync/engine/model_safe_worker_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/sync/engine/model_type_processor_proxy.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/sync/engine/ui_model_worker_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/sync/engine_impl/model_type_connector_proxy.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/sync/model/mock_model_type_store.h
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/update_client/component.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/update_client/component_patcher_operation.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/user_manager/fake_user_manager.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/user_manager/fake_user_manager.h
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/user_manager/user_manager.h
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/user_manager/user_manager_base.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/viz/host/server_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/viz/host/server_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/viz/service/display/gl_renderer_copier.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/viz/service/display/texture_deleter.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/viz/service/frame_sinks/video_capture/frame_sink_video_capturer_impl_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/viz/service/main/viz_main_impl.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/webcrypto/webcrypto_impl.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/webdata/common/web_data_request_manager.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/components/webdata/common/web_database_service.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/crypto/nss_util.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/dbus/exported_object.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/dbus/mock_unittest.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/device/bluetooth/bluetooth_socket_win.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/device/bluetooth/bluetooth_task_manager_win.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/device/bluetooth/bluez/bluetooth_socket_bluez.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/device/gamepad/gamepad_provider.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/device/usb/usb_descriptors.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/device/usb/usb_service_impl.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/591a997f9b42806d3af3dec8b5fd742dfd1d1386/device/vr/oculus/oculus_device.cc
►

Sign in to add a comment