Issue metadata
Sign in to add a comment
|
Regression: Unnecessary focus is seen on cross icon of view site info bubble.
Reported by
pranjali...@etouch.net,
Feb 15 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 66.0.3346.8 (Official Build) c7acb5325614d652d9dd02cca2bfb0c481ac6dfd-refs/branch-heads/3346@{#13}(32/64 bit) OS: Win(10 Touch Device). Steps to reproduce: 1. Launch chrome and tap/touch on view site info button. 2. Now tap on cross icon to close bubble and again tap on view site info button. 3. Observe focus highlight. Actual: Unnecessary focus is seen on cross icon of view site info bubble. Expected: focus should not be seen on cross icon of view site info bubble. This is Regression issue broken in 'M-66’ and Using the per-revision bisect providing the bisect results, Good Build:66.0.3345.0 (Revision: 536027) Bad Build:66.0.3346.0 (Revision: 536238) You are probably looking for a change made after 536135 (known good), but no later than 536136 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/7e310a26ae898b54efa1ba85eebd512748c7091e..a6d8dfe11405486dac1603adbd00acfb4f687159 Suspect: https://chromium.googlesource.com/chromium/src/+/a6d8dfe11405486dac1603adbd00acfb4f687159 @ dtapuska: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note: 1. Issue is not seen on Windows(7,8,8.1,10) , Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.4). 2.Issue is not seen using mouse click. Kindly refer attached screen cast
,
Feb 15 2018
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6ab5e3931c5dea36ed7608ae24ac72420ca90bc commit f6ab5e3931c5dea36ed7608ae24ac72420ca90bc Author: Dave Tapuska <dtapuska@chromium.org> Date: Wed Feb 28 03:49:31 2018 Fix tab dragging outside of window with touch events. Fix a regression in dragging a tab outside of the window. The hit test that was added to check that we were inside the HT_CLIENT bounds worked correctly for the profile, min/max buttons but not for items in the tab strip. The WM_MOUSE compatiblity events need to be dispatched to make this drag of the tab work. The hit test was actually added because it solved a problem with the profile avatar button and the window getting dismissed. The WM_TOUCH path solves it in a slightly different way incrementing touch_down_contexts and returns MA_NOACTIVATE if there are any touch down contexts active. Use this same way with WM_POINTER for touch. BUG= 812508 , 816391 Change-Id: Iacc874ab164866567e8c0cde14c2a1803f2081e2 Reviewed-on: https://chromium-review.googlesource.com/938221 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#539696} [modify] https://crrev.com/f6ab5e3931c5dea36ed7608ae24ac72420ca90bc/ui/views/mus/BUILD.gn [modify] https://crrev.com/f6ab5e3931c5dea36ed7608ae24ac72420ca90bc/ui/views/widget/widget_interactive_uitest.cc [modify] https://crrev.com/f6ab5e3931c5dea36ed7608ae24ac72420ca90bc/ui/views/win/hwnd_message_handler.cc
,
Feb 28 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pranjali...@etouch.net
, Feb 15 2018