New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 812505 link

Starred by 2 users
Status: Fixed
Owner:
ccameron@chromium.org
Closed: Feb 2018
Cc:
sdy@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
mac-bugs-priority@chromium.org
█ ramyan@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : [Mac] NTPs does not trigger quickly while opening multiple tabs.

Reported by avsha...@etouch.net, Feb 15 2018 
Chrome Version : 66.0.3347.0 (Official Build) 3b9cfdda2eb80dab7457ec61e619dd910d194248-refs/heads/master@{#536620} 64-bit
OS : Mac(10.12.6, 10.13.1, 10.13.4)

Precondition : Install a fresh copy of Chrome.

What steps will reproduce the problem?
1. Launch chrome, press and hold ‘CMD + T’ keys to open multiple tabs.
2. Observe the speed while opening multiple tabs. 

Actual Result : NTPs does not trigger quickly while opening multiple tabs. 

Expected Result : NTPs should trigger quickly when opening multiple tabs.

This is a regression issue broken in ‘M-66’ and will soon update remaining info.
Good build : 66.0.3346.8
Bad build : 66.0.3347.0
Actual_Tabs.mov
2.4 MB View Download
Expected_Tabs.mov
3.1 MB View Download

Comment 1 by avsha...@etouch.net, Feb 15 2018

Labels: hasbisect-per-revision RegressedIn-66 FoundIn-66 Target-66 ET-MUM-Reported
Owner: ccameron@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue broken in ‘M-66’ and providing the bisect using ‘per-revision’ script:
Good build : 66.0.3346.8 (Revision : 536239)
Bad build : 66.0.3347.0 (Revision : 536620)

You are probably looking for a change made after 536429 (known good), but no later than 536430 (first known bad).

Change Log URL:
https://chromium.googlesource.com/chromium/src/+log/46f115f22260093ee7bc2a8764adf64d9c48a612..0158ac8bd270408aa9f3b44e19524c5f8d54cb97

Suspect : https://chromium.googlesource.com/chromium/src/+/0158ac8bd270408aa9f3b44e19524c5f8d54cb97

@ccameron : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note :
1. Delay is also observed when opening a single tab through mouse click. 
2. This is Mac OS specific issue and the same is not observed on Windows(7,8,8.1,10) and Linux(14.04 LTS) OS
3. Issue is also reproducible on Canary #66.0.3348.0 build.

Comment 2 by rbasuvula@chromium.org, Feb 15 2018

Labels: ReleaseBlock-Stable
Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Comment 3 by ccameron@chromium.org, Feb 16 2018

Cc: sdy@chromium.org
Yeah, that's definitely this change...
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a89487894c5c141e32bd716d72ce4e0f63800d4

commit 5a89487894c5c141e32bd716d72ce4e0f63800d4
Author: Christopher Cameron <ccameron@chromium.org>
Date: Mon Feb 19 09:03:23 2018

mac: Don't pause for frames with no frame sink

This should not have been removed in https://crrev.com/536430

Move tracking from RenderWidgetHostImpl (where it is tracked only in
non-viz mode) to BrowserCompositorView, where it is tracked in both
modes.

Bug: 772576,  812505 ,  812156 
Change-Id: I006c1c78f2dc148602f08253745993f8a57a7e16
Reviewed-on: https://chromium-review.googlesource.com/923379
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537604}
[modify] https://crrev.com/5a89487894c5c141e32bd716d72ce4e0f63800d4/content/browser/renderer_host/browser_compositor_view_mac.mm

Comment 5 by pnoland@chromium.org, Feb 20 2018

Labels: zine-triaged

Comment 6 by ccameron@chromium.org, Feb 21 2018

Status: Fixed (was: Assigned)

Comment 7 by avsha...@etouch.net, Feb 22 2018

Labels: TE-Verified-M66 TE-Verified-66.0.3352.0
Update : 
Verified above issue in latest Canary #66.0.3352.0 build on Mac(10.12.6, 10.13.1, 10.13.4) OS and the issue is fixed. Now NTPs trigger quickly while opening multiple tabs through keyboard shortcuts. Kindly review an attached screen cast.

Thank you!
Canary_behavior.mov
2.4 MB View Download
►

Sign in to add a comment