Overview mode: fix always on top windows' animation |
|||||
Issue descriptionMRU list does not handle the correct z-order of windows, i.e. an always-on-top window may not be the first window in the MRU list. This will cause problems for the new animation. This will be a follow up cl for crrev.com/c/882008
,
Mar 2 2018
FYI: WindowSelectorTest.HandleAlwaysOnTopWindow is failing consistently: [ RUN ] WindowSelectorTest.HandleAlwaysOnTopWindow ../../ash/wm/overview/window_selector_unittest.cc:2489: Failure Value of: window3->layer()->GetAnimator()->is_animating() Actual: false Expected: true ../../ash/wm/overview/window_selector_unittest.cc:2491: Failure Value of: window5->layer()->GetAnimator()->is_animating() Actual: false Expected: true ../../ash/wm/overview/window_selector_unittest.cc:2492: Failure Value of: window6->layer()->GetAnimator()->is_animating() Actual: false Expected: true [ FAILED ] WindowSelectorTest.HandleAlwaysOnTopWindow (74 ms)
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ccdb2d37db26a5c049e926340b7873612dafe81 commit 4ccdb2d37db26a5c049e926340b7873612dafe81 Author: Greg Thompson <grt@chromium.org> Date: Fri Mar 02 10:40:42 2018 Disable WindowSelectorTest.HandleAlwaysOnTopWindow due to consistent failures. BUG=812497 TBR=wutao@chromium.org Change-Id: I4c72fbf63324faea9d4f56b9b8e99b55ccb8592d Reviewed-on: https://chromium-review.googlesource.com/945732 Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#540489} [modify] https://crrev.com/4ccdb2d37db26a5c049e926340b7873612dafe81/ash/wm/overview/window_selector_unittest.cc
,
Mar 7 2018
,
Mar 8 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8bcc916b39dfba44b0846adf5d1b115c8f93919 commit b8bcc916b39dfba44b0846adf5d1b115c8f93919 Author: wutao <wutao@chromium.org> Date: Thu Mar 08 19:35:52 2018 M66 Merge: cros: Handle AlwaysOnTop window in new Overview animations. This cl handles the correct z-order of visible windows including AlwaysOnTop windows in the new Overview animations. TBR=oshima@chromium.org Bug: 812497 Test: WindowSelectorTest.HandleAlwaysOnTopWindow Change-Id: I29dfc6beaa4bf9a5b549a78d9291acd861f17764 Reviewed-on: https://chromium-review.googlesource.com/936453 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540390}(cherry picked from commit 614415c6398168b80f74e8c454fa69bcc91e01fd) Reviewed-on: https://chromium-review.googlesource.com/955943 Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#106} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/b8bcc916b39dfba44b0846adf5d1b115c8f93919/ash/wm/overview/window_grid.cc [modify] https://crrev.com/b8bcc916b39dfba44b0846adf5d1b115c8f93919/ash/wm/overview/window_grid.h [modify] https://crrev.com/b8bcc916b39dfba44b0846adf5d1b115c8f93919/ash/wm/overview/window_selector.cc [modify] https://crrev.com/b8bcc916b39dfba44b0846adf5d1b115c8f93919/ash/wm/overview/window_selector_unittest.cc
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fda8f637aa15317f42f613274dbef90ebad3d00 commit 3fda8f637aa15317f42f613274dbef90ebad3d00 Author: Greg Thompson <grt@chromium.org> Date: Thu Mar 08 19:36:45 2018 M66 merge: Disable WindowSelectorTest.HandleAlwaysOnTopWindow due to consistent failures. BUG=812497 TBR=wutao@chromium.org,grt@chromium.org Change-Id: I4c72fbf63324faea9d4f56b9b8e99b55ccb8592d Reviewed-on: https://chromium-review.googlesource.com/945732 Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540489}(cherry picked from commit 4ccdb2d37db26a5c049e926340b7873612dafe81) Reviewed-on: https://chromium-review.googlesource.com/956108 Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#107} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/3fda8f637aa15317f42f613274dbef90ebad3d00/ash/wm/overview/window_selector_unittest.cc
,
Aug 1
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Mar 2 2018