New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812477 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Network config dialog: Errors scroll off bottom of dialog

Project Member Reported by steve...@chromium.org, Feb 15 2018

Issue description

For long network config dialogs such as Open VPN, error messages may scroll off the bottom of the dialog.

We should ensure that the error message is always visible.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f54d8999aa322ffb5b58b103c1b24ea1529fecf

commit 0f54d8999aa322ffb5b58b103c1b24ea1529fecf
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Feb 22 03:58:37 2018

Network config: Show error messages in button container

This CL:
* Moves the 'error' message display to the host dialogs so that it
  can be displayed in the button container which is always shown at
  the bottom of the dialog.
* Eliminates the 'Connecting' message which is no longer necessary
  since we now close the dialogs as soon as the asynchronous
  connection attempt starts.

Bug:  812477 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5fa17ed3b568f689bd76c71b9a921010a81bf56e
Reviewed-on: https://chromium-review.googlesource.com/922795
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kevin Cernekee <cernekee@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538341}
[modify] https://crrev.com/0f54d8999aa322ffb5b58b103c1b24ea1529fecf/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html
[modify] https://crrev.com/0f54d8999aa322ffb5b58b103c1b24ea1529fecf/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.js
[modify] https://crrev.com/0f54d8999aa322ffb5b58b103c1b24ea1529fecf/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/0f54d8999aa322ffb5b58b103c1b24ea1529fecf/chrome/browser/resources/settings/internet_page/internet_config.js
[modify] https://crrev.com/0f54d8999aa322ffb5b58b103c1b24ea1529fecf/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/0f54d8999aa322ffb5b58b103c1b24ea1529fecf/ui/webui/resources/cr_components/chromeos/network/network_config.js

Labels: Merge-Request-65
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 22 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: steve...@chromium.org harpreet@chromium.org dsunk...@chromium.org
 Issue 814903  has been merged into this issue.
Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 26 2018

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 Deleted

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 27 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d21271c4d72055bd7aafb195ba9ad7e55aab4171

commit d21271c4d72055bd7aafb195ba9ad7e55aab4171
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Feb 27 23:19:11 2018

Network config: Show error messages in button container

This CL:
* Moves the 'error' message display to the host dialogs so that it
  can be displayed in the button container which is always shown at
  the bottom of the dialog.
* Eliminates the 'Connecting' message which is no longer necessary
  since we now close the dialogs as soon as the asynchronous
  connection attempt starts.

TBR=stevenjb@chromium.org

(cherry picked from commit 0f54d8999aa322ffb5b58b103c1b24ea1529fecf)

Bug:  812477 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5fa17ed3b568f689bd76c71b9a921010a81bf56e
Reviewed-on: https://chromium-review.googlesource.com/922795
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kevin Cernekee <cernekee@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#538341}
Reviewed-on: https://chromium-review.googlesource.com/940430
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#613}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/d21271c4d72055bd7aafb195ba9ad7e55aab4171/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html
[modify] https://crrev.com/d21271c4d72055bd7aafb195ba9ad7e55aab4171/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.js
[modify] https://crrev.com/d21271c4d72055bd7aafb195ba9ad7e55aab4171/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/d21271c4d72055bd7aafb195ba9ad7e55aab4171/chrome/browser/resources/settings/internet_page/internet_config.js
[modify] https://crrev.com/d21271c4d72055bd7aafb195ba9ad7e55aab4171/ui/webui/resources/cr_components/chromeos/network/network_config.html
[modify] https://crrev.com/d21271c4d72055bd7aafb195ba9ad7e55aab4171/ui/webui/resources/cr_components/chromeos/network/network_config.js

Sign in to add a comment