New issue
Advanced search Search tips

Issue 812472 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

chrome tab "New Tab" gets cut and also no close button

Project Member Reported by warx@chromium.org, Feb 15 2018

Issue description

tot Chrome

 
Screenshot 2018-02-14 at 6.36.22 PM.png
323 KB View Download

Comment 1 by warx@chromium.org, Feb 15 2018

Cc: afakhry@chromium.org sky@chromium.org
66.0.3348.0 Eve
Cc: malaykeshav@chromium.org pkasting@chromium.org
Any steps to repro this?
This happens with a dsf > 1

I recently changed the canvas painter. Will try reverting the change to see if thats the cause.
Owner: malaykeshav@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by warx@chromium.org, Feb 15 2018

No repro steps. It just happened on my eve device.
Labels: OS-Linux OS-Windows
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21620f905fe7cf72d23c16e170e3f9c8018ed0a1

commit 21620f905fe7cf72d23c16e170e3f9c8018ed0a1
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Fri Feb 16 02:36:16 2018

Bug fix to add correct scale to the tab clip path

The clip path for tab is not being scaled based on the device scale
leading to incorrectly clipped tabs at HiDPI.

Bug:  812472 
Change-Id: I4f016dec409dbd61eb569efc21eeab98dc3cfd74
Component: Tab, Clipping
Reviewed-on: https://chromium-review.googlesource.com/922454
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537122}
[modify] https://crrev.com/21620f905fe7cf72d23c16e170e3f9c8018ed0a1/chrome/browser/ui/views/tabs/tab.cc

Status: Fixed (was: Assigned)
Labels: TE-NeedsTriageFromMTV
Unable to reproduce the issue on chrome version 66.0.3348.0 using windows 10 and Ubuntu 14.04. As ET team doesn't have "eve device" to check the issue, Hence adding label TE-NeedsTriageFromMTV and requesting someone from MTV to have a look into it for the verification of fix. 

Thanks!

Sign in to add a comment