New issue
Advanced search Search tips

Issue 812460 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 812037



Sign in to add a comment

[Demo mode] Create hooks for development of demo mode feature

Project Member Reported by agawronska@chromium.org, Feb 15 2018

Issue description

* Create flag for development of the feature

* Create shortcut to trigger demo mode setup from OOBE flow

* Create UI hook for demo mode setup

Shortcut and UI are temporary. They will be used for development and updated when the final UX design is provided.     
 
Blocking: 812037
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fa0c20bef4df9dd9810ca6b3bb2f4148e628df8

commit 7fa0c20bef4df9dd9810ca6b3bb2f4148e628df8
Author: Aga Wronska <agawronska@chromium.org>
Date: Tue Feb 20 18:07:52 2018

demo mode: Add feature flag and keycombo for demo mode.

--enable-demo-mode switch turns on new demo mode feature that is under
development.
Ctrl+Alt+D shortcut opens new demo mode setup flow from OOBE (sign in screen).
It is used for development and might change in the future.

Change-Id: Ie3c0d954cd7d3d82f030873b9472debb1ebb2a1d
Bug:  812460 
Reviewed-on: https://chromium-review.googlesource.com/914846
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537820}
[modify] https://crrev.com/7fa0c20bef4df9dd9810ca6b3bb2f4148e628df8/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/7fa0c20bef4df9dd9810ca6b3bb2f4148e628df8/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/7fa0c20bef4df9dd9810ca6b3bb2f4148e628df8/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h
[modify] https://crrev.com/7fa0c20bef4df9dd9810ca6b3bb2f4148e628df8/chromeos/chromeos_switches.cc
[modify] https://crrev.com/7fa0c20bef4df9dd9810ca6b3bb2f4148e628df8/chromeos/chromeos_switches.h
[modify] https://crrev.com/7fa0c20bef4df9dd9810ca6b3bb2f4148e628df8/ui/login/display_manager.js

Summary: [Demo mode] Create hooks for development of demo mode feature (was: Create hooks for development of demo mode feature)
Components: UI>Shell>DemoMode
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b9c97dfe8c897fcc463f179baef5df5105c8ff5

commit 9b9c97dfe8c897fcc463f179baef5df5105c8ff5
Author: Aga Wronska <agawronska@chromium.org>
Date: Thu Mar 08 23:04:18 2018

demo mode: Create Web UI entry point for the development of demo mode setup flow.

This UI allows user to initiate desired demo mode setup flow. It is shown as a
part of OOBE experience. It can be triggered by using keycombo on
'Sign in' screen. Some settings (locale, network) chosen during OOBE are
relevant for the demo mode setup.

UI will be updated when the final design and mocks are provided.

Bug:  812460 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifccdb37a3cb8364fa1b247ef30caa552bb858491
Reviewed-on: https://chromium-review.googlesource.com/932914
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541921}
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/app_launch_signin_screen.cc
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/app_launch_signin_screen.h
[add] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/demo_setup_browsertest.cc
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/existing_user_controller.h
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/lock/webui_screen_locker.h
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/oobe_screen.cc
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/oobe_screen.h
[add] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/screens/demo_setup_screen.cc
[add] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/screens/demo_setup_screen.h
[add] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/screens/demo_setup_screen_view.cc
[add] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/screens/demo_setup_screen_view.h
[add] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/screens/mock_demo_setup_screen.cc
[add] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/screens/mock_demo_setup_screen.h
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/screens/screen_exit_code.cc
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/screens/screen_exit_code.h
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/ui/login_display.h
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/ui/login_display_webui.cc
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/ui/login_display_webui.h
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/custom_elements_login.html
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/custom_elements_login.js
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/custom_elements_oobe.html
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/custom_elements_oobe.js
[add] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/demo_setup.css
[add] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/demo_setup.html
[add] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/demo_setup.js
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/login.js
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/login_non_lock_shared.js
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/login_screens.html
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/md_login.js
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/md_login_screens.html
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/oobe.js
[add] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/oobe_screen_demo_setup.html
[add] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/oobe_screen_demo_setup.js
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/resources/chromeos/login/oobe_screens.html
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h
[add] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.cc
[add] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.h
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/chrome/test/BUILD.gn
[modify] https://crrev.com/9b9c97dfe8c897fcc463f179baef5df5105c8ff5/ui/login/display_manager.js

Status: Fixed (was: Started)

Sign in to add a comment