New issue
Advanced search Search tips

Issue 812457 link

Starred by 1 user
Status: Duplicate
Merged: issue 829028
Owner:
mstensho@chromium.org
Closed: Oct 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[LayoutNG] multicol on html element and quirks body size causes test to fail

Project Member Reported by atotic@chromium.org, Feb 15 2018 
/fast/multicol/multicol-on-root-element-quirks.html
will start failing after CL:912609 lands.

I think the cause is enforcement of minimum BODY size in quirks mode, and its interaction with computation of column sizes.

I've tried fixing it by not enforcing min body size when
ConstraintSpace().BlockFragmentationType() == kFragmentColumn 

inside

NGBlockLayoutAlgorithm::CalculateDefaultBlockContentSize
NGBlockLayoutAlgorithm::CalculateSpecMinimumBlockSize

but that did not work.

My guess is that the fix is to disable min size enforcement for column layout because test used to pass, but I am not catching all cases properly.

Comment 1 by mstensho@chromium.org, Feb 15 2018

Labels: -Pri-3 Pri-2
I think you're right. There should be no need for quirky behavior for multicol containers, since multicol wasn't yet invented when quirky browsers roamed the Earth.

Comment 2 by atotic@chromium.org, Feb 15 2018 

More failing tests: all of these time out

fast/multicol/huge-column-count.html
fast/multicol/multicol-on-root-element-quirks.html
svg/foreign-object-under-shadow-root-under-hidden.html
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99a1dd840f2f6b0844335f13dd3093a59414e9b0

commit 99a1dd840f2f6b0844335f13dd3093a59414e9b0
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Thu Feb 22 12:07:24 2018

[LayoutNG] multicol-on-root-element-quirks.html passes.

So update the expectation.

TBR=atotic@chromium.org

Bug:  812457 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I309f1218d55b8a83b682b1ecdb61133f8a809ebc
Reviewed-on: https://chromium-review.googlesource.com/931043
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538409}
[modify] https://crrev.com/99a1dd840f2f6b0844335f13dd3093a59414e9b0/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG

Comment 4 by mstensho@chromium.org, Oct 11

Mergedinto: 829028
Status: Duplicate (was: Assigned)
Not really interesting to keep a bug open on this specific issue.
►

Sign in to add a comment