Improve accessibility labeling for security indicators |
||||
Issue descriptionAs part of my work on our current HTTPS Indicator UI study (issue 803138 and issue 803501 ), some regressions around the accessibility labels for the visual elements of our security indicators came up ( issue 812034 ). tapted@ discussed (https://crrev.com/c/917282) a potential longer term solution of having ToolbarModelImpl::GetSecureVerboseText() explicitly set the accessibility label: > Would it would be more robust to pass a `base::string16* accessibility_label` to > ToolbarModelImpl::GetSecureVerboseText()? or have it return a std::pair? the > logic matches for now, but when the logic in GetSecureVerboseText changes again, > it will be easy for these to get out of sync. This seems like a good idea to investigate further, although the specific code in question (c/b/ui/cocoa/location_bar/page_info_bubble_decoration.mm) will likely be going away with the mac views work. However, this could still be a good way to generalize how the security indicators get labeled for accessibility purposes, e.g. making it easier to give more descriptive labels for screen-readers.
,
Oct 24
,
Nov 6
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f7a1b1ed923cc895590bee7c3d5ae90c3a688e7 commit 9f7a1b1ed923cc895590bee7c3d5ae90c3a688e7 Author: Joe DeBlasio <jdeblasio@chromium.org> Date: Tue Nov 13 02:48:24 2018 Unification of accessibility and secure chip logic. This CL simplifies the logic that determines what text is displayed in the HTTPS UI indicator. It explicitly merges the logic for determining what text is visually displayed with that of the accessibility label into one function. Bug: 812447 Change-Id: I72125b81003223ecd00d290a6900533dfb424d10 Reviewed-on: https://chromium-review.googlesource.com/c/1331569 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#607456} [modify] https://crrev.com/9f7a1b1ed923cc895590bee7c3d5ae90c3a688e7/chrome/browser/ui/views/location_bar/location_icon_view.cc [modify] https://crrev.com/9f7a1b1ed923cc895590bee7c3d5ae90c3a688e7/components/omnibox/browser/location_bar_model.h [modify] https://crrev.com/9f7a1b1ed923cc895590bee7c3d5ae90c3a688e7/components/omnibox/browser/location_bar_model_impl.cc [modify] https://crrev.com/9f7a1b1ed923cc895590bee7c3d5ae90c3a688e7/components/omnibox/browser/location_bar_model_impl.h [modify] https://crrev.com/9f7a1b1ed923cc895590bee7c3d5ae90c3a688e7/components/omnibox/browser/test_location_bar_model.cc [modify] https://crrev.com/9f7a1b1ed923cc895590bee7c3d5ae90c3a688e7/components/omnibox/browser/test_location_bar_model.h
,
Nov 13
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jdeblasio@chromium.org
, Oct 15