New issue
Advanced search Search tips

Issue 812438 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: refactor breakpoint manager

Project Member Reported by kozy@chromium.org, Feb 15 2018

Issue description

Attempt to reduce complexity of one of most criticized part of our frontend.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c12fc6d1daf8ee88fbfadd4cf7f67ae0703d8486

commit c12fc6d1daf8ee88fbfadd4cf7f67ae0703d8486
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Tue Mar 06 21:12:05 2018

[DevTools] added more breakpoints with p2 tests

This CL is preparation step before attempt to fix existing issues.

Bug:  chromium:812438 
Change-Id: I0afa7c3a146d43d0178ea81d5c9aa77e60fcaa2a
Reviewed-on: https://chromium-review.googlesource.com/951627
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541192}
[add] https://crrev.com/c12fc6d1daf8ee88fbfadd4cf7f67ae0703d8486/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/fs-breakpoint-can-be-removed-expected.txt
[add] https://crrev.com/c12fc6d1daf8ee88fbfadd4cf7f67ae0703d8486/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/fs-breakpoint-can-be-removed-same-url-expected.txt
[add] https://crrev.com/c12fc6d1daf8ee88fbfadd4cf7f67ae0703d8486/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/fs-breakpoint-can-be-removed-same-url.js
[add] https://crrev.com/c12fc6d1daf8ee88fbfadd4cf7f67ae0703d8486/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/fs-breakpoint-can-be-removed.js
[add] https://crrev.com/c12fc6d1daf8ee88fbfadd4cf7f67ae0703d8486/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/resources/frame-with-foo-js-with-source-url.html
[add] https://crrev.com/c12fc6d1daf8ee88fbfadd4cf7f67ae0703d8486/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/resources/frame-with-foo-js.html

fs-breakpoint-can-be-removed failed on an unrelated CL here:
https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/116986

Please fix or revert.
And fs-breakpoint-can-be-removed-same-url failed on an unrelated CL here:
https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/116967
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc32fa02412aad6ed44a928917b1ae56f0f4eb72

commit fc32fa02412aad6ed44a928917b1ae56f0f4eb72
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Wed Mar 07 08:54:08 2018

Revert "[DevTools] added more breakpoints with p2 tests"

This reverts commit c12fc6d1daf8ee88fbfadd4cf7f67ae0703d8486.

Reason for revert: Likely culprit of  https://crbug.com/819523 

Original change's description:
> [DevTools] added more breakpoints with p2 tests
> 
> This CL is preparation step before attempt to fix existing issues.
> 
> Bug:  chromium:812438 
> Change-Id: I0afa7c3a146d43d0178ea81d5c9aa77e60fcaa2a
> Reviewed-on: https://chromium-review.googlesource.com/951627
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541192}

TBR=dgozman@chromium.org,kozyatinskiy@chromium.org

Change-Id: I33258296cb580d68060f4a321ac81cbe677fa403
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:812438 
Reviewed-on: https://chromium-review.googlesource.com/951769
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541387}
[delete] https://crrev.com/3cb48b3063ee8665161fd9126ba8cf8418e3510d/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/fs-breakpoint-can-be-removed-expected.txt
[delete] https://crrev.com/3cb48b3063ee8665161fd9126ba8cf8418e3510d/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/fs-breakpoint-can-be-removed-same-url-expected.txt
[delete] https://crrev.com/3cb48b3063ee8665161fd9126ba8cf8418e3510d/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/fs-breakpoint-can-be-removed-same-url.js
[delete] https://crrev.com/3cb48b3063ee8665161fd9126ba8cf8418e3510d/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/fs-breakpoint-can-be-removed.js
[delete] https://crrev.com/3cb48b3063ee8665161fd9126ba8cf8418e3510d/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/resources/frame-with-foo-js-with-source-url.html
[delete] https://crrev.com/3cb48b3063ee8665161fd9126ba8cf8418e3510d/third_party/WebKit/LayoutTests/http/tests/devtools/persistence/resources/frame-with-foo-js.html

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d75e05d3291ad9ea8be03bfd892f299f3dd18eb

commit 7d75e05d3291ad9ea8be03bfd892f299f3dd18eb
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Mar 09 19:17:05 2018

[DevTools] extracted breakpointsActive flag from BreakpointsManager

+ as bonus fixed a bug when we did not restore breakpoints active state
after profiling.

R=dgozman@chromium.org

Bug:  chromium:812438 
Change-Id: Ie01262416522d26e8b328bcbce7387fc0a097db7
Reviewed-on: https://chromium-review.googlesource.com/953131
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542189}
[modify] https://crrev.com/7d75e05d3291ad9ea8be03bfd892f299f3dd18eb/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/debugger-breakpoints-not-activated-on-reload.js
[modify] https://crrev.com/7d75e05d3291ad9ea8be03bfd892f299f3dd18eb/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-breakpoints/disable-breakpoints.js
[modify] https://crrev.com/7d75e05d3291ad9ea8be03bfd892f299f3dd18eb/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
[modify] https://crrev.com/7d75e05d3291ad9ea8be03bfd892f299f3dd18eb/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/7d75e05d3291ad9ea8be03bfd892f299f3dd18eb/third_party/WebKit/Source/devtools/front_end/sdk/module.json
[modify] https://crrev.com/7d75e05d3291ad9ea8be03bfd892f299f3dd18eb/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
[modify] https://crrev.com/7d75e05d3291ad9ea8be03bfd892f299f3dd18eb/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
[modify] https://crrev.com/7d75e05d3291ad9ea8be03bfd892f299f3dd18eb/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/7d75e05d3291ad9ea8be03bfd892f299f3dd18eb/third_party/WebKit/Source/devtools/front_end/sources_test_runner/DebuggerTestRunner.js

Comment 6 by kozy@chromium.org, May 3 2018

Status: Archived (was: Assigned)
one day..

Sign in to add a comment