New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812432 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Don't expose CSSStyleValue sub class methods/attributes to Custom Paint

Project Member Reported by nainar@chromium.org, Feb 15 2018

Issue description

Currently some of the CSSStyleValue subclasses are exposing their sub class methods and attributes to Custom Paint because the IDL states:
[ Exposed(Window TypedOM, PaintWorklet TypedOM) ]

This should instead read: 
[ RuntimeEnabled=TypedOM, Exposed=(Window,PaintWorklet) ]
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74f7d52c852550f70f99eae814e2c117e0490366

commit 74f7d52c852550f70f99eae814e2c117e0490366
Author: Naina Raisinghani <nainar@chromium.org>
Date: Fri Feb 16 04:17:02 2018

Change IDL to not expose TypedOM classes methods and attributes

Bug:  812432 
Change-Id: If94615836edd6413b211acc323c6d8644ffcbda3
Reviewed-on: https://chromium-review.googlesource.com/920326
Commit-Queue: nainar <nainar@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537192}
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSImageValue.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSKeywordValue.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSMathInvert.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSMathMax.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSMathMin.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSMathNegate.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSMathProduct.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSMathSum.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSMathValue.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSMatrixComponent.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSNumericArray.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSNumericType.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSNumericValue.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSPerspective.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSPositionValue.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSResourceValue.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSRotate.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSScale.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSSkew.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSSkewX.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSSkewY.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSTranslate.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSURLImageValue.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSUnitValue.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/CSSVariableReferenceValue.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.idl
[modify] https://crrev.com/74f7d52c852550f70f99eae814e2c117e0490366/third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadOnly.idl

Comment 2 by nainar@chromium.org, Feb 16 2018

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/789341f7946e22a3f2c6c0f2ae27312706f1e495

commit 789341f7946e22a3f2c6c0f2ae27312706f1e495
Author: Ian Kilpatrick <ikilpatrick@chromium.org>
Date: Sat Feb 17 02:00:10 2018

[typedom] Still expose CSSStyleValue and StylePropertyMapReadOnly to PaintWorklet

Reverts part of https://chromium-review.googlesource.com/c/chromium/src/+/920326

If TypedOM doesn't ship in 66 this means that we won't break paint
worklet. (We still need to expose these two classes).

Bug:  812432 
Change-Id: I358d49fecdf2169911c72dac758a745067dd5c96
Reviewed-on: https://chromium-review.googlesource.com/924604
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537503}
[modify] https://crrev.com/789341f7946e22a3f2c6c0f2ae27312706f1e495/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.idl
[modify] https://crrev.com/789341f7946e22a3f2c6c0f2ae27312706f1e495/third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadOnly.idl

Sign in to add a comment