Asset Component not visible on initial launch of Chrome from Daydream Home |
||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) What steps will reproduce the problem? (1) Enable "Chrome Icon on Daydream Home" and "VR intents" flags using chrome://flags (2) Close Chrome (3) Ensure Daydream and Chome are NOT running. (4) Launch Daydream (5) Launch Chrome from the icon on the Daydream home page. What is the expected result? Chrome should be loaded with the last website and the asset components visible. Also Existing Daydream and redoing the scenario should not cause the initial state to return each time. What happens instead? Chrome is loaded with the last website but no asset component is visible. Closing and opening Chrome shows the asset, but Closing Daydream and relaunching the entire scenario resets to the initial behavior. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Apr 26 2018
,
May 11 2018
,
May 11 2018
,
May 11 2018
,
May 11 2018
Issue 842315 has been merged into this issue.
,
May 11 2018
There are two problems described here: 1. The textured background is not used if the component is not available. That can happen when entering VR for the first time. This is intended. 2. The textured background is not loaded when going to DD home and back to Chrome. That is not intended and is a bug. The reason for 2 is that we load assets VrShell's ctor. However, going to DD home doesn't destroy VrShell. When going back to Chrome only VrShell::OnResume is called, but not the ctor. Moving asset loading to OnResume should fix this.
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3cd1b091342b2e07fa9864f23e5b37f4fff25c0 commit f3cd1b091342b2e07fa9864f23e5b37f4fff25c0 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Mon May 14 22:42:46 2018 [vr] Load assets in OnResume If going to DD home and back to Chrome we won't always recreate VrShell. This could result in no assets being loaded. Load the assets in OnResume instead. This will also apply assets that may have been updated during a VR session. Bug: 812411 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I2fc6cf2d38a71f7483f5f818e46e48e3cc9bdb0e Reviewed-on: https://chromium-review.googlesource.com/1057870 Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#558500} [modify] https://crrev.com/f3cd1b091342b2e07fa9864f23e5b37f4fff25c0/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/f3cd1b091342b2e07fa9864f23e5b37f4fff25c0/chrome/browser/android/vr/vr_gl_thread.h [modify] https://crrev.com/f3cd1b091342b2e07fa9864f23e5b37f4fff25c0/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/f3cd1b091342b2e07fa9864f23e5b37f4fff25c0/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/f3cd1b091342b2e07fa9864f23e5b37f4fff25c0/chrome/browser/vr/browser_ui_interface.h [modify] https://crrev.com/f3cd1b091342b2e07fa9864f23e5b37f4fff25c0/chrome/browser/vr/test/mock_browser_ui_interface.h [modify] https://crrev.com/f3cd1b091342b2e07fa9864f23e5b37f4fff25c0/chrome/browser/vr/ui.cc [modify] https://crrev.com/f3cd1b091342b2e07fa9864f23e5b37f4fff25c0/chrome/browser/vr/ui.h
,
May 14 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ymalik@chromium.org
, Feb 15 2018