New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 812406 link

Starred by 3 users
Status: Fixed
Owner:
zmo@chromium.org
Closed: Feb 2018
Cc:
vamshi.kommuri@chromium.org
sunn...@chromium.org
█ kbr@chromium.org
█ sindhu.chelamcherla@chromium.org
sugoi@chromium.org
moh...@chromium.org
vmi...@chromium.org
piman@chromium.org
pbomm...@chromium.org
capn@chromium.org
zmo@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

kDisableSoftwareRasterizer incorrectly disables GPU process

Project Member Reported by zmo@chromium.org, Feb 14 2018 
It should disable SwiftShader, but GPU process should still be able to launch with real GPU, unless it crashed too many times.

This should be an easy logic fix. So let's get it in for M66.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52bd0a80b359db5f9b8490b5affcfeea26dffe79

commit 52bd0a80b359db5f9b8490b5affcfeea26dffe79
Author: Zhenyao Mo <zmo@chromium.org>
Date: Fri Feb 16 02:46:10 2018

kDisableSoftwareRasterizer should not block GPU process.

Unless GPU process launching with real GPU already has crashed enough times.

BUG= 812406 
TEST=GpuProcess telemetry test (newly added)
R=piman@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic07d7007e39705dbd2b9c9391072b6626062c843
Reviewed-on: https://chromium-review.googlesource.com/920501
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537137}
[modify] https://crrev.com/52bd0a80b359db5f9b8490b5affcfeea26dffe79/content/browser/gpu/gpu_data_manager_impl.cc
[modify] https://crrev.com/52bd0a80b359db5f9b8490b5affcfeea26dffe79/content/browser/gpu/gpu_data_manager_impl.h
[modify] https://crrev.com/52bd0a80b359db5f9b8490b5affcfeea26dffe79/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/52bd0a80b359db5f9b8490b5affcfeea26dffe79/content/browser/gpu/gpu_data_manager_impl_private.h
[modify] https://crrev.com/52bd0a80b359db5f9b8490b5affcfeea26dffe79/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/52bd0a80b359db5f9b8490b5affcfeea26dffe79/content/test/gpu/gpu_tests/gpu_process_integration_test.py
[modify] https://crrev.com/52bd0a80b359db5f9b8490b5affcfeea26dffe79/gpu/config/gpu_util.cc
[modify] https://crrev.com/52bd0a80b359db5f9b8490b5affcfeea26dffe79/gpu/config/gpu_util.h

Comment 2 by zmo@chromium.org, Feb 16 2018

Owner: zmo@chromium.org
Status: Fixed (was: Untriaged)

Comment 3 by zmo@chromium.org, Mar 15 2018

Cc: pbomm...@chromium.org sunn...@chromium.org zmo@chromium.org vamshi.kommuri@chromium.org sindhu.chelamcherla@chromium.org vmi...@chromium.org kbr@chromium.org
 Issue 820733  has been merged into this issue.
►

Sign in to add a comment