which tree are you sheriffing?

chromium

I'm able to reproduce the following issue(s) on staging: the first time I click on any "File Bug" button from an alert, after page load, I get the first error in the logs, and there is no response in the UI. 

However, any subsequent click on a File Bug button does open the dialog. I'm then able to submit it successfully (bug is created), but a second error is logged to the console. 

chcunningham@: is this the problem you're seeing? It does nothing when you click "File Bug" from an alert? 

Or is it that you get the dialog, but it won't let you submit?

First error on "File Bug" click: 
Uncaught TypeError: Cannot read property 'join' of undefined
    at HTMLElement._arrayToString (som-app.vulcanized.html:29763)
    at runMethodEffect (som-app.vulcanized.html:3014)
    at Function._evaluateBinding (som-app.vulcanized.html:4827)
    at Object.runBindingEffect [as fn] (som-app.vulcanized.html:2784)
    at runEffectsForProperty (som-app.vulcanized.html:2378)
    at runEffects (som-app.vulcanized.html:2344)
    at HTMLElement._propagatePropertyChanges (som-app.vulcanized.html:3894)
    at HTMLElement._propertiesChanged (som-app.vulcanized.html:3859)
    at HTMLElement._flushProperties (som-app.vulcanized.html:1688)
    at HTMLElement._invalidateProperties (som-app.vulcanized.html:3707)



Second error after form submits:

Uncaught ReferenceError: response is not defined
    at HTMLElement._linkNewBug (som-app.vulcanized.html:30868)
    at HTMLElement.handler (som-app.vulcanized.html:1848)
    at HTMLElement.fire (som-app.vulcanized.html:8480)
    at HTMLElement._fileBugResponse (som-app.vulcanized.html:29753)
    at <anonymous>

I usually don't get the dialog. In cases where the dialog has shown, it has always succeeded. Attempting just now, I do see that stack

som-app.vulcanized.html:29763 Uncaught TypeError: Cannot read property 'join' of undefined
    at HTMLElement._arrayToString (som-app.vulcanized.html:29763)
    at runMethodEffect (som-app.vulcanized.html:3014)
    at Function._evaluateBinding (som-app.vulcanized.html:4827)
    at Object.runBindingEffect [as fn] (som-app.vulcanized.html:2784)
    at runEffectsForProperty (som-app.vulcanized.html:2378)
    at runEffects (som-app.vulcanized.html:2344)
    at HTMLElement._propagatePropertyChanges (som-app.vulcanized.html:3894)
    at HTMLElement._propertiesChanged (som-app.vulcanized.html:3859)
    at HTMLElement._flushProperties (som-app.vulcanized.html:1688)
    at HTMLElement._invalidateProperties (som-app.vulcanized.html:3707)

think I found the problem. cl out soon.

If you have time to check out the fix could you verify it on staging? 
https://14018-349237e-tainted-seanmcculloug-dot-sheriff-o-matic-staging.appspot.com/chromium

Don't worry, bugs filed there don't show up on bugs.chromium.org.

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3a16e01c76e16cde6902a4a697f63ddeb759e77a

commit 3a16e01c76e16cde6902a4a697f63ddeb759e77a
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Wed Feb 14 23:57:46 2018

[som] Fix broken file bug button.

Yay dyamic typoing.

Bug:  812403 
Change-Id: I1ba9b37129f8d0a8a0cba12b9691646c543bca3a
Reviewed-on: https://chromium-review.googlesource.com/919688
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/3a16e01c76e16cde6902a4a697f63ddeb759e77a/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.js

@Sean: Marking as fixed unless you still want to do more here.