New issue
Advanced search Search tips

Issue 812392 link

Starred by 2 users
Status: Fixed
Owner:
achuith@chromium.org
Closed: Oct 12
Cc:
norvez@chromium.org
pprabhu@chromium.org
achuith@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

audit/unify qemu flags

Project Member Reported by ihf@chromium.org, Feb 14 2018 
For context see
https://chromium-review.googlesource.com/#/c/chromiumos/chromite/+/917962/

Please check the flags we use to start qemu. Make options are consistent in all places.

Comment 1 by pwang@chromium.org, Feb 14 2018 

There is another bug that is trying to unifying the way we launch the VM.
Currently we have 
The flags are really fragmented here. 	achuith@ Would you unify the flags as well along with crbug.com/782664?

Comment 2 by pwang@chromium.org, Feb 14 2018

Cc: achuith@chromium.org

Comment 3 by achuith@chromium.org, Feb 14 2018

Labels: -Pri-3 Pri-2
I don't know if in the short term it's possible to move all the flags in a common text file. The fact that we need this to work across shell and python makes it a problem.

When I looked at this a month ago, cros_vm_lib.sh and cros_vm.py were in sync. I can take another look if they have diverged.

Comment 4 by ayatane@chromium.org, May 15 2018

Owner: achuith@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by vapier@chromium.org, Oct 12

Components: -Infra>Client>ChromeOS Infra>Client>ChromeOS>Build
Status: Fixed (was: Assigned)
cros_vm_lib.sh is dead code
►

Sign in to add a comment