New issue
Advanced search Search tips

Issue 812372 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Use expiration date instead of network when comparing masked credit cards

Project Member Reported by jsaul@google.com, Feb 14 2018

Issue description

When comparing new cards to existing masked credit cards [1], we check against the network and last four digits [2].  If Payments' and Chrome's idea of the network are different, this could cause offers to save for cards that already exist.  Instead, we should check against the expiration date and last four digits.

[1] https://cs.chromium.org/chromium/src/components/autofill/core/browser/form_data_importer.cc?l=348&rcl=c7384786e87d69901b05db058c8e014c70e707af
[2] https://cs.chromium.org/chromium/src/components/autofill/core/browser/credit_card.cc?l=602-605&rcl=fa33391487b985f547b77672d5ab5e9cc2a95534
 

Comment 1 by jsaul@google.com, Mar 13 2018

Cc: jsaul@google.com
Owner: se...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to Seb - I think you were the one that was going to write a doc on this, right?

Comment 2 by se...@chromium.org, Mar 13 2018

Yep, the are a few P1s that I want to do first though, so feel free to grab it if I take too long.

Thanks!

Sign in to add a comment