New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812348 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

"Force ad blocking on this site" setting on devtools can cause Ad blocking UI to trigger

Project Member Reported by csharrison@chromium.org, Feb 14 2018

Issue description

It seems like there may be a race condition depending on when the setting is selected in devtools. This is unintentional behavior and the original design was to make this not show any UI.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25228026800c19226ec3032184f381e173514f7d

commit 25228026800c19226ec3032184f381e173514f7d
Author: Charles Harrison <csharrison@chromium.org>
Date: Tue Feb 27 17:45:15 2018

[subresource_filter] suppress notifications when forcing activation

We should never show the Ad block UI when devtools is the cause of the
activation. This CL does that by using suppress_notification for
forced activation. This messes up some logging, so we handle that by
adding a new histogram at the //content layer.

Bug:  812348 
Change-Id: I16ae72cbb3342183a2067f2ad1698758425cd160
Reviewed-on: https://chromium-review.googlesource.com/919315
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539491}
[modify] https://crrev.com/25228026800c19226ec3032184f381e173514f7d/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc
[modify] https://crrev.com/25228026800c19226ec3032184f381e173514f7d/chrome/browser/subresource_filter/chrome_subresource_filter_client.h
[modify] https://crrev.com/25228026800c19226ec3032184f381e173514f7d/chrome/browser/subresource_filter/subresource_filter_unittest.cc
[modify] https://crrev.com/25228026800c19226ec3032184f381e173514f7d/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
[modify] https://crrev.com/25228026800c19226ec3032184f381e173514f7d/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/25228026800c19226ec3032184f381e173514f7d/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment