New issue
Advanced search Search tips

Issue 812345 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

When converting project-moblab ebuild to cros workon there is a permission denied error

Project Member Reported by haddowk@chromium.org, Feb 14 2018

Issue description



in src_install when the command:

 echo "moblab ALL = NOPASSWD: ALL" > moblab-sudo-all

Is executed the following error is observed

>>> Source prepared.
 * ACCESS DENIED:  open_rd:      /mnt/host/source/src/overlays/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-9999.ebuild
cp: cannot open '/mnt/host/source/src/overlays/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-9999.ebuild' for reading: Permission denied
>>> Configuring source in /mnt/host/source/src/overlays ...


 

Comment 1 by vapier@chromium.org, Feb 14 2018

i don't know what ebuild you're working on currently, but that output says your cwd is incorrect (outside of WORKDIR).  you can only write to files under WORKDIR and T.
The ebuild I am working on is:



The current ebuild code is :https://cs.corp.google.com/chromeos_public/src/overlays/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5.ebuild

The code is currently

    insinto /etc/sudoers.d
    echo "moblab ALL = NOPASSWD: ALL" > moblab-sudo-all
    echo "apache ALL = NOPASSWD: /sbin/reboot" > apache-reboot
    echo "apache ALL = NOPASSWD: /sbin/restart" > apache-restart
    echo "apache ALL = NOPASSWD: /sbin/start" > apache-start
    echo "apache ALL = NOPASSWD: /sbin/stop" > apache-stop
    echo "apache ALL = NOPASSWD: /usr/sbin/apache2" > apache-apache2
    echo "apache ALL = NOPASSWD: /usr/bin/update_engine_client" > apache-update

Comment 3 by vapier@chromium.org, Feb 14 2018

i suspect you've made changes to the ebuild relative to what's in the tree, and it's those changes that have broken assumptions in src_install (probably relative to what i mentioned in comment #1)

the ebuild, as written in the tree, has S=${WORKDIR} so src_install's cwd starts off (correctly) in that writable location
I have change the existing ebuild and will send a CL to you

S=${WORKDIR}  is not allowed in ebuilds that inherit from cros-workon

https://cs.corp.google.com/chromeos_public/src/third_party/chromiumos-overlay/eclass/cros-workon.eclass?rcl=ded33d80ebc6ee0916bf00c162b929acd210c722&l=395

Is there a doc/codelab on cros-workon ?  I do not want to keep having to take up your time asking you what the correct procedure is for such changes.

Comment 5 by vapier@chromium.org, Feb 14 2018

if you need scratch space to generate a file, use $T instead

alternatively, newins can install from stdin.
  echo "moblab ALL = NOPASSWD: ALL" | newins - moblab-sudo-all
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/41985950cb3be46e622dbefa6480208646b9dff4

commit 41985950cb3be46e622dbefa6480208646b9dff4
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Feb 16 05:44:04 2018

[moblab] Prepare ebuild for moving to cros-workon

Change the sudoers generation to use newins rather than
being created then installed.

BUG= chromium:812345 
TEST=ran emerge-guado_moblab chromeos-base/chromeos-bsp-moblab

Change-Id: Ia6b34db4d3bd13016101c953f9ee7baf10fb5268
Reviewed-on: https://chromium-review.googlesource.com/919824
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/41985950cb3be46e622dbefa6480208646b9dff4/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5.ebuild
[rename] https://crrev.com/41985950cb3be46e622dbefa6480208646b9dff4/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r85.ebuild

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 16 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/76f08bd6e248334eabb96fb325cabfe4e3de7c3a

commit 76f08bd6e248334eabb96fb325cabfe4e3de7c3a
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Feb 16 20:57:59 2018

[moblab] Prepare ebuild for moving to cros-workon

Change the sudoers generation to use newins rather than
being created then installed.

BUG= chromium:812345 
TEST=ran emerge-guado_moblab chromeos-base/chromeos-bsp-moblab

Change-Id: Ia6b34db4d3bd13016101c953f9ee7baf10fb5268
Reviewed-on: https://chromium-review.googlesource.com/919824
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit 41985950cb3be46e622dbefa6480208646b9dff4)
Reviewed-on: https://chromium-review.googlesource.com/924180
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/76f08bd6e248334eabb96fb325cabfe4e3de7c3a/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5.ebuild
[add] https://crrev.com/76f08bd6e248334eabb96fb325cabfe4e3de7c3a/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r85.ebuild

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 16 2018

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/b1b6dfa3bdf9acc000afd86f06f37250982d1fbc

commit b1b6dfa3bdf9acc000afd86f06f37250982d1fbc
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri Feb 16 20:58:01 2018

[moblab] Prepare ebuild for moving to cros-workon

Change the sudoers generation to use newins rather than
being created then installed.

BUG= chromium:812345 
TEST=ran emerge-guado_moblab chromeos-base/chromeos-bsp-moblab

Change-Id: Ia6b34db4d3bd13016101c953f9ee7baf10fb5268
Reviewed-on: https://chromium-review.googlesource.com/919824
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit 41985950cb3be46e622dbefa6480208646b9dff4)
Reviewed-on: https://chromium-review.googlesource.com/924481
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/b1b6dfa3bdf9acc000afd86f06f37250982d1fbc/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5.ebuild
[add] https://crrev.com/b1b6dfa3bdf9acc000afd86f06f37250982d1fbc/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r85.ebuild

Status: Fixed (was: Started)

Sign in to add a comment