Local variations server testing doesn't work with new HTTP logic |
|||
Issue descriptionLocal variations server testing doesn't work with new HTTP logic. The problem is when testing locally, a user typically runs a local variations server on http://localhost:8080 with http-decryption disabled and specifies this URL to Chrome. But the new logic added in variations_service.cc for HTTP treats these cases as HTTP fallback requests and expects things to be encrypted, etc. We should change the logic to not do the encryption logic if the URL is an HTTP URL specified manually on the command-line. Carlos, could you take a look?
,
Feb 14 2018
In particular, this logic does the encryption based on HTTP of the scheme: https://cs.chromium.org/chromium/src/components/variations/service/variations_service.cc?rcl=bae2473465972c04b9b00d78ebd602f95cfa9975&l=503
,
Feb 15 2018
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd06f17c50b043cfb2ba4c44e116af5b6e6cdb9f commit dd06f17c50b043cfb2ba4c44e116af5b6e6cdb9f Author: Carlos IL <carlosil@chromium.org> Date: Wed Feb 21 23:48:46 2018 VariationsService will not encrypt headers for seed fetches to flag URL. VariationsService was modified so that If-None-Match headers are not encrypted when sending to an HTTP URL if that URL was specified via the --variations-server-url command line flag. Tests were also added for the different cases where encryption should/should not be triggered. Bug: 812343 Change-Id: I3e8dc021e70a1ec225349830b14e77087678763a Reviewed-on: https://chromium-review.googlesource.com/922451 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#538258} [modify] https://crrev.com/dd06f17c50b043cfb2ba4c44e116af5b6e6cdb9f/components/variations/service/variations_service.cc [modify] https://crrev.com/dd06f17c50b043cfb2ba4c44e116af5b6e6cdb9f/components/variations/service/variations_service.h
,
Feb 21 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by asvitk...@chromium.org
, Feb 14 2018