New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812335 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 723820



Sign in to add a comment

Create Chrome*.apk.java.info files in out/Release/size-info

Project Member Reported by wnwen@chromium.org, Feb 14 2018

Issue description

Supersize needs to be able to go from fully qualified java class name to a source file. Similar to pak.info files.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62c0e0d36903e3d321b34a08c8aa01d518967e54

commit 62c0e0d36903e3d321b34a08c8aa01d518967e54
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Feb 21 23:34:18 2018

Android: Add .info files for compiled jars

The first step to collect enough information for supersize to be able to
analyze dex files in apks.

Bug:  812335 
Change-Id: I1f661cc31201a6208a7f7ef164a124840c942c47
Reviewed-on: https://chromium-review.googlesource.com/922141
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538254}
[modify] https://crrev.com/62c0e0d36903e3d321b34a08c8aa01d518967e54/build/android/gyp/javac.py
[modify] https://crrev.com/62c0e0d36903e3d321b34a08c8aa01d518967e54/build/config/android/internal_rules.gni

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8863f7a13365059ea86ee7c79ef9fe6aba119424

commit 8863f7a13365059ea86ee7c79ef9fe6aba119424
Author: Peter Wen <wnwen@chromium.org>
Date: Thu Feb 22 16:33:19 2018

Android: Coalesce .jar.info files for apks

Collect all the .jar.info files of apk dependencies as well as any java
files in the apk target itself. Write this information to size-info/ for
ease of use with the supersize tool.

Bug:  812335 
Change-Id: Ie783468ab919b6e478282cad8ca71bd2f914c3f9
Reviewed-on: https://chromium-review.googlesource.com/922805
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538452}
[modify] https://crrev.com/8863f7a13365059ea86ee7c79ef9fe6aba119424/build/android/gyp/javac.py
[modify] https://crrev.com/8863f7a13365059ea86ee7c79ef9fe6aba119424/build/config/android/internal_rules.gni
[modify] https://crrev.com/8863f7a13365059ea86ee7c79ef9fe6aba119424/build/config/android/rules.gni

Comment 3 by wnwen@chromium.org, Mar 1 2018

Still needs to handle android_java_prebuilt libraries.

Comment 4 by wnwen@chromium.org, Mar 19 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb58ecbc7cd1aec83061f9c71d0258fb50a3dac1

commit bb58ecbc7cd1aec83061f9c71d0258fb50a3dac1
Author: Peter Wen <wnwen@chromium.org>
Date: Tue Mar 27 03:41:17 2018

Supersize: Include prebuilt jars in *.apk.jar.info

Information from prebuilt jars from source or generated class jars are
required to fully map every class in *.dex files back to a source
location.

Bug:  812335 
Change-Id: Ied04fe60a0a017d84e3d7f99a2ed037787de6f0e
Reviewed-on: https://chromium-review.googlesource.com/976185
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545991}
[modify] https://crrev.com/bb58ecbc7cd1aec83061f9c71d0258fb50a3dac1/build/android/gyp/javac.py
[modify] https://crrev.com/bb58ecbc7cd1aec83061f9c71d0258fb50a3dac1/tools/binary_size/libsupersize/apkanalyzer.py

Comment 6 by wnwen@chromium.org, Mar 28 2018

Status: Fixed (was: Started)
Officially done.

Sign in to add a comment