New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 812323 link

Starred by 2 users
Status: Fixed
Owner:
iclell...@chromium.org
Closed: Mar 2018
Cc:
█ binlu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove Vibration from Feature-policy features

Project Member Reported by iclell...@chromium.org, Feb 14 2018 
In the year or so since it was proposed, there has been little support for adding vibration to feature policy, and no clear direction for what disabling the feature should do if we *do* proceed with it.

We should remove the code which is currently not being worked on, and if future discussion around standards leads to a clear spec change, then we can easily reinstate it, or write the new behavior at that time.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6684fb7780bea4dacdcb12b14a9b56894e07cbfb

commit 6684fb7780bea4dacdcb12b14a9b56894e07cbfb
Author: Ian Clelland <iclelland@chromium.org>
Date: Thu Feb 15 16:46:13 2018

Remove vibration from feature policy

Bug:  812323 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I187529189ee0e540f458d2601ac176e355cad975
Reviewed-on: https://chromium-review.googlesource.com/916807
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537045}
[modify] https://crrev.com/6684fb7780bea4dacdcb12b14a9b56894e07cbfb/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/6684fb7780bea4dacdcb12b14a9b56894e07cbfb/content/test/data/allowed_frames.html
[modify] https://crrev.com/6684fb7780bea4dacdcb12b14a9b56894e07cbfb/content/test/data/feature-policy-main.html.mock-http-headers
[modify] https://crrev.com/6684fb7780bea4dacdcb12b14a9b56894e07cbfb/content/test/data/feature-policy1.html.mock-http-headers
[modify] https://crrev.com/6684fb7780bea4dacdcb12b14a9b56894e07cbfb/content/test/data/feature-policy2.html.mock-http-headers
[modify] https://crrev.com/6684fb7780bea4dacdcb12b14a9b56894e07cbfb/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/6684fb7780bea4dacdcb12b14a9b56894e07cbfb/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/6b6cbd30166857ab465361aeff2f91efb01d3610/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/resources/feature-policy-vibrate-relocate.html
[delete] https://crrev.com/6b6cbd30166857ab465361aeff2f91efb01d3610/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/resources/feature-policy-vibrate.html
[delete] https://crrev.com/6b6cbd30166857ab465361aeff2f91efb01d3610/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/resources/helper.js
[delete] https://crrev.com/6b6cbd30166857ab465361aeff2f91efb01d3610/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-allowed-by-container-policy-relocate-and-no-reload-expected.txt
[delete] https://crrev.com/6b6cbd30166857ab465361aeff2f91efb01d3610/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-allowed-by-container-policy-relocate-and-no-reload.html
[delete] https://crrev.com/6b6cbd30166857ab465361aeff2f91efb01d3610/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-allowed-by-container-policy-relocate-and-reload.html
[delete] https://crrev.com/6b6cbd30166857ab465361aeff2f91efb01d3610/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-allowed-by-container-policy.html
[delete] https://crrev.com/6b6cbd30166857ab465361aeff2f91efb01d3610/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-disabled-expected.txt
[delete] https://crrev.com/6b6cbd30166857ab465361aeff2f91efb01d3610/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-disabled.php
[delete] https://crrev.com/6b6cbd30166857ab465361aeff2f91efb01d3610/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-enabledforall.php
[delete] https://crrev.com/6b6cbd30166857ab465361aeff2f91efb01d3610/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-enabledforself-expected.txt
[delete] https://crrev.com/6b6cbd30166857ab465361aeff2f91efb01d3610/third_party/WebKit/LayoutTests/http/tests/feature-policy-vibrate/vibrate-enabledforself.php
[modify] https://crrev.com/6684fb7780bea4dacdcb12b14a9b56894e07cbfb/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
[modify] https://crrev.com/6684fb7780bea4dacdcb12b14a9b56894e07cbfb/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/6684fb7780bea4dacdcb12b14a9b56894e07cbfb/third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp
[modify] https://crrev.com/6684fb7780bea4dacdcb12b14a9b56894e07cbfb/third_party/WebKit/common/feature_policy/feature_policy.cc
[modify] https://crrev.com/6684fb7780bea4dacdcb12b14a9b56894e07cbfb/third_party/WebKit/common/feature_policy/feature_policy.mojom

Comment 2 by iclell...@chromium.org, Mar 15 2018

Status: Fixed (was: Started)
►

Sign in to add a comment