Incorrect handling of linear and exponential events scheduled in the past |
||
Issue descriptionIn the linear and exponential tests in https://chromium-review.googlesource.com/c/chromium/src/+/919151 the handling of these events that are scheduled to start in the past and where there is no initial event appears to be wrong. The test and reference results should be the same, but they're not.
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91d3eb7a5f18c8596f92f5f1a8cc579cb4e4d34c commit 91d3eb7a5f18c8596f92f5f1a8cc579cb4e4d34c Author: Raymond Toy <rtoy@chromium.org> Date: Fri Feb 23 00:34:32 2018 Handle initial ramp events scheduled in the past When a linear or exponential ramp is scheduled and there are no preceeding events, a setValueAtTime event is supposed to be inserted with the current value and current time. But when the ramp is scheduled in the past, the setValue event happens after the ramp event, basically negating the effect of the ramp. To fix this, set the time for the setValueAtTime event to 0 to insure it preceeds the ramp time. When new events are processed to clamp the start times to current time, these will all get updated and sorted in the correct order. the-audioparam-interface/retrospective-exponentialRampToValueAtTime.html, the-audioparam-interface/retrospective-linearRampToValueAtTime.html Bug: 812301 , 626703 Change-Id: I1c6ea4e8aaeb2cd9159c23ae5c8981d56a98f0b9 Tests: Reviewed-on: https://chromium-review.googlesource.com/926702 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#538640} [modify] https://crrev.com/91d3eb7a5f18c8596f92f5f1a8cc579cb4e4d34c/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/91d3eb7a5f18c8596f92f5f1a8cc579cb4e4d34c/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
,
Feb 23 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by rtoy@chromium.org
, Feb 15 2018Status: Started (was: Available)