stevenjb@ - what do you think? can we just move the whole files into settings now?

One thing to keep in mind is that soonish we will want to let the user setup PIN in oobe - I'm not sure how existing settings elements are exposed to oobe. stevenjb@ should be familiar though.

If the code will be used in OOBE webui then we should go ahead and move it to cr_components. That is where other components shared between OOBE and Settings live.

Do we still need:
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html/js
?

There is no reference to it in browser_resources.grd. The login code references chrome://oobe/custom_elements/pin_keyboard.html, but that is mapped to IDR_MD_CUSTOM_ELEMENTS_PIN_KEYBOARD_HTML in oobe_ui.cc.

I would prefer not to duplicate code, even "briefly", but especially if we expect to re-introduce the shared component to OOBE.

Yes, pin_keyboard.html/js is the one that incorrectly referenced from settings/people_page/pin_keyboard.

I'll see what the differences between pin and md_pin and see if I can create a cr_components and add slots and or vars for the differences.

I would expect that we would want the UIs to be consistent, so if there are differences we should just go ahead and migrate the Settings UI to also use the MD version.

+tbuckley

The MD style does not work right away (white text meant for dark background and large buttons taking up too much space on the skinny dialog for instance). The UI should be redesigned a bit to fit both.