New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 812299 link

Starred by 1 user
Status: Fixed
Owner:
jamescook@chromium.org
Closed: Feb 2018
Cc:
sky@chromium.org
█ brettw@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Add "noparent" support to DEPS files

Project Member Reported by jamescook@chromium.org, Feb 14 2018 
For OWNERS files we have "noparent", which means the file ignores rules from the parent directories.

I need something like that for DEPS. In particular, if you have:

//ash/DEPS with a bunch of rules

//ash/components/foo
//ash/components/bar

You'd like to add //ash/components/DEPS with noparent to ensure foo and bar don't pick up DEPS from ash.

(This is motivated by some cleanup of Chrome OS UI modules / apps, like our file manager, that want to be isolated.)

I think this will just be a few lines in checkdeps.py (or builddeps.py).
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/buildtools/+/2888931260f2a32bc583f005bd807a561b2fa6af

commit 2888931260f2a32bc583f005bd807a561b2fa6af
Author: James Cook <jamescook@chromium.org>
Date: Thu Feb 15 22:30:24 2018

checkdeps: Add "noparent" support, similar to OWNERS files

Adding "noparent = True" to a DEPS file will cause that directory not
to inherit rules from its parents. This is useful for a directory like
//ash/components, where you want each component to explicitly declare
all its dependencies and not inherit from the long list in //ash/DEPS.

Bug:  812299 
Test: added to checkdeps_test.py
Change-Id: I87f384faa25c2740120f6c327dbd310db15952a3
[modify] https://crrev.com/2888931260f2a32bc583f005bd807a561b2fa6af/checkdeps/checkdeps_test.py
[modify] https://crrev.com/2888931260f2a32bc583f005bd807a561b2fa6af/checkdeps/builddeps.py
[add] https://crrev.com/2888931260f2a32bc583f005bd807a561b2fa6af/checkdeps/testdata/noparent/test.h
[add] https://crrev.com/2888931260f2a32bc583f005bd807a561b2fa6af/checkdeps/testdata/noparent/DEPS
[modify] https://crrev.com/2888931260f2a32bc583f005bd807a561b2fa6af/checkdeps/README.md
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0408501687a91fba8fb205da6c8e9c23b40eb245

commit 0408501687a91fba8fb205da6c8e9c23b40eb245
Author: James Cook <jamescook@chromium.org>
Date: Fri Feb 16 04:31:24 2018

Roll buildtools to 2888931260f2a32bc583f005bd807a561b2fa6af

Picks up this change:

Author: James Cook <jamescook@chromium.org>
Date:   Thu Feb 15 14:30:24 2018 -0800

    checkdeps: Add "noparent" support, similar to OWNERS files

    Adding "noparent = True" to a DEPS file will cause that directory not
    to inherit rules from its parents. This is useful for a directory like
    //ash/components, where you want each component to explicitly declare
    all its dependencies and not inherit from the long list in //ash/DEPS.

    Bug:  812299 
    Test: added to checkdeps_test.py

TBR=dpranke@chromium.org

Bug:  812299 
Change-Id: I59d2f18780b82cc40bbba5bcfa8a623f3023bea5
Reviewed-on: https://chromium-review.googlesource.com/923389
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537197}
[modify] https://crrev.com/0408501687a91fba8fb205da6c8e9c23b40eb245/DEPS
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e9b798a4b878d81393adaddd515523b2010ec1a

commit 9e9b798a4b878d81393adaddd515523b2010ec1a
Author: James Cook <jamescook@chromium.org>
Date: Sat Feb 17 04:13:09 2018

cros: Add noparent to //ash/components/DEPS

Components must declare all of their dependencies explicitly.

Fix quick_launch deps to comply.

Bug:  812299 
Test: buildtools/checkdeps/checkdeps.py ash
Change-Id: I2de1491e28566f2be9afe9bb1756084ef0641310
Reviewed-on: https://chromium-review.googlesource.com/924313
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537528}
[modify] https://crrev.com/9e9b798a4b878d81393adaddd515523b2010ec1a/ash/components/DEPS
[add] https://crrev.com/9e9b798a4b878d81393adaddd515523b2010ec1a/ash/components/quick_launch/DEPS

Comment 4 by jamescook@chromium.org, Feb 17 2018

Status: Fixed (was: Started)
►

Sign in to add a comment