VR: WebVR frame timeout not working |
|||||
Issue descriptionOn ToT, navigate to https://webvr.info/samples/test-slow-render.html?noFrames=true and enter VR. Expected: Timeout spinner shows up and 'X' button appears. Actual: Black screen forever. Should be bisectable. Not sure if this is broken in 65.
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10041aa35c5241ab47db91f89974db6ae9791565 commit 10041aa35c5241ab47db91f89974db6ae9791565 Author: Yash Malik <ymalik@google.com> Date: Fri Feb 16 23:39:28 2018 VR: Fix WebVR timeout UI The bug was the VrShellGl::OnVSync is called every frame (by the Android Choreographer), and we would restart the timer from the beginning. As a result it would never actually fire. In this CL, we only schedule the timeout if there's a state change from when we start sending VSyncs to the WebVR page again. Note that we only ever stop sending VSync for DLAs so that we can show the splash screen for a minimum duration, so what this effectively means is not scheduling timers in OnVSync for non-DLA WebVR presentations. Bug: 812292 Change-Id: I06c58b8902704f5d3033ded4ad7839f077e71052 Reviewed-on: https://chromium-review.googlesource.com/923547 Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#537458} [modify] https://crrev.com/10041aa35c5241ab47db91f89974db6ae9791565/chrome/browser/android/vr_shell/vr_shell_gl.cc [modify] https://crrev.com/10041aa35c5241ab47db91f89974db6ae9791565/chrome/browser/android/vr_shell/vr_shell_gl.h
,
Feb 26 2018
,
Mar 1 2018
Verified this on build 66.0.3357.0 canary.
,
Mar 13 2018
We have a test case that covers this, recently added.
,
Jul 4
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vollick@chromium.org
, Feb 14 2018Owner: ymalik@chromium.org