New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812290 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

kernel: Change noogler trap that is cros/master

Project Member Reported by evgreen@chromium.org, Feb 14 2018

Issue description

I spent an embarrassing amount of time yesterday debugging the fact that I had created a branch off of the wrong "master", and was working with an ancient 2.6 kernel. After getting help and figuring it out, I learned that I was nowhere near the first person to fall into this trap.

Does this branch need to exist? It's so old I can't imagine it's possibly used for anything. If it has to exist, can it at least be renamed to something like master_old?

I believe this trap also exists in a firmware repository, but I'm not sure which one.
 
Cc: jwer...@chromium.org
Owner: bhthompson@google.com
Bernie: I feel like this is something you'd have access to do and that you'd understand if there could possibly be any weird build system implications here.

Basically the suggestion here is to just rename cros/master to something else at:

  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/master

...maybe rename "master" to "chromeos-2.6.32"

For firmware:

  https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/master

Maybe you'd rename it to "old" or something?

---

If you're busy or you think someone else would be better suited, please yell.
Cc: reinauer@chromium.org pgeorgi@chromium.org
+Stefan and Patrick FYI, but I'm pretty sure cros/master is some old outdated branch that nobody needs anymore in coreboot and we should get rid of it (or rename it to something nobody would care about) to avoid confusing people.
coreboot's master should be renamed to something else, yes.

Probably not deleted since I don't know if those commits are still used in some ancient branch (if any they would have been branched pre-2013.04, nearly 5 years ago, and we probably didn't use coreboot back then but u-boot or Insyde)
Yeah, move not delete is right IMHO.  About the worst I can think of that would happen here is that if someone syncs to a manifest from 5 years ago that it would have trouble syncing because the old manifest would still say to sync down "master".  Of course if you could convince the sync to pass, the build would still be OK because the ebuilds would specify a certain git hash.

Luckily, though, all release branches should be fine since we create a new branch for each release.
Permission to do that seems to be limited to https://ganpati.corp.google.com/#Group_Info?name=chromeos-branch-creators@prod.google.com

Bernie, could you please rename master on chromiumos/third_party/coreboot?
The new name doesn't matter as long as it stays out of the way. I'd propose chromeos-2012 (which should be a reasonable approximation) to give it some context.
Owner: bhthompson@chromium.org

Sign in to add a comment