New issue
Advanced search Search tips

Issue 812276 link

Starred by 1 user
Status: Fixed
Owner:
proberge@chromium.org
Closed: Feb 2018
Cc:
rhalavati@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Please update network annotation for extension_manifest_fetcher

Project Member Reported by tnagel@chromium.org, Feb 14 2018 
The annotation [1] doesn't seem to explain all the request parameters. Sample request:

https://clients2.google.com/service/update2/crx?
os=cros&
arch=x64&
nacl_arch=x86-64&
prod=chromecrx&
prodchannel=&
prodversion=63.0.3239.140&
lang=en-US&
acceptformat=crx2,crx3&
  x=id=xxxxxxxxxxxxxxxxxxxxx&
  v=x.x.x&
  uc&
  brand=XXXX

[1] https://cs.chromium.org/chromium/src/extensions/browser/updater/extension_downloader.cc?dr=C&l=490
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e67d9e429f3fc0c545d0b908929fcb55342d5bf

commit 6e67d9e429f3fc0c545d0b908929fcb55342d5bf
Author: proberge <proberge@chromium.org>
Date: Mon Feb 26 18:50:54 2018

Add details to extension_manifest_fetcher's NetworkTrafficAnnotation

Bug:  812276 
Change-Id: Ib5581eef0c5412c9ef9c157cf321efc964ace22f
Reviewed-on: https://chromium-review.googlesource.com/927343
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539213}
[modify] https://crrev.com/6e67d9e429f3fc0c545d0b908929fcb55342d5bf/extensions/browser/updater/extension_downloader.cc
[modify] https://crrev.com/6e67d9e429f3fc0c545d0b908929fcb55342d5bf/tools/traffic_annotation/summary/annotations.xml

Comment 2 by proberge@chromium.org, Feb 26 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment