New issue
Advanced search Search tips

Issue 812253 link

Starred by 1 user
Status: Fixed
Owner:
eugene...@chromium.org
Closed: Nov 27
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocking:
issue 738020



Sign in to add a comment

Add inttest for restore_session and placeholder URLs

Project Member Reported by danyao@chromium.org, Feb 14 2018 
Add coverage to navigation_and_load_callbacks_inttest for https://chromium-review.googlesource.com/c/chromium/src/+/917524.

Comment 1 by danyao@chromium.org, Sep 14

Owner: eugene...@chromium.org
Status: Assigned (was: Available)

Comment 2 by eugene...@chromium.org, Sep 15

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ef16b01f40390d9242f1a055b7281e7a4788b3c

commit 8ef16b01f40390d9242f1a055b7281e7a4788b3c
Author: Eugene But <eugenebut@google.com>
Date: Wed Sep 19 00:06:21 2018

Add WebStateObserverTest.RestoreSession test.

This test verifies that no WebStateObserver callbacks are called during
restoration.

Removed superfluous DCHECK from GetNavigationItemImplAtIndex().

Bug: 877671,  812253 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ic4db92fec8204fd8fe92da9a19ea6f16cc3a32a3
Reviewed-on: https://chromium-review.googlesource.com/1189124
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592275}
[modify] https://crrev.com/8ef16b01f40390d9242f1a055b7281e7a4788b3c/ios/web/navigation/wk_based_navigation_manager_impl.mm
[modify] https://crrev.com/8ef16b01f40390d9242f1a055b7281e7a4788b3c/ios/web/web_state/web_state_observer_inttest.mm

Comment 4 by eugene...@chromium.org, Nov 27

Status: Fixed (was: Started)
►

Sign in to add a comment