Looks like we have a typo on the enum value and it's getting set to an unexpected value, hitting a NOTREACHED(). (https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java?rcl=4dac99aed34f9e3b7c3b692e4925054b0b2e5e6b&l=57)
Eh, not worth merge to 65, we've got some other bugs here I need to fix at the same time.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c49a9fd154526aada8b0b1387232207f3a98737d commit c49a9fd154526aada8b0b1387232207f3a98737d Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Feb 22 15:05:58 2018 VR: Show generic error message by default before showing DOFF. When the user encounters an unsupported action, like starting a non-VR activity while in VR, show an in-Chrome error message first, telling them that the action they're taking isn't supported in VR before showing them the DOFF (device off) flow. Also fixes the Incognito NTP using the wrong error message when requesting doff (unhandled code point is for missing unicode glyphs). Bug: 812251 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2e75917afaa7b1f43f51c5a6773de97d28a6a6d1 Reviewed-on: https://chromium-review.googlesource.com/930003 Reviewed-by: Ian Vollick <vollick@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#538436} [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/TestVrShellDelegate.java [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTransitionTest.java [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/browser/android/vr_shell/vr_shell.h [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/browser/android/vr_shell/vr_shell_gl.cc [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/browser/android/vr_shell/vr_shell_gl.h [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/browser/vr/model/modal_prompt_type.cc [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/browser/vr/model/modal_prompt_type.h [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/browser/vr/ui.cc [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/browser/vr/ui.h [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/c49a9fd154526aada8b0b1387232207f3a98737d/chrome/browser/vr/ui_unsupported_mode.h
Verified in build 66.0.3359.17 New issues found: Dialog blends with content. Dialog has Exit VR and OK. The OK should probably be Cancel.
Comment 1 by mthiesse@chromium.org
, Feb 14 2018