New issue
Advanced search Search tips

Issue 812243 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Implement support for Graphics ARIA roles

Reported by joanmari...@gmail.com, Feb 14 2018

Issue description

There are three Graphics ARIA roles, which can be found here:
https://rawgit.com/w3c/graphics-aria/master/#role_definitions

The platform mappings can be found here:
https://rawgit.com/w3c/graphics-aam/master/#mapping_role_table

As you'll see from the latter, the only support needed is to expose the role mappings. It should therefore (hopefully) be a quick implementation.

Thanks in advance!
 
Components: UI>Accessibility
Components: -UI>Accessibility Blink>Accessibility
Labels: Hotlist-GoodFirstBug
Owner: aleventhal@chromium.org
Status: Assigned (was: Unconfirmed)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/770b43709b7a1d31faf5a456423e84c727192635

commit 770b43709b7a1d31faf5a456423e84c727192635
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Fri May 11 20:43:50 2018

Follow all AAM role mappings: DPUB, Graphics, CORE, HTML

Fixes incorrect platform role mappings for IA2 and ATK.

Adds the following new roles to Chrome:
New landmark roles: docAcknowledgments, docAfterword, docAppendix, docBibliography,
docChapter, docConclusion, docCredits, docEndnotes, docEpilogue, docErrata, docForeword,
docGlossary, docIndex, docIntroduction, docPageList, docPart, docPreface, docPrologue, docToc
Acts like a heading: docSubtitle
Acts like a note: docTip, docNotice, docFootnote
Acts like a section/region: docAbstract, docColophon, docCredit, docDedication, docEpigraph,
docExample, docQna
Acts like an image: docCover, graphicsSymbol
Acts like a link: docBackLink, docBiblioRef, docNoteRef, docGlossRef
Acts like a list item: docBiblioEntry, docEndnote, docFootnote
Acts like a separator: docPageBreak
Acts like a document: graphicsDocument
Acts like a pane: graphicsObject

Note: these are the internal names. In the role attribute used in HTML, the role names are lowercase and
hyphenated with "doc-" or "graphics-" prefixes, e.g. “doc-endnotes”.

More DPub info:
Spec: https://www.w3.org/TR/dpub-aria-1.0/
Platform implementation notes: https://www.w3.org/TR/dpub-aam-1.0/#mapping_role_table

More Graphics ARIA info:
Spec: https://www.w3.org/TR/graphics-aria-1.0/
Platform implementation notes: https://rawgit.com/w3c/graphics-aam/master/#mapping_role_table

NOTRY=true

Bug:  812243 ,  839871 
TBR: jcivelli@chromium.org,stevenjb@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If2d5ec8aca551cb1fb611cc3614f4f4617f958a9
Reviewed-on: https://chromium-review.googlesource.com/1044347
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558009}
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/chromecast/common/extensions_api/automation.idl
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/app/strings/content_strings.grd
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/browser/accessibility/accessibility_tree_formatter_utils_win.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/browser/accessibility/browser_accessibility.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/browser/accessibility/one_shot_accessibility_tree_search.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/renderer/accessibility/blink_ax_enum_conversion.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/shell/test_runner/web_ax_object_proxy.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/aria-complementary-expected-win.txt
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/aria-contentinfo-expected-win.txt
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/aria-main-expected-win.txt
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/aria-navigation-expected-win.txt
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/aria-region-expected-win.txt
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/aria-search-expected-win.txt
[add] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/dpub-roles-expected-android.txt
[add] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/dpub-roles-expected-auralinux.txt
[add] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/dpub-roles-expected-blink.txt
[add] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/dpub-roles-expected-mac.txt
[add] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/dpub-roles-expected-win.txt
[add] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/dpub-roles.html
[add] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/graphics-roles-expected-android.txt
[add] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/graphics-roles-expected-auralinux.txt
[add] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/graphics-roles-expected-blink.txt
[add] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/graphics-roles-expected-mac.txt
[add] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/graphics-roles-expected-win.txt
[add] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/aria/graphics-roles.html
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/css/font-family-expected-win.txt
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/html/address-expected-win.txt
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/html/aside-expected-win.txt
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/html/footer-inside-other-section-expected-win.txt
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/html/header-inside-other-section-expected-win.txt
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/html/landmark-expected-win.txt
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/html/main-expected-win.txt
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/content/test/data/accessibility/html/navigation-expected-win.txt
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/third_party/blink/public/web/web_ax_enums.h
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/third_party/blink/renderer/modules/accessibility/ax_enums.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/third_party/blink/renderer/modules/accessibility/ax_enums.h
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/third_party/blink/renderer/modules/accessibility/ax_object.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/third_party/iaccessible2/README.chromium
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/third_party/iaccessible2/ia2_api_all.idl
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/third_party/win_build_output/midl/third_party/iaccessible2/x64/ia2_api_all.h
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/third_party/win_build_output/midl/third_party/iaccessible2/x64/ia2_api_all.tlb
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/third_party/win_build_output/midl/third_party/iaccessible2/x86/ia2_api_all.h
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/third_party/win_build_output/midl/third_party/iaccessible2/x86/ia2_api_all.tlb
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/ui/accessibility/ax_assistant_structure.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/ui/accessibility/ax_assistant_structure.h
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/ui/accessibility/ax_enum_util.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/ui/accessibility/ax_enums.mojom
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/ui/accessibility/ax_role_properties.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/ui/accessibility/ax_role_properties.h
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/ui/accessibility/platform/ax_platform_node_base.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/ui/accessibility/platform/ax_platform_node_base.h
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/ui/accessibility/platform/ax_platform_node_mac.mm
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/770b43709b7a1d31faf5a456423e84c727192635/ui/accessibility/platform/ax_platform_node_win.h

Status: Fixed (was: Started)

Sign in to add a comment