New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812232 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Adaptive Toolbar: Adapt the height of the WKWebView when the bottom toolbar is scrolled

Project Member Reported by gambard@chromium.org, Feb 14 2018

Issue description

The bottom toolbar should add a padding to the WKWebView, as the top toolbar is doing. The padding is changed during fullscreen.
 
Cc: gambard@chromium.org pschaffner@chromium.org mard...@chromium.org
 Issue 816799  has been merged into this issue.
Cc: ghendel@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01cf90816f49052145ce7efa7593df7e04cbeecb

commit 01cf90816f49052145ce7efa7593df7e04cbeecb
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Feb 28 09:21:58 2018

Update WebView's bottom padding for the toolbar

This CL updates the bottom padding of the WebView to reflect the toolbar
presence at the bottom of the screen. It allows the WebView to resize
such as its frame is only the visible portion of the page.
Its frame is updated to follow the updates of the toolbar during
fullscreen, in the same way as it is done for the top toolbar.

Bug:  812232 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib52f47664399d23857115a4b1c01961803d038af
Reviewed-on: https://chromium-review.googlesource.com/931466
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539764}
[modify] https://crrev.com/01cf90816f49052145ce7efa7593df7e04cbeecb/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/01cf90816f49052145ce7efa7593df7e04cbeecb/ios/chrome/browser/ui/fullscreen/fullscreen_content_adjustment_util.mm
[modify] https://crrev.com/01cf90816f49052145ce7efa7593df7e04cbeecb/ios/chrome/browser/ui/fullscreen/fullscreen_web_state_observer.mm
[modify] https://crrev.com/01cf90816f49052145ce7efa7593df7e04cbeecb/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
[modify] https://crrev.com/01cf90816f49052145ce7efa7593df7e04cbeecb/ios/web/BUILD.gn
[modify] https://crrev.com/01cf90816f49052145ce7efa7593df7e04cbeecb/ios/web/public/web_state/ui/crw_content_view.h
[modify] https://crrev.com/01cf90816f49052145ce7efa7593df7e04cbeecb/ios/web/public/web_state/ui/crw_web_view_proxy.h
[modify] https://crrev.com/01cf90816f49052145ce7efa7593df7e04cbeecb/ios/web/web_state/ui/crw_generic_content_view.mm
[modify] https://crrev.com/01cf90816f49052145ce7efa7593df7e04cbeecb/ios/web/web_state/ui/crw_web_view_content_view.mm
[add] https://crrev.com/01cf90816f49052145ce7efa7593df7e04cbeecb/ios/web/web_state/ui/crw_web_view_content_view_unittest.mm
[modify] https://crrev.com/01cf90816f49052145ce7efa7593df7e04cbeecb/ios/web/web_state/ui/crw_web_view_proxy_impl.mm
[add] https://crrev.com/01cf90816f49052145ce7efa7593df7e04cbeecb/ios/web/web_state/ui/crw_web_view_proxy_impl_unittest.mm

Status: Fixed (was: Assigned)
NextAction: 2018-02-28
The NextAction date has arrived: 2018-02-28

Comment 8 by cmasso@google.com, Feb 28 2018

NextAction: ----

Sign in to add a comment