New issue
Advanced search Search tips

Issue 812222 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Take advantages of lock annotations in workers

Project Member Reported by nhiroki@chromium.org, Feb 14 2018

Issue description

Lock annotations mechanism was imported from Abseil in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/885506

This mechanism provides Clang's built-in support for static lock analysis. This would be really useful for workers, especially WorkerThread.
 
Owner: nhiroki@chromium.org
Status: Started (was: Available)
CL: https://chromium-review.googlesource.com/c/chromium/src/+/919321
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45a128052104e8e61609012a964db65aa59034c7

commit 45a128052104e8e61609012a964db65aa59034c7
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Feb 16 13:42:06 2018

Worker: Use lock annotations in WorkerThread

Lock annotations mechanism was ported from Abseil in this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/885506

This mechanism provides Clang's built-in support for static lock analysis. This
would be really useful for workers, especially WorkerThread.

Bug:  812222 
Change-Id: I88d4e24ea8a2d93edf126d61148d4c7aec060901
Reviewed-on: https://chromium-review.googlesource.com/919321
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537294}
[modify] https://crrev.com/45a128052104e8e61609012a964db65aa59034c7/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/45a128052104e8e61609012a964db65aa59034c7/third_party/WebKit/Source/core/workers/WorkerThread.h
[modify] https://crrev.com/45a128052104e8e61609012a964db65aa59034c7/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/335a2917f85c773ea311007abd0cd19309a5fb5e

commit 335a2917f85c773ea311007abd0cd19309a5fb5e
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Feb 23 08:55:44 2018

Worker: Use lock annotations in ParentFrameTaskRunners

This CL adds lock annotations to ParentFrameTaskRunners for making sure that the
lock is correctly acquired.

Bug:  812222 
Change-Id: Iafaf0719b9b76182436a3c26d0e92f7aae8ad79c
Reviewed-on: https://chromium-review.googlesource.com/934010
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538731}
[modify] https://crrev.com/335a2917f85c773ea311007abd0cd19309a5fb5e/third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.cpp
[modify] https://crrev.com/335a2917f85c773ea311007abd0cd19309a5fb5e/third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.h

Labels: M-66
Status: Fixed (was: Started)

Sign in to add a comment