New issue
Advanced search Search tips

Issue 812219 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature
Launch-Accessibility: NA
Launch-Exp-Leadership: NA
Launch-Leadership: NA
Launch-Legal: NA
Launch-M-Target: 70-Dev , 70-Beta , 70-Stable-Exp , 70-Stable
Launch-Privacy: NA
Launch-Security: NA
Launch-Test: NA
Launch-UI: NA
Rollout-Type: Finch

Blocked on:
issue 803123



Sign in to add a comment

Expand coverage of Chrome's ad tagging

Project Member Reported by rsch...@chromium.org, Feb 14 2018

Issue description

Technical feature description: Expand coverage of Chrome's ad tagging to include more types of ads outside Google Ads, tag ads outside frames, and tag ads earlier in the loading pipeline. This will enable us to treat ads differently in the future, but no such changes are included in this launch.

Eng owner: jkarlin@

Design doc (send to chrome-design-docs@): https://docs.google.com/document/d/1ELsbnZiLK3VYxAJkwHYnfi6F32F2BqRVkPPR4JH7flM/edit#heading=h.5ugemo7p04z9

Metrics: TBD

If you need help defining metrics or using Finch, you should ask for a
Metrics ambassador. Go to https://goto.google.com/chrome-metrics-ambassador
to get a Metrics ambassador and CC them on this bug.

 
Cc: shivanisha@chromium.org
Blockedon: 803123
Project Member

Comment 3 by sheriffbot@chromium.org, May 15 2018

This launch bug has not been modified in the last 90 days and has no milestone label. Please take a look and add appropriate milestone label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by amin...@google.com, May 16 2018

Labels: Launch-Exp-Leadership-NA
Updating launch bugs to convert to new launch process in go/newChromeFeature.  Automatically setting Launch-Exp-Leadership-NA since this appears to be a legacy technical / simple launch (all existing cross-functional bits are set to NA).  Note that in the new process, no review / approval for technical / simple launches is required (though please be sure you are confident there is no cross-functional impact here).  Contact amineer@ with any questions or concerns.

Comment 5 by amin...@google.com, May 16 2018

Labels: Launch-Leadership-NA
Updating launch bugs to convert to new launch process in go/newChromeFeature.  Automatically setting Launch-Leadership-NA since this appears to be a legacy technical / simple launch (all existing cross-functional bits are set to NA).  Note that in the new process, no review / approval for technical / simple launches is required (though please be sure you are confident there is no cross-functional impact here).  Contact amineer@ with any questions or concerns.
Labels: Launch-M-Target-69-Dev Launch-M-Target-69-Beta Launch-M-Target-69-Stable-Exp Launch-M-Target-69-Stable
Labels: -Launch-M-Target-69-Dev -Launch-M-Target-69-Beta -Launch-M-Target-69-Stable-Exp Launch-M-Target-68-Dev Launch-M-Target-68-Beta Launch-M-Target-68-Stable-Exp
Cc: -jkarlin@chromium.org
Owner: jkarlin@chromium.org
Labels: -Type-Launch -Product-Review-NA -Launch-M-Target-68-Dev -Launch-M-Target-68-Beta -Launch-M-Target-68-Stable-Exp -Launch-M-Target-69-Stable Launch-M-Target-70-Dev Launch-M-Target-70-Beta Launch-M-Target-70-Stable-Exp Launch-M-Target-70-Stable Rollout-Type-Finch Type-Feature
Changing to regular feature as this is a simple feature launch.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/158abe187c8a8a5eda5edf305ea0ce2e0bbec56b

commit 158abe187c8a8a5eda5edf305ea0ce2e0bbec56b
Author: Josh Karlin <jkarlin@chromium.org>
Date: Thu Dec 13 21:20:24 2018

[AdTagging] Enable AdTagging by default

AdTagging is now being dependend upon by OOM Intervention as of
M71 via field trial. Enabling by default in M73 and planning to
merge to M72.

Bug: 812219
Change-Id: I309a40f03fd9672005a4b6b367aa19c9fba130e0
Reviewed-on: https://chromium-review.googlesource.com/c/1358691
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616436}
[modify] https://crrev.com/158abe187c8a8a5eda5edf305ea0ce2e0bbec56b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
[modify] https://crrev.com/158abe187c8a8a5eda5edf305ea0ce2e0bbec56b/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
[modify] https://crrev.com/158abe187c8a8a5eda5edf305ea0ce2e0bbec56b/components/subresource_filter/core/common/common_features.cc

Labels: Pri-2
Setting defect without priority to Pri-2.
Setting defect without priority to Pri-2.

Sign in to add a comment