Skia shader compile error: "WebRtcCaptureFromElementBrowserTest.CaptureFromOpaqueCanvas2DHandlesContextLoss" is flaky |
||||||||||||||
Issue description"WebRtcCaptureFromElementBrowserTest.CaptureFromOpaqueCanvas2DHandlesContextLoss" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 7 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWgsSBUZsYWtlIk9XZWJSdGNDYXB0dXJlRnJvbUVsZW1lbnRCcm93c2VyVGVzdC5DYXB0dXJlRnJvbU9wYXF1ZUNhbnZhczJESGFuZGxlc0NvbnRleHRMb3NzDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Feb 14 2018
,
Feb 14 2018
,
Feb 17 2018
Detected 8 new flakes for test/step "WebRtcCaptureFromElementBrowserTest.CaptureFromOpaqueCanvas2DHandlesContextLoss". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWgsSBUZsYWtlIk9XZWJSdGNDYXB0dXJlRnJvbUVsZW1lbnRCcm93c2VyVGVzdC5DYXB0dXJlRnJvbU9wYXF1ZUNhbnZhczJESGFuZGxlc0NvbnRleHRMb3NzDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Feb 20 2018
Detected 3 new flakes for test/step "WebRtcCaptureFromElementBrowserTest.CaptureFromOpaqueCanvas2DHandlesContextLoss". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWgsSBUZsYWtlIk9XZWJSdGNDYXB0dXJlRnJvbUVsZW1lbnRCcm93c2VyVGVzdC5DYXB0dXJlRnJvbU9wYXF1ZUNhbnZhczJESGFuZGxlc0NvbnRleHRMb3NzDA. This message was posted automatically by the chromium-try-flakes app.
,
Feb 21 2018
Detected 5 new flakes for test/step "WebRtcCaptureFromElementBrowserTest.CaptureFromOpaqueCanvas2DHandlesContextLoss". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWgsSBUZsYWtlIk9XZWJSdGNDYXB0dXJlRnJvbUVsZW1lbnRCcm93c2VyVGVzdC5DYXB0dXJlRnJvbU9wYXF1ZUNhbnZhczJESGFuZGxlc0NvbnRleHRMb3NzDA. This message was posted automatically by the chromium-try-flakes app.
,
Feb 21 2018
I pasted the error below. It points to GLSL compilation that is specifically happening on Mac bots. Can somebody from skia team take a look as well? I will disable the test in the meantime. [ RUN ] WebRtcCaptureFromElementBrowserTest.CaptureFromOpaqueCanvas2DHandlesContextLoss DevTools listening on ws://127.0.0.1:58511/devtools/browser/fa6cba4b-3cdb-489d-b9bc-cc7f54a0392c [11645:775:0221/040129.296317:INFO:CONSOLE(102)] "URL.createObjectURL with media streams is deprecated and will be removed in M68, around July 2018. Please use HTMLMediaElement.srcObject instead. See https://www.chromestatus.com/features/5618491470118912 for more details.", source: http://127.0.0.1:58512/media/canvas_capture_color.html (102) [11645:775:0221/040129.300851:INFO:CONSOLE(22)] "Waiting for", source: http://127.0.0.1:58512/media/mediarecorder_test_utils.js (22) [11646:775:0221/040129.358174:ERROR:gles2_cmd_decoder.cc(5632)] Error: 5 for Command kLoseContextCHROMIUM [11646:775:0221/040129.358308:ERROR:gpu_channel_manager.cc(200)] Exiting GPU process because some drivers cannot recover from problems. [11646:775:0221/040129.358346:FATAL:gl_context.cc(226)] Check failed: false. 0 Content Shell Framework 0x000000010f56917c base::debug::StackTrace::StackTrace(unsigned long) + 28 1 Content Shell Framework 0x000000010f58e18f logging::LogMessage::~LogMessage() + 223 2 Content Shell Framework 0x00000001102b8092 gl::GLContext::LosesAllContextsOnContextLost() + 98 3 Content Shell Framework 0x0000000110bc3174 gpu::CommandBufferStub::CheckContextLost() + 164 4 Content Shell Framework 0x0000000110bc33f9 gpu::CommandBufferStub::OnParseError() + 345 5 Content Shell Framework 0x00000001102e0c92 gpu::CommandBufferService::Flush(int, gpu::AsyncAPIInterface*) + 738 6 Content Shell Framework 0x0000000110bc0666 gpu::CommandBufferStub::OnAsyncFlush(int, unsigned int, bool) + 342 7 Content Shell Framework 0x0000000110bc042c bool IPC::MessageT<GpuCommandBufferMsg_AsyncFlush_Meta, std::__1::tuple<int, unsigned int, bool>, void>::Dispatch<gpu::CommandBufferStub, gpu::CommandBufferStub, void, void (gpu::CommandBufferStub::*)(int, unsigned int, bool)>(IPC::Message const*, gpu::CommandBufferStub*, gpu::CommandBufferStub*, void*, void (gpu::CommandBufferStub::*)(int, unsigned int, bool)) + 124 8 Content Shell Framework 0x0000000110bbeeb5 gpu::CommandBufferStub::OnMessageReceived(IPC::Message const&) + 1301 9 Content Shell Framework 0x000000010f9c80c2 IPC::MessageRouter::RouteMessage(IPC::Message const&) + 146 10 Content Shell Framework 0x0000000110bcc541 gpu::GpuChannel::HandleMessageHelper(IPC::Message const&) + 161 11 Content Shell Framework 0x0000000110bc9fbe gpu::GpuChannel::HandleMessage(IPC::Message const&) + 638 12 Content Shell Framework 0x0000000110bcd55e base::internal::Invoker<base::internal::BindState<void (gpu::GpuChannel::*)(IPC::Message const&), base::WeakPtr<gpu::GpuChannel>, IPC::MessageT<GpuCommandBufferMsg_AsyncFlush_Meta, std::__1::tuple<int, unsigned int, bool>, void> >, void ()>::RunOnce(base::internal::BindStateBase*) + 190 13 Content Shell Framework 0x00000001102e80e3 gpu::Scheduler::RunNextTask() + 1203 14 Content Shell Framework 0x00000001102ea977 base::internal::Invoker<base::internal::BindState<void (gpu::Scheduler::*)(), base::WeakPtr<gpu::Scheduler> >, void ()>::Run(base::internal::BindStateBase*) + 183 15 Content Shell Framework 0x000000010f569af5 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 261 16 Content Shell Framework 0x000000010f5a3c39 base::internal::IncomingTaskQueue::RunTask(base::PendingTask*) + 121 17 Content Shell Framework 0x000000010f5a84ea base::MessageLoop::RunTask(base::PendingTask*) + 618 18 Content Shell Framework 0x000000010f5a88ca base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 186 19 Content Shell Framework 0x000000010f5a8b3c base::MessageLoop::DoWork() + 572 20 Content Shell Framework 0x000000010f5ac2ca base::MessagePumpCFRunLoopBase::RunWork() + 42 21 Content Shell Framework 0x000000010f59051a base::mac::CallWithEHFrame(void () block_pointer) + 10 22 Content Shell Framework 0x000000010f5abbaf base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63 23 CoreFoundation 0x00007fff45b44721 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 24 CoreFoundation 0x00007fff45bfe0ac __CFRunLoopDoSource0 + 108 25 CoreFoundation 0x00007fff45b27260 __CFRunLoopDoSources0 + 208 26 CoreFoundation 0x00007fff45b266dd __CFRunLoopRun + 1293 27 CoreFoundation 0x00007fff45b25f43 CFRunLoopRunSpecific + 483 28 Foundation 0x00007fff47bf7c16 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277 29 Content Shell Framework 0x000000010f5acb2e base::MessagePumpNSRunLoop::DoRun(base::MessagePump::Delegate*) + 142 30 Content Shell Framework 0x000000010f5ab5fe base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110 31 Content Shell Framework 0x000000010f5a7df9 base::MessageLoop::Run(bool) + 169 32 Content Shell Framework 0x000000010f5e0099 base::RunLoop::Run() + 249 33 Content Shell Framework 0x0000000111556cf1 content::GpuMain(content::MainFunctionParams const&) + 1425 34 Content Shell Framework 0x000000010d985794 content::ContentMainRunnerImpl::Run() + 564 35 Content Shell Framework 0x0000000110fa12eb service_manager::Main(service_manager::MainParams const&) + 2475 36 Content Shell Framework 0x000000010d984b34 content::ContentMain(content::ContentMainParams const&) + 68 37 Content Shell Framework 0x000000010cba7c8e ContentMain + 78 38 libdyld.dylib 0x00007fff6d439115 start + 1 39 ??? 0x000000000000000a 0x0 + 10 [11647:23811:0221/040129.500715:INFO:GrGLShaderStringBuilder.cpp(143)] GLSL compilation error ---------------------- [11647:23811:0221/040129.500798:INFO:GrGLShaderStringBuilder.cpp(47)] GLSL: [11647:23811:0221/040129.500819:INFO:GrGLShaderStringBuilder.cpp(47)] 1 #version 100 [11647:23811:0221/040129.500832:INFO:GrGLShaderStringBuilder.cpp(47)] 2 [11647:23811:0221/040129.500843:INFO:GrGLShaderStringBuilder.cpp(47)] 3 precision mediump float; [11647:23811:0221/040129.500856:INFO:GrGLShaderStringBuilder.cpp(47)] 4 uniform lowp sampler2D uTextureSampler_0_Stage0; [11647:23811:0221/040129.500868:INFO:GrGLShaderStringBuilder.cpp(47)] 5 varying mediump vec4 vcolor_Stage0; [11647:23811:0221/040129.500879:INFO:GrGLShaderStringBuilder.cpp(47)] 6 varying highp vec2 vtextureCoords_Stage0; [11647:23811:0221/040129.500891:INFO:GrGLShaderStringBuilder.cpp(47)] 7 varying highp vec4 vaaDists_Stage0; [11647:23811:0221/040129.500903:INFO:GrGLShaderStringBuilder.cpp(47)] 8 void main() { [11647:23811:0221/040129.500915:INFO:GrGLShaderStringBuilder.cpp(47)] 9 mediump vec4 outputColor_Stage0; [11647:23811:0221/040129.500926:INFO:GrGLShaderStringBuilder.cpp(47)] 10 mediump vec4 outputCoverage_Stage0; [11647:23811:0221/040129.500938:INFO:GrGLShaderStringBuilder.cpp(47)] 11 { [11647:23811:0221/040129.500950:INFO:GrGLShaderStringBuilder.cpp(47)] 12 outputColor_Stage0 = vcolor_Stage0; [11647:23811:0221/040129.500964:INFO:GrGLShaderStringBuilder.cpp(47)] 13 highp vec2 texCoord; [11647:23811:0221/040129.500975:INFO:GrGLShaderStringBuilder.cpp(47)] 14 texCoord = vtextureCoords_Stage0; [11647:23811:0221/040129.500987:INFO:GrGLShaderStringBuilder.cpp(47)] 15 outputColor_Stage0 = outputColor_Stage0 * texture2D(uTextureSampler_0_Stage0, texCoord); [11647:23811:0221/040129.500999:INFO:GrGLShaderStringBuilder.cpp(47)] 16 highp float mindist = min(min(vaaDists_Stage0.x, vaaDists_Stage0.y), min(vaaDists_Stage0.z, vaaDists_Stage0.w)); [11647:23811:0221/040129.501018:INFO:GrGLShaderStringBuilder.cpp(47)] 17 outputCoverage_Stage0 = vec4(clamp(mindist, 0.0, 1.0)); [11647:23811:0221/040129.501030:INFO:GrGLShaderStringBuilder.cpp(47)] 18 } [11647:23811:0221/040129.501042:INFO:GrGLShaderStringBuilder.cpp(47)] 19 { [11647:23811:0221/040129.501053:INFO:GrGLShaderStringBuilder.cpp(47)] 20 gl_FragColor = outputColor_Stage0 * outputCoverage_Stage0; [11647:23811:0221/040129.501065:INFO:GrGLShaderStringBuilder.cpp(47)] 21 } [11647:23811:0221/040129.501076:INFO:GrGLShaderStringBuilder.cpp(47)] 22 } [11647:23811:0221/040129.501087:INFO:GrGLShaderStringBuilder.cpp(47)] 23 [11647:23811:0221/040129.501104:INFO:GrGLShaderStringBuilder.cpp(155)] ../../third_party/skia/src/gpu/gl/builders/GrGLShaderStringBuilder.cpp:155: fatal error: "GLSL compilation failed!" Received signal 6 [11645:775:0221/040129.505654:INFO:CONSOLE(22)] "Waiting for", source: http://127.0.0.1:58512/media/mediarecorder_test_utils.js (22) 0 Content Shell Framework 0x00000001134e117c base::debug::StackTrace::StackTrace(unsigned long) + 28 1 Content Shell Framework 0x00000001134e0fb1 base::debug::(anonymous namespace)::StackDumpSignalHandler(int, __siginfo*, void*) + 2401 2 libsystem_platform.dylib 0x00007fff6d6baf5a _sigtramp + 26 3 ??? 0x0000000000000000 0x0 + 0 4 libsystem_c.dylib 0x00007fff6d4e5312 abort + 127 5 Content Shell Framework 0x0000000113e12ce9 sk_abort_no_print() + 9 6 Content Shell Framework 0x0000000113fcb35d GrGLCompileAndAttachShader(GrGLContext const&, unsigned int, unsigned int, char const*, int, GrGpu::Stats*, SkSL::Program::Settings const&) + 1677 7 Content Shell Framework 0x0000000113fc9020 GrGLProgramBuilder::compileAndAttachShaders(char const*, int, unsigned int, unsigned int, SkTDArray<unsigned int>*, SkSL::Program::Settings const&, SkSL::Program::Inputs const&) + 64 8 Content Shell Framework 0x0000000113fc8516 GrGLProgramBuilder::finalize() + 2006 9 Content Shell Framework 0x0000000113fc7cd0 GrGLProgramBuilder::CreateProgram(GrPipeline const&, GrPrimitiveProcessor const&, GrProgramDesc*, GrGLGpu*) + 528 10 Content Shell Framework 0x0000000113fb294f GrGLGpu::ProgramCache::refProgram(GrGLGpu const*, GrPipeline const&, GrPrimitiveProcessor const&, bool) + 703 11 Content Shell Framework 0x0000000113fa0141 GrGLGpu::flushGLState(GrPipeline const&, GrPrimitiveProcessor const&, bool) + 49 12 Content Shell Framework 0x0000000113fa621f GrGLGpu::draw(GrPipeline const&, GrPrimitiveProcessor const&, GrMesh const*, GrPipeline::DynamicState const*, int) + 143 13 Content Shell Framework 0x0000000113e87919 GrGpuRTCommandBuffer::draw(GrPipeline const&, GrPrimitiveProcessor const&, GrMesh const*, GrPipeline::DynamicState const*, int, SkRect const&) + 633 14 Content Shell Framework 0x0000000113e8b284 GrOpFlushState::executeDrawsAndUploadsForMeshDrawOp(unsigned int, SkRect const&) + 548 15 Content Shell Framework 0x0000000113eb3d98 GrRenderTargetOpList::onExecute(GrOpFlushState*) + 984 16 Content Shell Framework 0x0000000113e7b9ad GrDrawingManager::executeOpLists(int, int, GrOpFlushState*) + 1661 17 Content Shell Framework 0x0000000113e7af8b GrDrawingManager::internalFlush(GrSurfaceProxy*, GrResourceCache::FlushType, int, GrBackendSemaphore*) + 2331 18 Content Shell Framework 0x0000000113e7bdde GrDrawingManager::prepareSurfaceForExternalIO(GrSurfaceProxy*, int, GrBackendSemaphore*) + 158 19 Content Shell Framework 0x0000000113e750db GrContextPriv::prepareSurfaceForExternalIO(GrSurfaceProxy*) + 235 20 Content Shell Framework 0x0000000113fe977d SkImage_Gpu::onGetTextureHandle(bool, GrSurfaceOrigin*) const + 365 21 Content Shell Framework 0x000000011480fc92 cc::GpuImageDecodeCache::RunPendingContextThreadOperations() + 402 22 Content Shell Framework 0x000000011480fa1e cc::GpuImageDecodeCache::DrawWithImageFinished(cc::DrawImage const&, cc::DecodedDrawImage const&) + 174 23 Content Shell Framework 0x00000001147c9262 base::internal::Invoker<base::internal::BindState<void (*)(cc::DrawImage, cc::ImageDecodeCache*, cc::DecodedDrawImage), cc::DrawImage, cc::ImageDecodeCache*, cc::DecodedDrawImage>, void ()>::RunOnce(base::internal::BindStateBase*) + 82 24 Content Shell Framework 0x000000011419c4e6 cc::ImageProvider::ScopedDecodedDrawImage::DestroyDecode() + 118 25 Content Shell Framework 0x000000011419c53e cc::ImageProvider::ScopedDecodedDrawImage::~ScopedDecodedDrawImage() + 14 26 Content Shell Framework 0x00000001141b0b4b cc::DrawImageRectOp::RasterWithFlags(cc::DrawImageRectOp const*, cc::PaintFlags const*, SkCanvas*, cc::PlaybackParams const&) + 779 27 Content Shell Framework 0x00000001141b780a _ZN2cc4$_368__invokeEPKNS_7PaintOpEPKNS_10PaintFlagsEP8SkCanvasRKNS_14PlaybackParamsE + 122 28 Content Shell Framework 0x00000001141b5214 cc::PaintOpBuffer::Playback(SkCanvas*, cc::PlaybackParams const&, std::__1::vector<unsigned long, std::__1::allocator<unsigned long> > const*) const + 676 29 Content Shell Framework 0x00000001141b518d cc::PaintOpBuffer::Playback(SkCanvas*, cc::PlaybackParams const&, std::__1::vector<unsigned long, std::__1::allocator<unsigned long> > const*) const + 541 30 Content Shell Framework 0x00000001141956e7 cc::DisplayItemList::Raster(SkCanvas*, cc::ImageProvider*) const + 295 31 Content Shell Framework 0x00000001147ca889 cc::RasterSource::PlaybackToCanvas(SkCanvas*, cc::ImageProvider*) const + 217 32 Content Shell Framework 0x00000001147ca77d cc::RasterSource::PlaybackToCanvas(SkCanvas*, gfx::ColorSpace const&, gfx::Size const&, gfx::Rect const&, gfx::Rect const&, gfx::AxisTransform2d const&, cc::RasterSource::PlaybackSettings const&) const + 829 33 Content Shell Framework 0x00000001147c5ca0 cc::GpuRasterBufferProvider::PlaybackOnWorkerThread(gpu::Mailbox const&, unsigned int, bool, bool, gpu::SyncToken const&, gfx::Size const&, viz::ResourceFormat, gfx::ColorSpace const&, bool, cc::RasterSource const*, gfx::Rect const&, gfx::Rect const&, unsigned long long, gfx::AxisTransform2d const&, cc::RasterSource::PlaybackSettings const&) + 1376 34 Content Shell Framework 0x00000001147c563f cc::GpuRasterBufferProvider::RasterBufferImpl::Playback(cc::RasterSource const*, gfx::Rect const&, gfx::Rect const&, unsigned long long, gfx::AxisTransform2d const&, cc::RasterSource::PlaybackSettings const&) + 255 35 Content Shell Framework 0x000000011483a6e0 cc::(anonymous namespace)::RasterTaskImpl::RunOnWorkerThread() + 416 36 Content Shell Framework 0x0000000117592a61 content::CategorizedWorkerPool::RunTaskInCategoryWithLockAcquired(cc::TaskCategory) + 209 37 Content Shell Framework 0x000000011759184c content::CategorizedWorkerPool::Run(std::__1::vector<cc::TaskCategory, std::__1::allocator<cc::TaskCategory> > const&, base::ConditionVariable*) + 156 38 Content Shell Framework 0x00000001135a436b base::SimpleThread::ThreadMain() + 139 39 Content Shell Framework 0x000000011359bd0f base::(anonymous namespace)::ThreadFunc(void*) + 95 40 libsystem_pthread.dylib 0x00007fff6d6c46c1 _pthread_body + 340 41 libsystem_pthread.dylib 0x00007fff6d6c456d _pthread_body + 0 42 libsystem_pthread.dylib 0x00007fff6d6c3c5d thread_start + 13 [end of stack trace]
,
Feb 21 2018
,
Feb 21 2018
,
Feb 21 2018
It looks like glGetShaderiv didn't give any information. The shader looks valid. Given the name of the test, I suspect the GL context was lost but the GrContext wasn't abandoned.
,
Feb 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecaddad148c18ffc0c2730c731f18146e78cf402 commit ecaddad148c18ffc0c2730c731f18146e78cf402 Author: Emircan Uysaler <emircan@chromium.org> Date: Wed Feb 21 18:58:19 2018 Disable flaky CaptureFromCanvas2DHandlesContextLoss test on mac Bug: 812186 Change-Id: Ib3f6bbddbeffa581533a5e3bfcfc9eb8d63ecd1b Reviewed-on: https://chromium-review.googlesource.com/929422 Reviewed-by: Christian Fremerey <chfremer@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#538171} [modify] https://crrev.com/ecaddad148c18ffc0c2730c731f18146e78cf402/content/browser/webrtc/webrtc_capture_from_element_browsertest.cc
,
Feb 21 2018
In that case, this could be caused (based on the stack trace) by cc::GpuImageDecodeCache holding on to stale SkImages
,
Feb 21 2018
> I suspect the GL context was lost but the GrContext wasn't abandoned. We don't hold onto any context from the capture side. WebGraphicsContext3DProvider is created on the blink side and passed along with SkImage if available. I am not sure where GrContext reference would be held. https://cs.chromium.org/chromium/src/content/renderer/media_capture_from_element/canvas_capture_handler.cc?rcl=0fe5265959e1da13c1521fd7f5f6275a3b83c614&l=182 cc'ing erickr@chromium.org as well.
,
Feb 22 2018
Removing from sheriff queue
,
Feb 22 2018
Detected 13 new flakes for test/step "WebRtcCaptureFromElementBrowserTest.CaptureFromOpaqueCanvas2DHandlesContextLoss". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWgsSBUZsYWtlIk9XZWJSdGNDYXB0dXJlRnJvbUVsZW1lbnRCcm93c2VyVGVzdC5DYXB0dXJlRnJvbU9wYXF1ZUNhbnZhczJESGFuZGxlc0NvbnRleHRMb3NzDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Feb 22 2018
Yeah CaptureFrom*Opaque*Canvas2DHandlesContextLoss seems very flaky on Mac too - it just made my patch fail the commit queue twice in a row! Please can this one be disabled too?
,
Feb 22 2018
Sure, disable CL is up for review here: https://chromium-review.googlesource.com/c/chromium/src/+/931928 bsalomon@ can you advise on what to do next based on #13?
,
Feb 22 2018
What if we just remove the assert from Skia? In Chrome release builds Skia just blindly assumes shader compilation and program linking succeeds. Given the possibility of context-loss perhaps we should do the same in debug.
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/736b548354031110588ee252c531964e45e02ac6 commit 736b548354031110588ee252c531964e45e02ac6 Author: Emircan Uysaler <emircan@chromium.org> Date: Thu Feb 22 20:33:38 2018 Disable flaky CaptureFromOpaqueCanvas2DHandlesContextLoss test on mac Bug: 812186 Change-Id: Iab44e2f37056159b1b9b8a0b0ff8ae0eaf7cceae Reviewed-on: https://chromium-review.googlesource.com/931928 Reviewed-by: Christian Fremerey <chfremer@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#538548} [modify] https://crrev.com/736b548354031110588ee252c531964e45e02ac6/content/browser/webrtc/webrtc_capture_from_element_browsertest.cc
,
Feb 22 2018
Removing from sheriff queue
,
Feb 22 2018
,
Feb 22 2018
I missed a digit in the bug ID in my commit message, but hopefully this change fixes this: https://skia-review.googlesource.com/c/skia/+/109482
,
Feb 23 2018
,
Feb 23 2018
Thanks bsalomon@. I will reenable the tests now.
,
Feb 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/323dda2c4ac95419d752291f17538dd27b3fd721 commit 323dda2c4ac95419d752291f17538dd27b3fd721 Author: Emircan Uysaler <emircan@chromium.org> Date: Fri Feb 23 19:19:00 2018 Reenable flaky CaptureFrom*Canvas2DHandlesContextLoss test on mac Bug: 812186 Change-Id: I441588439e23144311c1960c20ae49aaf75f96e5 TBR: chfremer@chromium.org Reviewed-on: https://chromium-review.googlesource.com/934976 Reviewed-by: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#538852} [modify] https://crrev.com/323dda2c4ac95419d752291f17538dd27b3fd721/content/browser/webrtc/webrtc_capture_from_element_browsertest.cc |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by tschumann@chromium.org
, Feb 14 2018Labels: -Sheriff-Chromium
Owner: chfremer@chromium.org