New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 812183 link

Starred by 2 users
Status: Fixed
Owner:
wzang@chromium.org
Closed: Feb 2018
Cc:
ajha@chromium.org
alemate@chromium.org
█ brajkumar@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Checkbox of 'Update firmware for added security' is seen unchecked on clicking 'Learn More' Link in Powerwash Screen

Project Member Reported by mmanchala@chromium.org, Feb 14 2018 
Chrome Version: 64.0.3282.167/10176.72.0  Stable-channel Daisy,Kip and Reks
OS: Chrome

What steps will reproduce the problem?
1)Sign into User -> Sign out -> In sign-out screen press 'Ctrl+Shift+Alt+R' key to Power wash the Device
(2)'Reset this Chrome device' overlay is seen -> Now click on 'Restart' Button and devices gets restarted -> Again 'Reset this Chrome device' overlay is seen with 'Cancel and 'Powerwash' buttons with 'Update firmware for added security' check box
(3)Now press 'Tab' button until focus reaches 'Learn more' link -> click 'Enter' from keyboard and observe checkbox is unchecked
(Please refer Video)

Expected: Checkbox should not get unchecked on clicking 'Enter' button from keyboard when tab focus is on 'Learn more' link
Actual: Instead  Checkbox is seen unchecked

This is Non-Regression Issue as 'Update firmware for added security' check box is seen from M-63

@alemate : Please confirm the Issue
Actual_Checkbox.mp4
12.0 MB View Download

Comment 1 by wzang@chromium.org, Feb 14 2018

Cc: -wzang@chromium.org alemate@chromium.org
Owner: wzang@chromium.org
I'll take a look.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ccaa77ace4a71a63bfb7b476ce8e8ca2a313ea3

commit 4ccaa77ace4a71a63bfb7b476ce8e8ca2a313ea3
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Feb 15 02:17:03 2018

cros: Fix unchecked 'Update firmware' issue

Since the Learn more link was within paper-checkbox, it will get
triggered by the on-change event.

Bug:  812183 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I29b23fcf6bdeb8e485c36d8e100b39288b3b236a
Reviewed-on: https://chromium-review.googlesource.com/919429
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536928}
[modify] https://crrev.com/4ccaa77ace4a71a63bfb7b476ce8e8ca2a313ea3/chrome/browser/resources/chromeos/login/oobe_reset.css
[modify] https://crrev.com/4ccaa77ace4a71a63bfb7b476ce8e8ca2a313ea3/chrome/browser/resources/chromeos/login/oobe_reset.html

Comment 3 by wzang@chromium.org, Feb 15 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment