Cleanup post switching media::AudioSystem to service-based implementation |
||||||
Issue descriptionKioskVirtualKeyboardDelegateTest: remove AudioManager mock.
,
Oct 1
,
Oct 1
,
Oct 1
,
Dec 17
It's not entirely clear to me why the MockAudioManager was added, but it appears to be unnecessary and it is causing a crash in ioskVirtualKeyboardTest.RestrictFeatures with --enable-features=SingleProcessMash. The test appears to succeed without MockAudioManager with or without SingleProcessMash. https://chromium-review.googlesource.com/c/chromium/src/+/1381147
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53295a7beb27a44387c51cc4763c6871ced2b937 commit 53295a7beb27a44387c51cc4763c6871ced2b937 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Dec 19 22:23:15 2018 Remove MockAudioManager from KioskVirtualKeyboardTest It's not entirely clear why this was added, but it is breaking SingleProcessMash and does not appear to be necessary for the test. Bug: 812170 Change-Id: I35a23d7304000d8c2c56d52da9ac1b8445a32cba Reviewed-on: https://chromium-review.googlesource.com/c/1381147 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#617980} [modify] https://crrev.com/53295a7beb27a44387c51cc4763c6871ced2b937/chrome/browser/chromeos/login/kiosk_browsertest.cc
,
Dec 19
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by zalcorn@chromium.org
, Sep 28