New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 812170 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug


Participants' hotlists:
AudioService-FixIt


Sign in to add a comment

Cleanup post switching media::AudioSystem to service-based implementation

Project Member Reported by olka@chromium.org, Feb 14 2018

Issue description

KioskVirtualKeyboardDelegateTest: remove AudioManager mock.
 
Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.
Components: Internals>Media>Audio
Labels: -Pri-2 Pri-1
Labels: OS-Android OS-Fuchsia OS-Linux OS-Mac OS-Windows
Cc: oka@chromium.org olka@chromium.org
Owner: steve...@chromium.org
Status: Started (was: Assigned)
It's not entirely clear to me why the MockAudioManager was added, but it appears to be unnecessary and it is causing a crash in ioskVirtualKeyboardTest.RestrictFeatures with --enable-features=SingleProcessMash.

The test appears to succeed without MockAudioManager with or without SingleProcessMash.

https://chromium-review.googlesource.com/c/chromium/src/+/1381147

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53295a7beb27a44387c51cc4763c6871ced2b937

commit 53295a7beb27a44387c51cc4763c6871ced2b937
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Dec 19 22:23:15 2018

Remove MockAudioManager from KioskVirtualKeyboardTest

It's not entirely clear why this was added, but it is breaking
SingleProcessMash and does not appear to be necessary for the test.

Bug:  812170 
Change-Id: I35a23d7304000d8c2c56d52da9ac1b8445a32cba
Reviewed-on: https://chromium-review.googlesource.com/c/1381147
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617980}
[modify] https://crrev.com/53295a7beb27a44387c51cc4763c6871ced2b937/chrome/browser/chromeos/login/kiosk_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment